From 24f8130e1f3ff46e7db446b3dec49dff7de7de1f Mon Sep 17 00:00:00 2001 From: Jordan Dominion Date: Fri, 13 Oct 2023 21:45:35 -0400 Subject: [PATCH] Add bad BYOND build 515.1617 --- .github/workflows/ci-pipeline.yml | 8 ++++---- tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs | 6 ++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-pipeline.yml b/.github/workflows/ci-pipeline.yml index 131e2c38c4..6ce724ea5d 100644 --- a/.github/workflows/ci-pipeline.yml +++ b/.github/workflows/ci-pipeline.yml @@ -113,11 +113,11 @@ jobs: echo "EDGE version evaluated to $FULL_VERSION" # Also needs updating in ByondTest.cs - declare -A missing_linux_releases=([515.1612]="515.1611") + declare -A bad_linux_releases=([515.1612]="515.1611" [515.1617]="515.1616") - if [[ -n "${missing_linux_releases[$FULL_VERSION]}" ]] ; then - echo "$FULL_VERSION does not have a linux zip, falling back to ${missing_linux_releases[$FULL_VERSION]}" - FULL_VERSION=${missing_linux_releases[$FULL_VERSION]} + if [[ -n "${bad_linux_releases[$FULL_VERSION]}" ]] ; then + echo "$FULL_VERSION does not have a linux zip, falling back to ${bad_linux_releases[$FULL_VERSION]}" + FULL_VERSION=${bad_linux_releases[$FULL_VERSION]} fi fi if [[ ! -f $HOME/byond-zips-cache/linux/$FULL_VERSION.zip ]] ; then diff --git a/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs b/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs index a19e567770..d688d42f40 100644 --- a/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs +++ b/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs @@ -62,7 +62,7 @@ namespace Tgstation.Server.Tests.Live.Instance var targetVersion = splits.Last(); - var missingVersionMap = new PlatformIdentifier().IsWindows + var badVersionMap = new PlatformIdentifier().IsWindows ? new Dictionary() { } @@ -72,7 +72,9 @@ namespace Tgstation.Server.Tests.Live.Instance { "515.1612", "515.1611" } }; - if (missingVersionMap.TryGetValue(targetVersion, out var remappedVersion)) + badVersionMap.Add("515.1617", "515.1616"); + + if (badVersionMap.TryGetValue(targetVersion, out var remappedVersion)) targetVersion = remappedVersion; return edgeVersion = Version.Parse(targetVersion);