From 4ed133323a6ea4e3f98ed965d3396bf5da6cf34b Mon Sep 17 00:00:00 2001 From: Jordan Dominion Date: Sun, 2 Jul 2023 18:37:05 -0400 Subject: [PATCH] Update notes about forks with code signing secrets --- .github/CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index d563d8c97c..6f4a8cdab8 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -74,6 +74,8 @@ If you don't plan on deploying TGS, the following secrets can be omitted: - Secret `DOCKER_USERNAME`: Login username for Docker image push. - Secret `DOCKER_PASSWORD`: Login password for Docker image push. - Secret `NUGET_API_KEY`: Nuget.org API Key for client libraries push. +- Secret `CODE_SIGNING_BASE64`: Base64 string of a .pfx file containing a Windows code-signing certificate. +- Secret `CODE_SIGNING_PASSWORD`: Password for importing the above .pfx. ### Know your Code @@ -150,10 +152,13 @@ void Hello() { if (!thing1) return; + if (thing2) return; + if (thing3 != 30) return; + do stuff } ```