diff --git a/src/Tgstation.Server.Host/Components/Repository/DefaultGitRemoteFeatures.cs b/src/Tgstation.Server.Host/Components/Repository/DefaultGitRemoteFeatures.cs index e379ae233a..ead4007720 100644 --- a/src/Tgstation.Server.Host/Components/Repository/DefaultGitRemoteFeatures.cs +++ b/src/Tgstation.Server.Host/Components/Repository/DefaultGitRemoteFeatures.cs @@ -27,7 +27,7 @@ namespace Tgstation.Server.Host.Components.Repository public string RemoteRepositoryName => null; /// - public Task GetTestMerge( + public ValueTask GetTestMerge( TestMergeParameters parameters, Api.Models.Internal.RepositorySettings repositorySettings, CancellationToken cancellationToken) => throw new NotSupportedException(); diff --git a/src/Tgstation.Server.Host/Components/Repository/GitHubRemoteFeatures.cs b/src/Tgstation.Server.Host/Components/Repository/GitHubRemoteFeatures.cs index ecbda4c74c..6e5d5c4ec0 100644 --- a/src/Tgstation.Server.Host/Components/Repository/GitHubRemoteFeatures.cs +++ b/src/Tgstation.Server.Host/Components/Repository/GitHubRemoteFeatures.cs @@ -56,7 +56,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - protected override async Task GetTestMergeImpl( + protected override async ValueTask GetTestMergeImpl( TestMergeParameters parameters, RepositorySettings repositorySettings, CancellationToken cancellationToken) diff --git a/src/Tgstation.Server.Host/Components/Repository/GitLabRemoteFeatures.cs b/src/Tgstation.Server.Host/Components/Repository/GitLabRemoteFeatures.cs index 236c125112..def1adbaaf 100644 --- a/src/Tgstation.Server.Host/Components/Repository/GitLabRemoteFeatures.cs +++ b/src/Tgstation.Server.Host/Components/Repository/GitLabRemoteFeatures.cs @@ -51,7 +51,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - protected override async Task GetTestMergeImpl( + protected override async ValueTask GetTestMergeImpl( TestMergeParameters parameters, RepositorySettings repositorySettings, CancellationToken cancellationToken) diff --git a/src/Tgstation.Server.Host/Components/Repository/GitRemoteFeaturesBase.cs b/src/Tgstation.Server.Host/Components/Repository/GitRemoteFeaturesBase.cs index a1ec955e4d..1b1c5337af 100644 --- a/src/Tgstation.Server.Host/Components/Repository/GitRemoteFeaturesBase.cs +++ b/src/Tgstation.Server.Host/Components/Repository/GitRemoteFeaturesBase.cs @@ -54,7 +54,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - public async Task GetTestMerge( + public async ValueTask GetTestMerge( TestMergeParameters parameters, RepositorySettings repositorySettings, CancellationToken cancellationToken) @@ -85,8 +85,8 @@ namespace Tgstation.Server.Host.Components.Repository /// The . /// The . /// The for the operation. - /// A resulting in the of the . - protected abstract Task GetTestMergeImpl( + /// A resulting in the of the . + protected abstract ValueTask GetTestMergeImpl( TestMergeParameters parameters, RepositorySettings repositorySettings, CancellationToken cancellationToken); diff --git a/src/Tgstation.Server.Host/Components/Repository/IGitRemoteAdditionalInformation.cs b/src/Tgstation.Server.Host/Components/Repository/IGitRemoteAdditionalInformation.cs index f859817565..ffead020f9 100644 --- a/src/Tgstation.Server.Host/Components/Repository/IGitRemoteAdditionalInformation.cs +++ b/src/Tgstation.Server.Host/Components/Repository/IGitRemoteAdditionalInformation.cs @@ -17,9 +17,9 @@ namespace Tgstation.Server.Host.Components.Repository /// The . /// The . /// The for the operation. - /// A resulting in the of the . + /// A resulting in the of the . /// and will be unset. - Task GetTestMerge( + ValueTask GetTestMerge( TestMergeParameters parameters, RepositorySettings repositorySettings, CancellationToken cancellationToken); diff --git a/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs b/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs index b03048ccf6..34b8c56669 100644 --- a/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs +++ b/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs @@ -22,8 +22,8 @@ namespace Tgstation.Server.Host.Components.Repository /// /// The full path to the . /// The for the operation. - /// A resulting in the loaded . - Task CreateFromPath(string path, CancellationToken cancellationToken); + /// A resulting in the loaded . + ValueTask CreateFromPath(string path, CancellationToken cancellationToken); /// /// Clone a remote . diff --git a/src/Tgstation.Server.Host/Components/Repository/IRepository.cs b/src/Tgstation.Server.Host/Components/Repository/IRepository.cs index 07c29dc220..5cce4208ea 100644 --- a/src/Tgstation.Server.Host/Components/Repository/IRepository.cs +++ b/src/Tgstation.Server.Host/Components/Repository/IRepository.cs @@ -49,8 +49,8 @@ namespace Tgstation.Server.Host.Components.Repository /// If a submodule update should be attempted after the merge. /// The to report progress of the operation. /// The for the operation. - /// A representing the running operation. - Task CheckoutObject( + /// A representing the running operation. + ValueTask CheckoutObject( string committish, string username, string password, @@ -69,8 +69,8 @@ namespace Tgstation.Server.Host.Components.Repository /// If a submodule update should be attempted after the merge. /// The to report progress of the operation. /// The for the operation. - /// A resulting in the . - Task AddTestMerge( + /// A resulting in the . + ValueTask AddTestMerge( TestMergeParameters testMergeParameters, string committerName, string committerEmail, @@ -88,8 +88,8 @@ namespace Tgstation.Server.Host.Components.Repository /// The password to fetch from the origin repository. /// If any events created should be marked as part of the deployment pipeline. /// The for the operation. - /// A representing the running operation. - Task FetchOrigin( + /// A representing the running operation. + ValueTask FetchOrigin( JobProgressReporter progressReporter, string username, string password, @@ -105,8 +105,8 @@ namespace Tgstation.Server.Host.Components.Repository /// If a submodule update should be attempted after the merge. /// If any events created should be marked as part of the deployment pipeline. /// The for the operation. - /// A resulting in the SHA of the new HEAD. - Task ResetToOrigin( + /// A resulting in the SHA of the new HEAD. + ValueTask ResetToOrigin( JobProgressReporter progressReporter, string username, string password, @@ -131,8 +131,8 @@ namespace Tgstation.Server.Host.Components.Repository /// The e-mail of the merge committer. /// If any events created should be marked as part of the deployment pipeline. /// The for the operation. - /// A resulting in a representing the merge result that is after a fast forward, on a merge or up to date, on a conflict. - Task MergeOrigin( + /// A resulting in a representing the merge result that is after a fast forward, on a merge or up to date, on a conflict. + ValueTask MergeOrigin( JobProgressReporter progressReporter, string committerName, string committerEmail, @@ -150,8 +150,8 @@ namespace Tgstation.Server.Host.Components.Repository /// If the synchronizations should be made to the tracked reference as opposed to a temporary branch. /// If any events created should be marked as part of the deployment pipeline. /// The for the operation. - /// A resulting in if commits were pushed to the tracked origin reference, otherwise. - Task Sychronize( + /// A resulting in if commits were pushed to the tracked origin reference, otherwise. + ValueTask Sychronize( JobProgressReporter progressReporter, string username, string password, @@ -166,8 +166,8 @@ namespace Tgstation.Server.Host.Components.Repository /// /// The path to copy repository contents to. /// The for the operation. - /// A representing the running operation. - Task CopyTo(string path, CancellationToken cancellationToken); + /// A representing the running operation. + ValueTask CopyTo(string path, CancellationToken cancellationToken); /// /// Check if a given is a parent of the current . diff --git a/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs b/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs index 2bbc60cccd..83011a61b1 100644 --- a/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs +++ b/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs @@ -38,7 +38,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - public async Task CreateFromPath(string path, CancellationToken cancellationToken) + public async ValueTask CreateFromPath(string path, CancellationToken cancellationToken) { ArgumentNullException.ThrowIfNull(path); diff --git a/src/Tgstation.Server.Host/Components/Repository/Repository.cs b/src/Tgstation.Server.Host/Components/Repository/Repository.cs index 2748e5ec6c..a7dc248692 100644 --- a/src/Tgstation.Server.Host/Components/Repository/Repository.cs +++ b/src/Tgstation.Server.Host/Components/Repository/Repository.cs @@ -181,7 +181,7 @@ namespace Tgstation.Server.Host.Components.Repository /// #pragma warning disable CA1506 // TODO: Decomplexify - public async Task AddTestMerge( + public async ValueTask AddTestMerge( TestMergeParameters testMergeParameters, string committerName, string committerEmail, @@ -384,7 +384,7 @@ namespace Tgstation.Server.Host.Components.Repository #pragma warning restore CA1506 /// - public async Task CheckoutObject( + public async ValueTask CheckoutObject( string committish, string username, string password, @@ -419,7 +419,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - public async Task FetchOrigin( + public async ValueTask FetchOrigin( JobProgressReporter progressReporter, string username, string password, @@ -466,7 +466,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - public async Task ResetToOrigin( + public async ValueTask ResetToOrigin( JobProgressReporter progressReporter, string username, string password, @@ -522,7 +522,7 @@ namespace Tgstation.Server.Host.Components.Repository TaskScheduler.Current); /// - public async Task CopyTo(string path, CancellationToken cancellationToken) + public async ValueTask CopyTo(string path, CancellationToken cancellationToken) { ArgumentNullException.ThrowIfNull(path); logger.LogTrace("Copying to {path}...", path); @@ -557,7 +557,7 @@ namespace Tgstation.Server.Host.Components.Repository TaskScheduler.Current); /// - public async Task MergeOrigin( + public async ValueTask MergeOrigin( JobProgressReporter progressReporter, string committerName, string committerEmail, @@ -636,7 +636,7 @@ namespace Tgstation.Server.Host.Components.Repository } /// - public async Task Sychronize( + public async ValueTask Sychronize( JobProgressReporter progressReporter, string username, string password, @@ -828,7 +828,7 @@ namespace Tgstation.Server.Host.Components.Repository TaskScheduler.Current); /// - public Task GetTestMerge( + public ValueTask GetTestMerge( TestMergeParameters parameters, RepositorySettings repositorySettings, CancellationToken cancellationToken) => gitRemoteFeatures.GetTestMerge(