From 7413b7afacc8b44da986332cc2e8a0d49df2f397 Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Mon, 3 Jul 2023 23:14:24 -0400
Subject: [PATCH] Clean up service (un)installation

- Switch back to programmatic installs with the help of the Nuget package we use in `Tgstation.Server.Migrator`.
- Document usage of `Microsoft.Extensions.Hosting.WindowsServices`.
---
 src/Tgstation.Server.Host.Service/Program.cs  | 80 +++++++++++++------
 .../Tgstation.Server.Host.Service.csproj      |  3 +
 2 files changed, 57 insertions(+), 26 deletions(-)

diff --git a/src/Tgstation.Server.Host.Service/Program.cs b/src/Tgstation.Server.Host.Service/Program.cs
index fcd4cdb19e..23a9e45c23 100644
--- a/src/Tgstation.Server.Host.Service/Program.cs
+++ b/src/Tgstation.Server.Host.Service/Program.cs
@@ -1,5 +1,6 @@
 using System;
-using System.Diagnostics;
+using System.Collections.Specialized;
+using System.Configuration.Install;
 using System.IO;
 using System.Reflection;
 using System.ServiceProcess;
@@ -87,27 +88,58 @@ namespace Tgstation.Server.Host.Service
 		/// Runs sc.exe to either uninstall a given <paramref name="serviceToUninstall"/> or install the running <see cref="ServerService"/>.
 		/// </summary>
 		/// <param name="serviceToUninstall">The name of a service to uninstall.</param>
-		/// <returns>A <see cref="ValueTask"/> representing the running operation.</returns>
-		static async ValueTask InvokeSC(string serviceToUninstall)
+		static void InvokeSC(string serviceToUninstall)
 		{
-			using var process = new Process();
-			process.StartInfo.FileName = "C:/Windows/System32/sc.exe";
+			using var installer = new ServiceInstaller();
+			if (serviceToUninstall != null)
+			{
+				installer.Context = new InstallContext($"old-{serviceToUninstall}-uninstall.log", null);
+				installer.ServiceName = serviceToUninstall;
+				installer.Uninstall(null);
+			}
+			else
+			{
+				var fullPathToAssembly = Path.GetFullPath(
+					Assembly.GetExecutingAssembly().Location);
 
-			var fullPathToAssembly = Path.GetFullPath(
-				Assembly.GetExecutingAssembly().Location);
+				var assemblyDirectory = Path.GetDirectoryName(fullPathToAssembly);
+				var assemblyNameWithoutExtension = Path.GetFileNameWithoutExtension(fullPathToAssembly);
+				var exePath = Path.Combine(assemblyDirectory, $"{assemblyNameWithoutExtension}.exe");
 
-			var assemblyDirectory = Path.GetDirectoryName(fullPathToAssembly);
-			var assemblyNameWithoutExtension = Path.GetFileNameWithoutExtension(fullPathToAssembly);
-			var exePath = Path.Combine(assemblyDirectory, $"{assemblyNameWithoutExtension}.exe");
+				var programDataDirectory = Path.Combine(
+					Environment.GetFolderPath(Environment.SpecialFolder.CommonApplicationData),
+					Server.Common.Constants.CanonicalPackageName);
 
-			process.StartInfo.Arguments = serviceToUninstall == null
-				? $"create tgstation-server binPath=\"{exePath}\" start=auto depend=Tcpip/Dhcp/Dnscache"
-				: $"delete {serviceToUninstall}";
-			process.StartInfo.CreateNoWindow = false;
+				using var processInstaller = new ServiceProcessInstaller();
+				processInstaller.Account = ServiceAccount.LocalSystem;
 
-			process.Start();
+				// Mimicing Tgstation.Server.Host.Service.Wix here, which is the source of truth for this data
+				installer.Context = new InstallContext(
+					Path.Combine(programDataDirectory, $"tgs-install-{Guid.NewGuid()}.log"),
+					new[]
+					{
+						$"assemblypath=\"{exePath}\" -p=--appsettings-base-path={programDataDirectory}",
+					});
+				installer.Description = $"{Server.Common.Constants.CanonicalPackageName} running as a Windows service.";
+				installer.DisplayName = Server.Common.Constants.CanonicalPackageName;
+				installer.StartType = ServiceStartMode.Automatic;
+				installer.ServicesDependedOn = new string[] { "Tcpip", "Dhcp", "Dnscache" };
+				installer.ServiceName = ServerService.Name;
+				installer.Parent = processInstaller;
 
-			await process.WaitForExitAsync();
+				var state = new ListDictionary();
+				try
+				{
+					installer.Install(state);
+
+					installer.Commit(state);
+				}
+				catch
+				{
+					installer.Rollback(state);
+					throw;
+				}
+			}
 		}
 
 		/// <summary>
@@ -156,17 +188,14 @@ namespace Tgstation.Server.Host.Service
 					}
 
 					if (match)
-					{
-						await InvokeSC(ServerService.Name);
-						break;
-					}
+						InvokeSC(ServerService.Name);
 				}
 
 				stopped = true;
 			}
 
 			if (Install)
-				stopped |= await RunServiceInstall();
+				stopped |= RunServiceInstall();
 
 			if (Restart)
 				foreach (ServiceController sc in ServiceController.GetServices())
@@ -177,15 +206,14 @@ namespace Tgstation.Server.Host.Service
 								RestartService(sc);
 
 							sc.Start();
-							break;
 						}
 		}
 
 		/// <summary>
 		/// Attempt to install the TGS Service.
 		/// </summary>
-		/// <returns>A <see cref="ValueTask{TResult}"/> resulting in <see langword="true"/> if the service was stopped or detached as a result, <see langword="false"/> otherwise.</returns>
-		async ValueTask<bool> RunServiceInstall()
+		/// <returns><see langword="true"/> if the service was stopped or detached as a result, <see langword="false"/> otherwise.</returns>
+		bool RunServiceInstall()
 		{
 			// First check if the service already exists
 			bool serviceStopped = false;
@@ -210,11 +238,11 @@ namespace Tgstation.Server.Host.Service
 							RestartService(sc);
 
 							// And remove it
-							await InvokeSC(sc.ServiceName);
+							InvokeSC(sc.ServiceName);
 						}
 					}
 
-			await InvokeSC(null);
+			InvokeSC(null);
 
 			return serviceStopped;
 		}
diff --git a/src/Tgstation.Server.Host.Service/Tgstation.Server.Host.Service.csproj b/src/Tgstation.Server.Host.Service/Tgstation.Server.Host.Service.csproj
index dbac1b371e..48eb72358e 100644
--- a/src/Tgstation.Server.Host.Service/Tgstation.Server.Host.Service.csproj
+++ b/src/Tgstation.Server.Host.Service/Tgstation.Server.Host.Service.csproj
@@ -12,8 +12,11 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <!-- Usage: Installing service programatically -->
+    <PackageReference Include="Core.System.ServiceProcess" Version="2.0.1" />
     <!-- Usage: Command line argument support -->
     <PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="4.0.2" />
+    <!-- Usage: Identifies when we are running in the context of the Windows SCM -->
     <PackageReference Include="Microsoft.Extensions.Hosting.WindowsServices" Version="7.0.1" />
     <!-- Usage: Windows event log logging plugin -->
     <PackageReference Include="Microsoft.Extensions.Logging.EventLog" Version="7.0.0" />