diff --git a/src/Tgstation.Server.Host/Core/Application.cs b/src/Tgstation.Server.Host/Core/Application.cs index 09f246f4c9..5ea86917cc 100644 --- a/src/Tgstation.Server.Host/Core/Application.cs +++ b/src/Tgstation.Server.Host/Core/Application.cs @@ -133,7 +133,7 @@ namespace Tgstation.Server.Host.Core // other stuff needed for for setup wizard and configuration services.AddSingleton(); - services.AddSingleton(); + services.AddSingleton(); services.AddSingleton(); services.AddSingleton(); services.AddSingleton(); diff --git a/src/Tgstation.Server.Host/Core/DBConnectionFactory.cs b/src/Tgstation.Server.Host/Core/DatabaseConnectionFactory.cs similarity index 90% rename from src/Tgstation.Server.Host/Core/DBConnectionFactory.cs rename to src/Tgstation.Server.Host/Core/DatabaseConnectionFactory.cs index 8378d28d00..781852ec6a 100644 --- a/src/Tgstation.Server.Host/Core/DBConnectionFactory.cs +++ b/src/Tgstation.Server.Host/Core/DatabaseConnectionFactory.cs @@ -2,13 +2,12 @@ using System; using System.Data.Common; using System.Data.SqlClient; -using System.Globalization; using Tgstation.Server.Host.Configuration; namespace Tgstation.Server.Host.Core { /// - sealed class DBConnectionFactory : IDBConnectionFactory + sealed class DatabaseConnectionFactory : IDatabaseConnectionFactory { /// public DbConnection CreateConnection(string connectionString, DatabaseType databaseType) diff --git a/src/Tgstation.Server.Host/Core/IDBConnectionFactory.cs b/src/Tgstation.Server.Host/Core/IDatabaseConnectionFactory.cs similarity index 93% rename from src/Tgstation.Server.Host/Core/IDBConnectionFactory.cs rename to src/Tgstation.Server.Host/Core/IDatabaseConnectionFactory.cs index 3f378b88b5..3211d1e99f 100644 --- a/src/Tgstation.Server.Host/Core/IDBConnectionFactory.cs +++ b/src/Tgstation.Server.Host/Core/IDatabaseConnectionFactory.cs @@ -6,7 +6,7 @@ namespace Tgstation.Server.Host.Core /// /// For creating /// - interface IDBConnectionFactory + interface IDatabaseConnectionFactory { /// /// Create a diff --git a/src/Tgstation.Server.Host/Core/SetupWizard.cs b/src/Tgstation.Server.Host/Core/SetupWizard.cs index d461cbff98..01b1bc67d2 100644 --- a/src/Tgstation.Server.Host/Core/SetupWizard.cs +++ b/src/Tgstation.Server.Host/Core/SetupWizard.cs @@ -42,9 +42,9 @@ namespace Tgstation.Server.Host.Core readonly IApplication application; /// - /// The for the + /// The for the /// - readonly IDBConnectionFactory dbConnectionFactory; + readonly IDatabaseConnectionFactory dbConnectionFactory; /// /// The for the @@ -78,7 +78,7 @@ namespace Tgstation.Server.Host.Core /// The value of /// The value of /// The containing the value of - public SetupWizard(IIOManager ioManager, IConsole console, IHostingEnvironment hostingEnvironment, IApplication application, IDBConnectionFactory dbConnectionFactory, IPlatformIdentifier platformIdentifier, IAsyncDelayer asyncDelayer, ILogger logger, IOptions generalConfigurationOptions) + public SetupWizard(IIOManager ioManager, IConsole console, IHostingEnvironment hostingEnvironment, IApplication application, IDatabaseConnectionFactory dbConnectionFactory, IPlatformIdentifier platformIdentifier, IAsyncDelayer asyncDelayer, ILogger logger, IOptions generalConfigurationOptions) { this.ioManager = ioManager ?? throw new ArgumentNullException(nameof(ioManager)); this.console = console ?? throw new ArgumentNullException(nameof(console)); diff --git a/tests/Tgstation.Server.Host.Tests/Core/TestDBConnectionFactory.cs b/tests/Tgstation.Server.Host.Tests/Core/TestDBConnectionFactory.cs index 39abca29bb..fd77f17097 100644 --- a/tests/Tgstation.Server.Host.Tests/Core/TestDBConnectionFactory.cs +++ b/tests/Tgstation.Server.Host.Tests/Core/TestDBConnectionFactory.cs @@ -12,7 +12,7 @@ namespace Tgstation.Server.Host.Core.Tests [TestMethod] public void TestBadParameters() { - var factory = new DBConnectionFactory(); + var factory = new DatabaseConnectionFactory(); Assert.ThrowsException(() => factory.CreateConnection(null, default)); Assert.ThrowsException(() => factory.CreateConnection(String.Empty, (DatabaseType)42)); } @@ -20,7 +20,7 @@ namespace Tgstation.Server.Host.Core.Tests [TestMethod] public void TestWorks() { - var factory = new DBConnectionFactory(); + var factory = new DatabaseConnectionFactory(); Assert.IsInstanceOfType(factory.CreateConnection(String.Empty, DatabaseType.MariaDB), typeof(MySqlConnection)); Assert.IsInstanceOfType(factory.CreateConnection(String.Empty, DatabaseType.MySql), typeof(MySqlConnection)); Assert.IsInstanceOfType(factory.CreateConnection(String.Empty, DatabaseType.SqlServer), typeof(SqlConnection)); diff --git a/tests/Tgstation.Server.Host.Tests/Core/TestSetupWizard.cs b/tests/Tgstation.Server.Host.Tests/Core/TestSetupWizard.cs index 0248dedc8f..c3ce0a0894 100644 --- a/tests/Tgstation.Server.Host.Tests/Core/TestSetupWizard.cs +++ b/tests/Tgstation.Server.Host.Tests/Core/TestSetupWizard.cs @@ -31,7 +31,7 @@ namespace Tgstation.Server.Host.Core.Tests Assert.ThrowsException(() => new SetupWizard(mockIOManager.Object, mockConsole.Object, mockHostingEnvironment.Object, null, null, null, null, null, null)); var mockApplication = new Mock(); Assert.ThrowsException(() => new SetupWizard(mockIOManager.Object, mockConsole.Object, mockHostingEnvironment.Object, mockApplication.Object, null, null, null, null, null)); - var mockDBConnectionFactory = new Mock(); + var mockDBConnectionFactory = new Mock(); Assert.ThrowsException(() => new SetupWizard(mockIOManager.Object, mockConsole.Object, mockHostingEnvironment.Object, mockApplication.Object, mockDBConnectionFactory.Object, null, null, null, null)); var mockPlatformIdentifier = new Mock(); Assert.ThrowsException(() => new SetupWizard(mockIOManager.Object, mockConsole.Object, mockHostingEnvironment.Object, mockApplication.Object, mockDBConnectionFactory.Object, mockPlatformIdentifier.Object, null, null, null)); @@ -48,7 +48,7 @@ namespace Tgstation.Server.Host.Core.Tests var mockConsole = new Mock(); var mockHostingEnvironment = new Mock(); var mockApplication = new Mock(); - var mockDBConnectionFactory = new Mock(); + var mockDBConnectionFactory = new Mock(); var mockLogger = new Mock>(); var mockGeneralConfigurationOptions = new Mock>(); var mockPlatformIdentifier = new Mock();