diff --git a/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs b/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs
index be208c68be..0d2cf0fd64 100644
--- a/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs
@@ -470,6 +470,7 @@ namespace Tgstation.Server.Host.Components.Chat
///
public async Task DeleteConnection(long connectionId, CancellationToken cancellationToken)
{
+ logger.LogTrace("DeleteConnection {connectionId}", connectionId);
var provider = await RemoveProviderChannels(connectionId, true, cancellationToken);
if (provider != null)
try
@@ -480,6 +481,8 @@ namespace Tgstation.Server.Host.Components.Chat
{
await provider.DisposeAsync();
}
+ else
+ logger.LogTrace("DeleteConnection: ID {connectionId} doesn't exist!", connectionId);
}
///
diff --git a/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordForwardingResponder.cs b/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordForwardingResponder.cs
index 42bbe937d9..85444cb499 100644
--- a/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordForwardingResponder.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordForwardingResponder.cs
@@ -31,6 +31,6 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
public Task RespondAsync(IMessageCreate gatewayEvent, CancellationToken ct) => targetResponder.RespondAsync(gatewayEvent, ct);
///
- public Task RespondAsync(IReady gatewayEvent, CancellationToken ct = default) => targetResponder.RespondAsync(gatewayEvent, ct);
+ public Task RespondAsync(IReady gatewayEvent, CancellationToken ct) => targetResponder.RespondAsync(gatewayEvent, ct);
}
}
diff --git a/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs b/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs
index 658dfdc3a0..d7b3e2047c 100644
--- a/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs
@@ -197,8 +197,9 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
{
await base.DisposeAsync();
await serviceProvider.DisposeAsync();
+ Logger.LogTrace("ServiceProvider disposed");
- // this line is purely here to shutup CA2213
+ // this line is purely here to shutup CA2213. It should always be null
gatewayCts?.Dispose();
}
diff --git a/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs b/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs
index a9468d603a..17f2b35fb2 100644
--- a/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs
@@ -224,6 +224,7 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
/// A representing the running operation.
Task StopReconnectionTimer()
{
+ Logger.LogTrace("StopReconnectionTimer");
lock (reconnectTaskLock)
if (reconnectCts != null)
{
@@ -234,6 +235,8 @@ namespace Tgstation.Server.Host.Components.Chat.Providers
this.reconnectTask = null;
return reconnectTask;
}
+ else
+ Logger.LogTrace("Timer wasn't running");
return Task.CompletedTask;
}