From 9c5c5b2ef4c57aa8acfa8ae791876fed6ab01136 Mon Sep 17 00:00:00 2001 From: Jordan Dominion Date: Sat, 14 Oct 2023 14:46:04 -0400 Subject: [PATCH] Woe is me for not using operator overloading --- src/Tgstation.Server.Host/Components/Engine/EngineManager.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Tgstation.Server.Host/Components/Engine/EngineManager.cs b/src/Tgstation.Server.Host/Components/Engine/EngineManager.cs index 0ae4dbf9ee..ae19ad5d5b 100644 --- a/src/Tgstation.Server.Host/Components/Engine/EngineManager.cs +++ b/src/Tgstation.Server.Host/Components/Engine/EngineManager.cs @@ -216,7 +216,6 @@ namespace Tgstation.Server.Host.Components.Engine logger.LogTrace("Installation container acquired for deletion"); } - logger.LogInformation("Deleting version {version}...", version); progressReporter.StageName = "Waiting for version to not be in use..."; while (true) { @@ -241,7 +240,7 @@ namespace Tgstation.Server.Host.Components.Engine using (await SemaphoreSlimContext.Lock(changeDeleteSemaphore, cancellationToken)) { // check again because it could have become the active version. - if (version == ActiveVersion) + if (version.Equals(ActiveVersion)) throw new JobException(ErrorCode.EngineCannotDeleteActiveVersion); bool proceed; @@ -274,6 +273,7 @@ namespace Tgstation.Server.Host.Components.Engine if (proceed) { + logger.LogInformation("Deleting version {version}...", version); progressReporter.StageName = "Deleting installation..."; // delete the version file first, because we will know not to re-discover the installation if it's not present and it will get cleaned on reboot