From a95e8f8ed08b666563ab3a07a4978773ca5c9c2c Mon Sep 17 00:00:00 2001 From: Dominion Date: Sat, 15 Apr 2023 15:03:10 -0400 Subject: [PATCH] GET requests are logged as Trace /Jobs GET requests are ignored --- .../Controllers/ApiController.cs | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/Tgstation.Server.Host/Controllers/ApiController.cs b/src/Tgstation.Server.Host/Controllers/ApiController.cs index 172f81ddd2..fdea1e26f0 100644 --- a/src/Tgstation.Server.Host/Controllers/ApiController.cs +++ b/src/Tgstation.Server.Host/Controllers/ApiController.cs @@ -179,11 +179,18 @@ namespace Tgstation.Server.Host.Controllers using (LogContext.PushProperty("Request", $"{Request.Method} {Request.Path}")) { if (ApiHeaders != null) - Logger.LogDebug( - "Starting API request: Version: {clientApiVersion}. {userAgentHeaderName}: {clientUserAgent}", - ApiHeaders.ApiVersion.Semver(), - HeaderNames.UserAgent, - ApiHeaders.RawUserAgent); + { + var isGet = HttpMethods.IsGet(Request.Method); + if (!(isGet && Request.Path.StartsWithSegments(Routes.Jobs, StringComparison.OrdinalIgnoreCase))) + Logger.Log( + isGet + ? LogLevel.Trace + : LogLevel.Debug, + "Starting API request: Version: {clientApiVersion}. {userAgentHeaderName}: {clientUserAgent}", + ApiHeaders.ApiVersion.Semver(), + HeaderNames.UserAgent, + ApiHeaders.RawUserAgent); + } else if (Request.Headers.TryGetValue(HeaderNames.UserAgent, out var userAgents)) Logger.LogDebug( "Starting unauthorized API request. {userAgentHeaderName}: {allUserAgents}",