From aa8ae78167042d084fab04f44843751f55de5deb Mon Sep 17 00:00:00 2001 From: Jordan Dominion Date: Mon, 26 Jun 2023 14:21:47 -0400 Subject: [PATCH] Fix CI msiexec uninstall flag Also remove useless calls and assignments --- .github/workflows/ci-suite.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-suite.yml b/.github/workflows/ci-suite.yml index 230cd25634..92d740655d 100644 --- a/.github/workflows/ci-suite.yml +++ b/.github/workflows/ci-suite.yml @@ -991,8 +991,7 @@ jobs: run: | $file = [System.IO.Path]::GetFullPath("packaging/build/package/winget/Tgstation.Server.Host.Service.Msi/Release/tgstation-server.msi") $log = [System.IO.Path]::GetFullPath("install.log") - $procMain = Start-Process "msiexec" "/i `"$file`" /qn /l*! `"$log`"" -NoNewWindow -PassThru -Wait - $procMain.WaitForExit() + Start-Process "msiexec" "/i `"$file`" /qn /l*! `"$log`"" -NoNewWindow -PassThru -Wait if (Test-Path -Path $log -PathType Leaf) { Get-Content $log } @@ -1018,8 +1017,7 @@ jobs: run: | $file = [System.IO.Path]::GetFullPath("packaging/build/package/winget/Tgstation.Server.Host.Service.Msi/Release/tgstation-server.msi") $log = [System.IO.Path]::GetFullPath("uninstall.log") - $procMain = Start-Process "msiexec" "/u `"$file`" /qn /l*! `"$log`"" -NoNewWindow -PassThru -Wait - $procMain.WaitForExit() + Start-Process "msiexec" "/x `"$file`" /qn /l*! `"$log`"" -NoNewWindow -PassThru -Wait if (Test-Path -Path $log -PathType Leaf) { Get-Content $log }