From 972a06060b60fdd6660821472811723a7f554360 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Tue, 31 Oct 2017 19:16:06 -0400 Subject: [PATCH 1/3] Documents the versioning system --- .github/CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index f750428a65..50b3827b1e 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -90,7 +90,11 @@ Instead you can use object orientation, or simply placing repeated code in a fun This means stuff like having a "mode" variable for an object set to "1" or "2" with no clear indicator of what that means. Make these #defines with a name that more clearly states what it's for. This is clearer and enhances readability of your code! Get used to doing it! ### Do not commit modifications to Version.cs -This file will be updated by maintainers when they deem it prudent to release a new version +This file will be updated by maintainers when they deem it prudent to release a new version. For reference here is the version format we use 3.... The criteria for changing a version number is as follows + +- Major: A breaking change to the DMAPI +- Minor: Additions or changes to the interface or DMAPI +- Patch: Non-breaking changes internal to each of the 3 modules (Service, Interface, DMAPI) ### Formatting From c90d9a30b11da5edc935b7e288c0d57e10aa3074 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Tue, 31 Oct 2017 19:17:30 -0400 Subject: [PATCH 2/3] Proper formatting --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 50b3827b1e..b20123d9fd 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -90,7 +90,7 @@ Instead you can use object orientation, or simply placing repeated code in a fun This means stuff like having a "mode" variable for an object set to "1" or "2" with no clear indicator of what that means. Make these #defines with a name that more clearly states what it's for. This is clearer and enhances readability of your code! Get used to doing it! ### Do not commit modifications to Version.cs -This file will be updated by maintainers when they deem it prudent to release a new version. For reference here is the version format we use 3.... The criteria for changing a version number is as follows +This file will be updated by maintainers when they deem it prudent to release a new version. For reference here is the version format we use 3.\.\.\ The criteria for changing a version number is as follows - Major: A breaking change to the DMAPI - Minor: Additions or changes to the interface or DMAPI From f132d70f17fa00ad29b260f61d2e6f17bdf94636 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Wed, 1 Nov 2017 09:58:17 -0400 Subject: [PATCH 3/3] Removes UnmanagedExports nupkg dependency for real --- TGServiceInterface/packages.config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TGServiceInterface/packages.config b/TGServiceInterface/packages.config index bfd9f475da..cb56911aa6 100644 --- a/TGServiceInterface/packages.config +++ b/TGServiceInterface/packages.config @@ -1,4 +1,4 @@  - - \ No newline at end of file + +