cyberpresidentvanellope/tgstation-server
1
0
Fork 0
mirror of https://github.com/tgstation/tgstation-server.git synced 2026-07-15 01:52:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix always() always never respecting a goddamn cancel command!

Browse Source
This commit is contained in:
Dominion
2023-04-29 16:04:10 -04:00
parent bff25c7d5b
commit adbc603c80
1 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci-suite.yml
+17 -17
View File
@@ -54,7 +54,7 @@ jobs:
name: Start CI Run Gate
needs: security-checkpoint
runs-on: ubuntu-latest
if: always() && (needs.security-checkpoint.result == 'success' || (needs.security-checkpoint.result == 'skipped' && (github.event_name == 'push' || (github.event.pull_request.head.repo.id == github.event.pull_request.base.repo.id && github.event.action != 'labeled'))))
if: "!(cancelled() || failure()) && (needs.security-checkpoint.result == 'success' || (needs.security-checkpoint.result == 'skipped' && (github.event_name == 'push' || (github.event.pull_request.head.repo.id == github.event.pull_request.base.repo.id && github.event.action != 'labeled'))))"
steps:
- name: GitHub Requires at Least One Step for a Job
run: exit 0
@@ -62,7 +62,7 @@ jobs:
analyze:
name: Code Scanning
needs: start-ci-run-gate
if: always() && needs.start-ci-run-gate.result == 'success'
if: "!(cancelled() || failure()) && needs.start-ci-run-gate.result == 'success'"
runs-on: ubuntu-latest
steps:
- name: Install Node 12.X
@@ -100,7 +100,7 @@ jobs:
dmapi-build:
name: Build DMAPI
needs: start-ci-run-gate
if: always() && needs.start-ci-run-gate.result == 'success'
if: "!(cancelled() || failure()) && needs.start-ci-run-gate.result == 'success'"
env:
BYOND_MAJOR: 515
BYOND_MINOR: 1592
@@ -158,7 +158,7 @@ jobs:
name: Build Doxygen Site
runs-on: ubuntu-latest
needs: start-ci-run-gate
if: always() && needs.start-ci-run-gate.result == 'success'
if: "!(cancelled() || failure()) && needs.start-ci-run-gate.result == 'success'"
steps:
- name: Checkout (Branch Push)
uses: actions/checkout@v3
@@ -208,7 +208,7 @@ jobs:
name: Build Docker Image
runs-on: ubuntu-latest
needs: start-ci-run-gate
if: always() && needs.start-ci-run-gate.result == 'success'
if: "!(cancelled() || failure()) && needs.start-ci-run-gate.result == 'success'"
steps:
- name: Checkout (Branch Push)
uses: actions/checkout@v3
@@ -226,7 +226,7 @@ jobs:
linux-unit-tests:
name: Linux Tests
needs: start-ci-run-gate
if: always() && needs.start-ci-run-gate.result == 'success'
if: "!(cancelled() || failure()) && needs.start-ci-run-gate.result == 'success'"
strategy:
fail-fast: false
matrix:
@@ -266,7 +266,7 @@ jobs:
windows-unit-tests:
name: Windows Tests
needs: start-ci-run-gate
if: always() && needs.start-ci-run-gate.result == 'success'
if: "!(cancelled() || failure()) && needs.start-ci-run-gate.result == 'success'"
strategy:
fail-fast: false
matrix:
@@ -306,7 +306,7 @@ jobs:
windows-integration-test:
name: Windows Live Tests
needs: dmapi-build
if: always() && needs.dmapi-build.result == 'success'
if: "!(cancelled() || failure()) && needs.dmapi-build.result == 'success'"
env:
TGS_TEST_DATABASE_TYPE: SqlServer
TGS_TEST_DUMP_API_SPEC: yes
@@ -386,7 +386,7 @@ jobs:
linux-integration-tests:
name: Linux Live Tests
needs: dmapi-build
if: always() && needs.dmapi-build.result == 'success'
if: "!(cancelled() || failure()) && needs.dmapi-build.result == 'success'"
services: # We start all dbs here so we can just code the stuff once
postgres:
image: cyberboss/postgres-max-connections # Fork of _/postgres:latest with max_connections=500 becuase GitHub actions service containers have no way to set command lines. Rebuilds with updates.
@@ -538,7 +538,7 @@ jobs:
validate-openapi-spec:
name: OpenAPI Spec Validation
needs: windows-integration-test
if: always() && needs.windows-integration-test.result == 'success'
if: "!(cancelled() || failure()) && needs.windows-integration-test.result == 'success'"
runs-on: ubuntu-latest
steps:
- name: Install Node 12.X
@@ -571,7 +571,7 @@ jobs:
upload-code-coverage:
name: Upload Code Coverage
needs: [linux-unit-tests, linux-integration-tests, windows-unit-tests, windows-integration-test]
if: always() && needs.linux-unit-tests.result == 'success' && needs.linux-integration-tests.result == 'success' && needs.windows-unit-tests.result == 'success' && needs.windows-integration-test.result == 'success'
if: "!(cancelled() || failure()) && needs.linux-unit-tests.result == 'success' && needs.linux-integration-tests.result == 'success' && needs.windows-unit-tests.result == 'success' && needs.windows-integration-test.result == 'success'"
runs-on: ubuntu-latest
steps:
- name: Checkout (Branch Push)
@@ -661,7 +661,7 @@ jobs:
name: Deploy HTTP API
needs: [upload-code-coverage, validate-openapi-spec]
runs-on: windows-latest
if: always() && needs.upload-code-coverage.result == 'success' && needs.validate-openapi-spec.result == 'success' && github.event_name == 'push' && contains(github.event.head_commit.message, '[APIDeploy]')
if: "!(cancelled() || failure()) && needs.upload-code-coverage.result == 'success' && needs.validate-openapi-spec.result == 'success' && github.event_name == 'push' && contains(github.event.head_commit.message, '[APIDeploy]')"
steps:
- name: Checkout (Branch Push)
uses: actions/checkout@v3
@@ -711,7 +711,7 @@ jobs:
name: Deploy DreamMaker API
needs: [upload-code-coverage, validate-openapi-spec]
runs-on: windows-latest
if: always() && needs.upload-code-coverage.result == 'success' && needs.validate-openapi-spec.result == 'success' && github.event_name == 'push' && contains(github.event.head_commit.message, '[DMDeploy]')
if: "!(cancelled() || failure()) && needs.upload-code-coverage.result == 'success' && needs.validate-openapi-spec.result == 'success' && github.event_name == 'push' && contains(github.event.head_commit.message, '[DMDeploy]')"
steps:
- name: Checkout (Branch Push)
uses: actions/checkout@v3
@@ -760,7 +760,7 @@ jobs:
name: Deploy Nuget Packages
needs: [upload-code-coverage, validate-openapi-spec]
runs-on: ubuntu-latest
if: always() && needs.upload-code-coverage.result == 'success' && needs.validate-openapi-spec.result == 'success' && github.event_name == 'push' && contains(github.event.head_commit.message, '[NugetDeploy]')
if: "!(cancelled() || failure()) && needs.upload-code-coverage.result == 'success' && needs.validate-openapi-spec.result == 'success' && github.event_name == 'push' && contains(github.event.head_commit.message, '[NugetDeploy]')"
steps:
- name: Setup dotnet
uses: actions/setup-dotnet@v2
@@ -797,7 +797,7 @@ jobs:
name: Ensure TGS Release is Latest GitHub Release
needs: [deploy-dm, deploy-http]
runs-on: ubuntu-latest
if: always() && (needs.deploy-dm.result == 'success' || needs.deploy-http.result == 'success') && !contains(github.event.head_commit.message, '[TGSDeploy]')
if: "!(cancelled() || failure()) && (needs.deploy-dm.result == 'success' || needs.deploy-http.result == 'success') && !contains(github.event.head_commit.message, '[TGSDeploy]')"
steps:
- name: Setup dotnet
uses: actions/setup-dotnet@v2
@@ -821,7 +821,7 @@ jobs:
name: Deploy TGS
needs: [deploy-dm, deploy-http, upload-code-coverage, validate-openapi-spec]
runs-on: windows-latest
if: always() && (needs.upload-code-coverage.result == 'success' || needs.validate-openapi-spec.result == 'success') && github.event_name == 'push' && github.event.ref == 'refs/heads/master' && contains(github.event.head_commit.message, '[TGSDeploy]')
if: "!(cancelled() || failure()) && (needs.upload-code-coverage.result == 'success' || needs.validate-openapi-spec.result == 'success') && github.event_name == 'push' && github.event.ref == 'refs/heads/master' && contains(github.event.head_commit.message, '[TGSDeploy]')"
steps:
- name: Setup dotnet
uses: actions/setup-dotnet@v2
@@ -944,7 +944,7 @@ jobs:
deploy-docker:
name: Deploy TGS (Docker)
needs: [deploy-tgs]
if: always() && needs.deploy-tgs.result == 'success'
if: "!(cancelled() || failure()) && needs.deploy-tgs.result == 'success'"
runs-on: ubuntu-latest
steps:
- name: Checkout (Branch Push)