From b8025963758be7f99bf96c4d2b9f88536b846df3 Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Sun, 15 Sep 2024 17:29:28 -0400
Subject: [PATCH] Apply a bunch of code suggestions

---
 src/Tgstation.Server.Api/ApiHeaders.cs                  | 2 +-
 src/Tgstation.Server.Host/Controllers/ApiController.cs  | 2 +-
 src/Tgstation.Server.Host/Utils/SwaggerConfiguration.cs | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Tgstation.Server.Api/ApiHeaders.cs b/src/Tgstation.Server.Api/ApiHeaders.cs
index fad13a0330..acc673bf07 100644
--- a/src/Tgstation.Server.Api/ApiHeaders.cs
+++ b/src/Tgstation.Server.Api/ApiHeaders.cs
@@ -76,7 +76,7 @@ namespace Tgstation.Server.Api
 		/// <summary>
 		/// A <see cref="char"/> <see cref="Array"/> containing the ':' <see cref="char"/>.
 		/// </summary>
-		static readonly char[] ColonSeparator = new char[] { ':' };
+		static readonly char[] ColonSeparator = [':'];
 
 		/// <summary>
 		/// The instance <see cref="EntityId.Id"/> being accessed.
diff --git a/src/Tgstation.Server.Host/Controllers/ApiController.cs b/src/Tgstation.Server.Host/Controllers/ApiController.cs
index 3914d69da2..8a86e895b7 100644
--- a/src/Tgstation.Server.Host/Controllers/ApiController.cs
+++ b/src/Tgstation.Server.Host/Controllers/ApiController.cs
@@ -337,7 +337,7 @@ namespace Tgstation.Server.Host.Controllers
 			else
 			{
 				totalResults = paginationResult.Results.Count();
-				pagedResults = queriedResults.ToList();
+				pagedResults = [.. queriedResults];
 			}
 
 			ICollection<TResultModel> finalResults;
diff --git a/src/Tgstation.Server.Host/Utils/SwaggerConfiguration.cs b/src/Tgstation.Server.Host/Utils/SwaggerConfiguration.cs
index dc15d9db68..d415e30ea3 100644
--- a/src/Tgstation.Server.Host/Utils/SwaggerConfiguration.cs
+++ b/src/Tgstation.Server.Host/Utils/SwaggerConfiguration.cs
@@ -270,7 +270,7 @@ namespace Tgstation.Server.Host.Utils
 					.OrderBy(x => x.PutOnly) // Process PUTs last
 					.ToList();
 
-				if (requestOptions.Any() && requestOptions.All(x => x.Presence == FieldPresence.Ignored && !x.PutOnly))
+				if (requestOptions.Count == 0 && requestOptions.All(x => x.Presence == FieldPresence.Ignored && !x.PutOnly))
 					subSchema.ReadOnly = true;
 
 				var subSchemaId = tuple.Item2;
@@ -370,7 +370,7 @@ namespace Tgstation.Server.Host.Utils
 
 				operation.Security = new List<OpenApiSecurityRequirement>
 				{
-					new OpenApiSecurityRequirement
+					new()
 					{
 						{
 							tokenScheme,
@@ -450,7 +450,7 @@ namespace Tgstation.Server.Host.Utils
 
 				operation.Security = new List<OpenApiSecurityRequirement>
 				{
-					new OpenApiSecurityRequirement
+					new()
 					{
 						{
 							passwordScheme,