From b92b93135437bcf7dbbb29adff13eb0fc44bdb67 Mon Sep 17 00:00:00 2001
From: Cyberboss <Cyberboss@users.noreply.github.com>
Date: Mon, 24 Sep 2018 15:47:32 -0400
Subject: [PATCH] Move some magic numbers to consts

---
 .../Components/Watchdog/NetworkPromptReaper.cs   | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/Tgstation.Server.Host/Components/Watchdog/NetworkPromptReaper.cs b/src/Tgstation.Server.Host/Components/Watchdog/NetworkPromptReaper.cs
index e2ed8ac3d7..c8b89ac553 100644
--- a/src/Tgstation.Server.Host/Components/Watchdog/NetworkPromptReaper.cs
+++ b/src/Tgstation.Server.Host/Components/Watchdog/NetworkPromptReaper.cs
@@ -15,6 +15,16 @@ namespace Tgstation.Server.Host.Components.Watchdog
 	/// <inheritdoc />
 	sealed class NetworkPromptReaper : IHostedService, INetworkPromptReaper, IDisposable
 	{
+		/// <summary>
+		/// Number of times to send the button click message. Should be at least 2 or it may fail to focus the window
+		/// </summary>
+		const int SendMessageCount = 5;
+		
+		/// <summary>
+		/// Check for prompts each time this amount of milliseconds pass
+		/// </summary>
+		const int RecheckDelayMs = 250;
+
 		/// <summary>
 		/// The <see cref="ILogger"/> for the <see cref="NetworkPromptReaper"/>
 		/// </summary>
@@ -90,8 +100,7 @@ namespace Tgstation.Server.Host.Components.Watchdog
 			{
 				while(!cancellationToken.IsCancellationRequested)
 				{
-					//check every quarter second
-					await Task.Delay(TimeSpan.FromMilliseconds(250), cancellationToken).ConfigureAwait(false);
+					await Task.Delay(TimeSpan.FromMilliseconds(RecheckDelayMs), cancellationToken).ConfigureAwait(false);
 
 					IntPtr window;
 					int processId;
@@ -128,9 +137,8 @@ namespace Tgstation.Server.Host.Components.Watchdog
 						if (windowText == "Yes")
 						{
 							//smash_button_meme.jpg
-							//yes send it five times for good measure
 							logger.LogTrace("Sending \"Yes\" button clicks...");
-							for (var J = 0; J < 5; ++J)
+							for (var J = 0; J < SendMessageCount; ++J)
 							{
 								const int BM_CLICK = 0x00F5;
 								var result = NativeMethods.SendMessage(I, BM_CLICK, IntPtr.Zero, IntPtr.Zero);