From cafc29b51333b301789b2e8e7bb2e2442669f7a2 Mon Sep 17 00:00:00 2001 From: Dominion Date: Fri, 14 Apr 2023 22:54:23 -0400 Subject: [PATCH] Remove SafeHandle as referencing it does nothing --- src/Tgstation.Server.Host/System/Process.cs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/Tgstation.Server.Host/System/Process.cs b/src/Tgstation.Server.Host/System/Process.cs index 192729e89a..404d96fb36 100644 --- a/src/Tgstation.Server.Host/System/Process.cs +++ b/src/Tgstation.Server.Host/System/Process.cs @@ -42,12 +42,6 @@ namespace Tgstation.Server.Host.System /// readonly CancellationTokenSource readerCts; - /// - /// The . - /// - /// We keep this to prevent .NET from closing the real handle too soon. See https://stackoverflow.com/a/47656845 - readonly SafeProcessHandle safeHandle; - /// /// The resulting in the process' standard output/error text. /// @@ -75,7 +69,6 @@ namespace Tgstation.Server.Host.System this.handle = handle ?? throw new ArgumentNullException(nameof(handle)); // Do this fast because the runtime will bitch if we try to access it after it ends - safeHandle = handle.SafeHandle; Id = handle.Id; this.readerCts = readerCts; @@ -122,7 +115,6 @@ namespace Tgstation.Server.Host.System if (readTask != null) await readTask; - safeHandle.Dispose(); handle.Dispose(); }