From 1ae6f7d8f47613a22179c2e7d23e6505acf7aef1 Mon Sep 17 00:00:00 2001 From: distributivgesetz Date: Fri, 1 Sep 2023 22:46:12 +0200 Subject: [PATCH 1/5] fixes ambiguous inheritdocs --- src/Tgstation.Server.Client/AdministrationClient.cs | 2 +- src/Tgstation.Server.Client/Components/ByondClient.cs | 2 +- src/Tgstation.Server.Client/Components/ChatBotsClient.cs | 2 +- .../Components/ConfigurationClient.cs | 2 +- src/Tgstation.Server.Client/Components/DreamMakerClient.cs | 2 +- .../Components/InstancePermissionSetClient.cs | 2 +- src/Tgstation.Server.Client/Components/JobsClient.cs | 2 +- src/Tgstation.Server.Client/InstanceManagerClient.cs | 2 +- src/Tgstation.Server.Client/UserGroupsClient.cs | 2 +- src/Tgstation.Server.Client/UsersClient.cs | 2 +- .../Components/Byond/ByondExecutableLock.cs | 2 +- src/Tgstation.Server.Host/Components/Chat/ChatManager.cs | 2 +- src/Tgstation.Server.Host/Components/InstanceManager.cs | 2 +- .../Components/Session/SessionController.cs | 2 +- src/Tgstation.Server.Host/Core/ServerUpdater.cs | 2 +- src/Tgstation.Server.Host/IO/Console.cs | 5 ++++- src/Tgstation.Server.Host/Jobs/JobService.cs | 4 ++-- src/Tgstation.Server.Host/Models/ChatBot.cs | 2 +- src/Tgstation.Server.Host/Models/CompileJob.cs | 2 +- src/Tgstation.Server.Host/Models/DreamMakerSettings.cs | 2 +- src/Tgstation.Server.Host/Models/InstancePermissionSet.cs | 2 +- src/Tgstation.Server.Host/Models/Job.cs | 2 +- src/Tgstation.Server.Host/Models/OAuthConnection.cs | 2 +- src/Tgstation.Server.Host/Models/RepositorySettings.cs | 2 +- src/Tgstation.Server.Host/Models/RevisionInformation.cs | 2 +- src/Tgstation.Server.Host/Models/TestMerge.cs | 2 +- src/Tgstation.Server.Host/Models/User.cs | 2 +- src/Tgstation.Server.Host/Models/UserGroup.cs | 4 +++- .../Security/AuthenticationContextFactory.cs | 2 +- src/Tgstation.Server.Host/Security/IdentityCache.cs | 2 +- src/Tgstation.Server.Host/Server.cs | 2 +- .../System/WindowsNetworkPromptReaper.cs | 2 +- 32 files changed, 38 insertions(+), 33 deletions(-) diff --git a/src/Tgstation.Server.Client/AdministrationClient.cs b/src/Tgstation.Server.Client/AdministrationClient.cs index 3f6bb7d661..6f0f262777 100644 --- a/src/Tgstation.Server.Client/AdministrationClient.cs +++ b/src/Tgstation.Server.Client/AdministrationClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client { - /// + /// sealed class AdministrationClient : PaginatedClient, IAdministrationClient { /// diff --git a/src/Tgstation.Server.Client/Components/ByondClient.cs b/src/Tgstation.Server.Client/Components/ByondClient.cs index c167af0665..da8ab369ba 100644 --- a/src/Tgstation.Server.Client/Components/ByondClient.cs +++ b/src/Tgstation.Server.Client/Components/ByondClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class ByondClient : PaginatedClient, IByondClient { /// diff --git a/src/Tgstation.Server.Client/Components/ChatBotsClient.cs b/src/Tgstation.Server.Client/Components/ChatBotsClient.cs index d53b0044ac..5d17582c65 100644 --- a/src/Tgstation.Server.Client/Components/ChatBotsClient.cs +++ b/src/Tgstation.Server.Client/Components/ChatBotsClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class ChatBotsClient : PaginatedClient, IChatBotsClient { /// diff --git a/src/Tgstation.Server.Client/Components/ConfigurationClient.cs b/src/Tgstation.Server.Client/Components/ConfigurationClient.cs index 378811083d..4b77967d46 100644 --- a/src/Tgstation.Server.Client/Components/ConfigurationClient.cs +++ b/src/Tgstation.Server.Client/Components/ConfigurationClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class ConfigurationClient : PaginatedClient, IConfigurationClient { /// diff --git a/src/Tgstation.Server.Client/Components/DreamMakerClient.cs b/src/Tgstation.Server.Client/Components/DreamMakerClient.cs index 11bacc51db..1a54a9ac04 100644 --- a/src/Tgstation.Server.Client/Components/DreamMakerClient.cs +++ b/src/Tgstation.Server.Client/Components/DreamMakerClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class DreamMakerClient : PaginatedClient, IDreamMakerClient { /// diff --git a/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs b/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs index 1403ac073a..6d51578bea 100644 --- a/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs +++ b/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class InstancePermissionSetClient : PaginatedClient, IInstancePermissionSetClient { /// diff --git a/src/Tgstation.Server.Client/Components/JobsClient.cs b/src/Tgstation.Server.Client/Components/JobsClient.cs index c143576873..9c2c3234fc 100644 --- a/src/Tgstation.Server.Client/Components/JobsClient.cs +++ b/src/Tgstation.Server.Client/Components/JobsClient.cs @@ -9,7 +9,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class JobsClient : PaginatedClient, IJobsClient { /// diff --git a/src/Tgstation.Server.Client/InstanceManagerClient.cs b/src/Tgstation.Server.Client/InstanceManagerClient.cs index 96179f0154..2db7851308 100644 --- a/src/Tgstation.Server.Client/InstanceManagerClient.cs +++ b/src/Tgstation.Server.Client/InstanceManagerClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Client.Components; namespace Tgstation.Server.Client { - /// + /// sealed class InstanceManagerClient : PaginatedClient, IInstanceManagerClient { /// diff --git a/src/Tgstation.Server.Client/UserGroupsClient.cs b/src/Tgstation.Server.Client/UserGroupsClient.cs index 449258b119..1fa5598e61 100644 --- a/src/Tgstation.Server.Client/UserGroupsClient.cs +++ b/src/Tgstation.Server.Client/UserGroupsClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client { - /// + /// sealed class UserGroupsClient : PaginatedClient, IUserGroupsClient { /// diff --git a/src/Tgstation.Server.Client/UsersClient.cs b/src/Tgstation.Server.Client/UsersClient.cs index 2a7b6626f7..a1cb96e8f1 100644 --- a/src/Tgstation.Server.Client/UsersClient.cs +++ b/src/Tgstation.Server.Client/UsersClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client { - /// + /// sealed class UsersClient : PaginatedClient, IUsersClient { /// diff --git a/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs b/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs index 01c39925a2..bf306fff9e 100644 --- a/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs +++ b/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components.Byond { - /// + /// sealed class ByondExecutableLock : ReferenceCounter, IByondExecutableLock { /// diff --git a/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs b/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs index 6e9745399e..e93953d3d1 100644 --- a/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs +++ b/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs @@ -20,7 +20,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components.Chat { - /// + /// // TODO: Decomplexify #pragma warning disable CA1506 sealed class ChatManager : IChatManager, IRestartHandler diff --git a/src/Tgstation.Server.Host/Components/InstanceManager.cs b/src/Tgstation.Server.Host/Components/InstanceManager.cs index 6ead6dc1dc..5963518cbc 100644 --- a/src/Tgstation.Server.Host/Components/InstanceManager.cs +++ b/src/Tgstation.Server.Host/Components/InstanceManager.cs @@ -27,7 +27,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components { - /// + /// sealed class InstanceManager : IInstanceManager, IInstanceCoreProvider, diff --git a/src/Tgstation.Server.Host/Components/Session/SessionController.cs b/src/Tgstation.Server.Host/Components/Session/SessionController.cs index f43c46162f..d7c1dee77c 100644 --- a/src/Tgstation.Server.Host/Components/Session/SessionController.cs +++ b/src/Tgstation.Server.Host/Components/Session/SessionController.cs @@ -26,7 +26,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components.Session { - /// + /// sealed class SessionController : Chunker, ISessionController, IBridgeHandler, IChannelSink { /// diff --git a/src/Tgstation.Server.Host/Core/ServerUpdater.cs b/src/Tgstation.Server.Host/Core/ServerUpdater.cs index 570b613b70..55cea66a70 100644 --- a/src/Tgstation.Server.Host/Core/ServerUpdater.cs +++ b/src/Tgstation.Server.Host/Core/ServerUpdater.cs @@ -13,7 +13,7 @@ using Tgstation.Server.Host.Utils.GitHub; namespace Tgstation.Server.Host.Core { - /// + /// sealed class ServerUpdater : IServerUpdater, IServerUpdateExecutor { /// diff --git a/src/Tgstation.Server.Host/IO/Console.cs b/src/Tgstation.Server.Host/IO/Console.cs index 0643ac9cab..450c648af3 100644 --- a/src/Tgstation.Server.Host/IO/Console.cs +++ b/src/Tgstation.Server.Host/IO/Console.cs @@ -7,7 +7,10 @@ using Tgstation.Server.Host.System; namespace Tgstation.Server.Host.IO { - /// + /// + /// Implementation of , + /// uses . + /// sealed class Console : IConsole, IDisposable { /// diff --git a/src/Tgstation.Server.Host/Jobs/JobService.cs b/src/Tgstation.Server.Host/Jobs/JobService.cs index e33851c41a..5273b372c4 100644 --- a/src/Tgstation.Server.Host/Jobs/JobService.cs +++ b/src/Tgstation.Server.Host/Jobs/JobService.cs @@ -16,7 +16,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Jobs { - /// + /// sealed class JobService : IJobService, IDisposable { /// @@ -35,7 +35,7 @@ namespace Tgstation.Server.Host.Jobs readonly ILogger logger; /// - /// of s to running s. + /// of s to running s. /// readonly Dictionary jobs; diff --git a/src/Tgstation.Server.Host/Models/ChatBot.cs b/src/Tgstation.Server.Host/Models/ChatBot.cs index 8bef6104a8..2bfbc2a82c 100644 --- a/src/Tgstation.Server.Host/Models/ChatBot.cs +++ b/src/Tgstation.Server.Host/Models/ChatBot.cs @@ -6,7 +6,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class ChatBot : Api.Models.Internal.ChatBotSettings, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/CompileJob.cs b/src/Tgstation.Server.Host/Models/CompileJob.cs index bb49025ecd..45582fd74b 100644 --- a/src/Tgstation.Server.Host/Models/CompileJob.cs +++ b/src/Tgstation.Server.Host/Models/CompileJob.cs @@ -6,7 +6,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class CompileJob : Api.Models.Internal.CompileJob, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs b/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs index e290fb1a90..4e0225f9cc 100644 --- a/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs +++ b/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class DreamMakerSettings : Api.Models.Internal.DreamMakerSettings, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs b/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs index 4c415e1067..ec36e1d09a 100644 --- a/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs +++ b/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class InstancePermissionSet : Api.Models.Internal.InstancePermissionSet, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/Job.cs b/src/Tgstation.Server.Host/Models/Job.cs index efa3268250..e78498609e 100644 --- a/src/Tgstation.Server.Host/Models/Job.cs +++ b/src/Tgstation.Server.Host/Models/Job.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// #pragma warning disable CA1724 // naming conflict with gitlab package public sealed class Job : Api.Models.Internal.Job, IApiTransformable #pragma warning restore CA1724 diff --git a/src/Tgstation.Server.Host/Models/OAuthConnection.cs b/src/Tgstation.Server.Host/Models/OAuthConnection.cs index 7d8429adf6..6a31c0b78b 100644 --- a/src/Tgstation.Server.Host/Models/OAuthConnection.cs +++ b/src/Tgstation.Server.Host/Models/OAuthConnection.cs @@ -1,6 +1,6 @@ namespace Tgstation.Server.Host.Models { - /// + /// public sealed class OAuthConnection : Api.Models.OAuthConnection, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/RepositorySettings.cs b/src/Tgstation.Server.Host/Models/RepositorySettings.cs index 7be6e76108..9ff57c59f2 100644 --- a/src/Tgstation.Server.Host/Models/RepositorySettings.cs +++ b/src/Tgstation.Server.Host/Models/RepositorySettings.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class RepositorySettings : Api.Models.Internal.RepositorySettings, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/RevisionInformation.cs b/src/Tgstation.Server.Host/Models/RevisionInformation.cs index 62b1017dd5..53f079ad01 100644 --- a/src/Tgstation.Server.Host/Models/RevisionInformation.cs +++ b/src/Tgstation.Server.Host/Models/RevisionInformation.cs @@ -4,7 +4,7 @@ using System.Linq; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class RevisionInformation : Api.Models.Internal.RevisionInformation, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/TestMerge.cs b/src/Tgstation.Server.Host/Models/TestMerge.cs index 141637ca22..b9921fa0df 100644 --- a/src/Tgstation.Server.Host/Models/TestMerge.cs +++ b/src/Tgstation.Server.Host/Models/TestMerge.cs @@ -3,7 +3,7 @@ using System.ComponentModel.DataAnnotations; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class TestMerge : Api.Models.Internal.TestMergeApiBase, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/User.cs b/src/Tgstation.Server.Host/Models/User.cs index 06816aeaa0..438d9379fb 100644 --- a/src/Tgstation.Server.Host/Models/User.cs +++ b/src/Tgstation.Server.Host/Models/User.cs @@ -8,7 +8,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class User : Api.Models.Internal.UserModelBase, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/UserGroup.cs b/src/Tgstation.Server.Host/Models/UserGroup.cs index cce61e9229..3114f47cd0 100644 --- a/src/Tgstation.Server.Host/Models/UserGroup.cs +++ b/src/Tgstation.Server.Host/Models/UserGroup.cs @@ -7,7 +7,9 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// + /// Represents a group of s. + /// public sealed class UserGroup : NamedEntity, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs b/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs index 24ab9707ea..fbc6e487a6 100644 --- a/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs +++ b/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs @@ -13,7 +13,7 @@ using Tgstation.Server.Host.Models; namespace Tgstation.Server.Host.Security { - /// + /// sealed class AuthenticationContextFactory : IAuthenticationContextFactory, IDisposable { /// diff --git a/src/Tgstation.Server.Host/Security/IdentityCache.cs b/src/Tgstation.Server.Host/Security/IdentityCache.cs index 8e59a0210b..e45e1350d1 100644 --- a/src/Tgstation.Server.Host/Security/IdentityCache.cs +++ b/src/Tgstation.Server.Host/Security/IdentityCache.cs @@ -9,7 +9,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Security { - /// + /// sealed class IdentityCache : IIdentityCache, IDisposable { /// diff --git a/src/Tgstation.Server.Host/Server.cs b/src/Tgstation.Server.Host/Server.cs index b76891e3ec..f5c149ab3f 100644 --- a/src/Tgstation.Server.Host/Server.cs +++ b/src/Tgstation.Server.Host/Server.cs @@ -15,7 +15,7 @@ using Tgstation.Server.Host.Core; namespace Tgstation.Server.Host { - /// + /// sealed class Server : IServer, IServerControl { /// diff --git a/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs b/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs index 6578457672..296819fd7e 100644 --- a/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs +++ b/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs @@ -15,7 +15,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.System { - /// + /// sealed class WindowsNetworkPromptReaper : BackgroundService, INetworkPromptReaper { /// From 764e27fd833edb0d07658970c875332abc0407fd Mon Sep 17 00:00:00 2001 From: distributivgesetz Date: Fri, 1 Sep 2023 22:58:31 +0200 Subject: [PATCH 2/5] bwuh --- src/Tgstation.Server.Host/Jobs/JobService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tgstation.Server.Host/Jobs/JobService.cs b/src/Tgstation.Server.Host/Jobs/JobService.cs index 5273b372c4..8d2fca8489 100644 --- a/src/Tgstation.Server.Host/Jobs/JobService.cs +++ b/src/Tgstation.Server.Host/Jobs/JobService.cs @@ -35,7 +35,7 @@ namespace Tgstation.Server.Host.Jobs readonly ILogger logger; /// - /// of s to running s. + /// of s to running s. /// readonly Dictionary jobs; From 18bc8b64d58df20ff898e7f9f0a2a429da859cab Mon Sep 17 00:00:00 2001 From: distributivgesetz Date: Sat, 2 Sep 2023 11:41:44 +0200 Subject: [PATCH 3/5] simplify names --- src/Tgstation.Server.Client/AdministrationClient.cs | 2 +- src/Tgstation.Server.Client/Components/ByondClient.cs | 2 +- src/Tgstation.Server.Client/Components/ChatBotsClient.cs | 2 +- src/Tgstation.Server.Client/Components/ConfigurationClient.cs | 2 +- src/Tgstation.Server.Client/Components/DreamMakerClient.cs | 2 +- .../Components/InstancePermissionSetClient.cs | 2 +- src/Tgstation.Server.Client/Components/JobsClient.cs | 2 +- src/Tgstation.Server.Client/InstanceManagerClient.cs | 2 +- src/Tgstation.Server.Client/UserGroupsClient.cs | 2 +- src/Tgstation.Server.Client/UsersClient.cs | 2 +- .../Components/Byond/ByondExecutableLock.cs | 2 +- src/Tgstation.Server.Host/Components/Chat/ChatManager.cs | 2 +- src/Tgstation.Server.Host/Components/InstanceManager.cs | 2 +- .../Components/Session/SessionController.cs | 2 +- src/Tgstation.Server.Host/Core/ServerUpdater.cs | 2 +- src/Tgstation.Server.Host/Jobs/JobService.cs | 2 +- src/Tgstation.Server.Host/Models/ChatBot.cs | 2 +- src/Tgstation.Server.Host/Models/CompileJob.cs | 2 +- src/Tgstation.Server.Host/Models/DreamMakerSettings.cs | 2 +- src/Tgstation.Server.Host/Models/InstancePermissionSet.cs | 2 +- src/Tgstation.Server.Host/Models/Job.cs | 2 +- src/Tgstation.Server.Host/Models/OAuthConnection.cs | 2 +- src/Tgstation.Server.Host/Models/RepositorySettings.cs | 2 +- src/Tgstation.Server.Host/Models/RevisionInformation.cs | 2 +- src/Tgstation.Server.Host/Models/TestMerge.cs | 2 +- src/Tgstation.Server.Host/Models/User.cs | 2 +- .../Security/AuthenticationContextFactory.cs | 2 +- src/Tgstation.Server.Host/Security/IdentityCache.cs | 2 +- src/Tgstation.Server.Host/Server.cs | 2 +- src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs | 2 +- 30 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/Tgstation.Server.Client/AdministrationClient.cs b/src/Tgstation.Server.Client/AdministrationClient.cs index 6f0f262777..1f626a8fbd 100644 --- a/src/Tgstation.Server.Client/AdministrationClient.cs +++ b/src/Tgstation.Server.Client/AdministrationClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client { - /// + /// sealed class AdministrationClient : PaginatedClient, IAdministrationClient { /// diff --git a/src/Tgstation.Server.Client/Components/ByondClient.cs b/src/Tgstation.Server.Client/Components/ByondClient.cs index da8ab369ba..2f418e7d0c 100644 --- a/src/Tgstation.Server.Client/Components/ByondClient.cs +++ b/src/Tgstation.Server.Client/Components/ByondClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class ByondClient : PaginatedClient, IByondClient { /// diff --git a/src/Tgstation.Server.Client/Components/ChatBotsClient.cs b/src/Tgstation.Server.Client/Components/ChatBotsClient.cs index 5d17582c65..b070123513 100644 --- a/src/Tgstation.Server.Client/Components/ChatBotsClient.cs +++ b/src/Tgstation.Server.Client/Components/ChatBotsClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class ChatBotsClient : PaginatedClient, IChatBotsClient { /// diff --git a/src/Tgstation.Server.Client/Components/ConfigurationClient.cs b/src/Tgstation.Server.Client/Components/ConfigurationClient.cs index 4b77967d46..694c40b701 100644 --- a/src/Tgstation.Server.Client/Components/ConfigurationClient.cs +++ b/src/Tgstation.Server.Client/Components/ConfigurationClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class ConfigurationClient : PaginatedClient, IConfigurationClient { /// diff --git a/src/Tgstation.Server.Client/Components/DreamMakerClient.cs b/src/Tgstation.Server.Client/Components/DreamMakerClient.cs index 1a54a9ac04..867d792870 100644 --- a/src/Tgstation.Server.Client/Components/DreamMakerClient.cs +++ b/src/Tgstation.Server.Client/Components/DreamMakerClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class DreamMakerClient : PaginatedClient, IDreamMakerClient { /// diff --git a/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs b/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs index 6d51578bea..957c7b71fa 100644 --- a/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs +++ b/src/Tgstation.Server.Client/Components/InstancePermissionSetClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class InstancePermissionSetClient : PaginatedClient, IInstancePermissionSetClient { /// diff --git a/src/Tgstation.Server.Client/Components/JobsClient.cs b/src/Tgstation.Server.Client/Components/JobsClient.cs index 9c2c3234fc..fcdc4ef76e 100644 --- a/src/Tgstation.Server.Client/Components/JobsClient.cs +++ b/src/Tgstation.Server.Client/Components/JobsClient.cs @@ -9,7 +9,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client.Components { - /// + /// sealed class JobsClient : PaginatedClient, IJobsClient { /// diff --git a/src/Tgstation.Server.Client/InstanceManagerClient.cs b/src/Tgstation.Server.Client/InstanceManagerClient.cs index 2db7851308..f6bf2bf4d5 100644 --- a/src/Tgstation.Server.Client/InstanceManagerClient.cs +++ b/src/Tgstation.Server.Client/InstanceManagerClient.cs @@ -11,7 +11,7 @@ using Tgstation.Server.Client.Components; namespace Tgstation.Server.Client { - /// + /// sealed class InstanceManagerClient : PaginatedClient, IInstanceManagerClient { /// diff --git a/src/Tgstation.Server.Client/UserGroupsClient.cs b/src/Tgstation.Server.Client/UserGroupsClient.cs index 1fa5598e61..53390cd3c2 100644 --- a/src/Tgstation.Server.Client/UserGroupsClient.cs +++ b/src/Tgstation.Server.Client/UserGroupsClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client { - /// + /// sealed class UserGroupsClient : PaginatedClient, IUserGroupsClient { /// diff --git a/src/Tgstation.Server.Client/UsersClient.cs b/src/Tgstation.Server.Client/UsersClient.cs index a1cb96e8f1..ac8aed9ff2 100644 --- a/src/Tgstation.Server.Client/UsersClient.cs +++ b/src/Tgstation.Server.Client/UsersClient.cs @@ -10,7 +10,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Client { - /// + /// sealed class UsersClient : PaginatedClient, IUsersClient { /// diff --git a/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs b/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs index bf306fff9e..334b3469ea 100644 --- a/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs +++ b/src/Tgstation.Server.Host/Components/Byond/ByondExecutableLock.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components.Byond { - /// + /// sealed class ByondExecutableLock : ReferenceCounter, IByondExecutableLock { /// diff --git a/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs b/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs index e93953d3d1..85c5c87e92 100644 --- a/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs +++ b/src/Tgstation.Server.Host/Components/Chat/ChatManager.cs @@ -20,7 +20,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components.Chat { - /// + /// // TODO: Decomplexify #pragma warning disable CA1506 sealed class ChatManager : IChatManager, IRestartHandler diff --git a/src/Tgstation.Server.Host/Components/InstanceManager.cs b/src/Tgstation.Server.Host/Components/InstanceManager.cs index 5963518cbc..2fa96242cd 100644 --- a/src/Tgstation.Server.Host/Components/InstanceManager.cs +++ b/src/Tgstation.Server.Host/Components/InstanceManager.cs @@ -27,7 +27,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components { - /// + /// sealed class InstanceManager : IInstanceManager, IInstanceCoreProvider, diff --git a/src/Tgstation.Server.Host/Components/Session/SessionController.cs b/src/Tgstation.Server.Host/Components/Session/SessionController.cs index d7c1dee77c..2da8c03b58 100644 --- a/src/Tgstation.Server.Host/Components/Session/SessionController.cs +++ b/src/Tgstation.Server.Host/Components/Session/SessionController.cs @@ -26,7 +26,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Components.Session { - /// + /// sealed class SessionController : Chunker, ISessionController, IBridgeHandler, IChannelSink { /// diff --git a/src/Tgstation.Server.Host/Core/ServerUpdater.cs b/src/Tgstation.Server.Host/Core/ServerUpdater.cs index 55cea66a70..77d2ea3da4 100644 --- a/src/Tgstation.Server.Host/Core/ServerUpdater.cs +++ b/src/Tgstation.Server.Host/Core/ServerUpdater.cs @@ -13,7 +13,7 @@ using Tgstation.Server.Host.Utils.GitHub; namespace Tgstation.Server.Host.Core { - /// + /// sealed class ServerUpdater : IServerUpdater, IServerUpdateExecutor { /// diff --git a/src/Tgstation.Server.Host/Jobs/JobService.cs b/src/Tgstation.Server.Host/Jobs/JobService.cs index 8d2fca8489..b4baca7533 100644 --- a/src/Tgstation.Server.Host/Jobs/JobService.cs +++ b/src/Tgstation.Server.Host/Jobs/JobService.cs @@ -16,7 +16,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Jobs { - /// + /// sealed class JobService : IJobService, IDisposable { /// diff --git a/src/Tgstation.Server.Host/Models/ChatBot.cs b/src/Tgstation.Server.Host/Models/ChatBot.cs index 2bfbc2a82c..f98f4a43c3 100644 --- a/src/Tgstation.Server.Host/Models/ChatBot.cs +++ b/src/Tgstation.Server.Host/Models/ChatBot.cs @@ -6,7 +6,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class ChatBot : Api.Models.Internal.ChatBotSettings, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/CompileJob.cs b/src/Tgstation.Server.Host/Models/CompileJob.cs index 45582fd74b..9ddde1344c 100644 --- a/src/Tgstation.Server.Host/Models/CompileJob.cs +++ b/src/Tgstation.Server.Host/Models/CompileJob.cs @@ -6,7 +6,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class CompileJob : Api.Models.Internal.CompileJob, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs b/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs index 4e0225f9cc..3a55c433d0 100644 --- a/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs +++ b/src/Tgstation.Server.Host/Models/DreamMakerSettings.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class DreamMakerSettings : Api.Models.Internal.DreamMakerSettings, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs b/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs index ec36e1d09a..00509126f0 100644 --- a/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs +++ b/src/Tgstation.Server.Host/Models/InstancePermissionSet.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class InstancePermissionSet : Api.Models.Internal.InstancePermissionSet, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/Job.cs b/src/Tgstation.Server.Host/Models/Job.cs index e78498609e..1a8fca57c0 100644 --- a/src/Tgstation.Server.Host/Models/Job.cs +++ b/src/Tgstation.Server.Host/Models/Job.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// #pragma warning disable CA1724 // naming conflict with gitlab package public sealed class Job : Api.Models.Internal.Job, IApiTransformable #pragma warning restore CA1724 diff --git a/src/Tgstation.Server.Host/Models/OAuthConnection.cs b/src/Tgstation.Server.Host/Models/OAuthConnection.cs index 6a31c0b78b..e72476c134 100644 --- a/src/Tgstation.Server.Host/Models/OAuthConnection.cs +++ b/src/Tgstation.Server.Host/Models/OAuthConnection.cs @@ -1,6 +1,6 @@ namespace Tgstation.Server.Host.Models { - /// + /// public sealed class OAuthConnection : Api.Models.OAuthConnection, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/RepositorySettings.cs b/src/Tgstation.Server.Host/Models/RepositorySettings.cs index 9ff57c59f2..b62f235d5e 100644 --- a/src/Tgstation.Server.Host/Models/RepositorySettings.cs +++ b/src/Tgstation.Server.Host/Models/RepositorySettings.cs @@ -4,7 +4,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class RepositorySettings : Api.Models.Internal.RepositorySettings, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/RevisionInformation.cs b/src/Tgstation.Server.Host/Models/RevisionInformation.cs index 53f079ad01..290e118ae9 100644 --- a/src/Tgstation.Server.Host/Models/RevisionInformation.cs +++ b/src/Tgstation.Server.Host/Models/RevisionInformation.cs @@ -4,7 +4,7 @@ using System.Linq; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class RevisionInformation : Api.Models.Internal.RevisionInformation, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/TestMerge.cs b/src/Tgstation.Server.Host/Models/TestMerge.cs index b9921fa0df..43d7f35b28 100644 --- a/src/Tgstation.Server.Host/Models/TestMerge.cs +++ b/src/Tgstation.Server.Host/Models/TestMerge.cs @@ -3,7 +3,7 @@ using System.ComponentModel.DataAnnotations; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class TestMerge : Api.Models.Internal.TestMergeApiBase, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Models/User.cs b/src/Tgstation.Server.Host/Models/User.cs index 438d9379fb..0d275c7d18 100644 --- a/src/Tgstation.Server.Host/Models/User.cs +++ b/src/Tgstation.Server.Host/Models/User.cs @@ -8,7 +8,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { - /// + /// public sealed class User : Api.Models.Internal.UserModelBase, IApiTransformable { /// diff --git a/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs b/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs index fbc6e487a6..51a51ad85b 100644 --- a/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs +++ b/src/Tgstation.Server.Host/Security/AuthenticationContextFactory.cs @@ -13,7 +13,7 @@ using Tgstation.Server.Host.Models; namespace Tgstation.Server.Host.Security { - /// + /// sealed class AuthenticationContextFactory : IAuthenticationContextFactory, IDisposable { /// diff --git a/src/Tgstation.Server.Host/Security/IdentityCache.cs b/src/Tgstation.Server.Host/Security/IdentityCache.cs index e45e1350d1..0db031aba2 100644 --- a/src/Tgstation.Server.Host/Security/IdentityCache.cs +++ b/src/Tgstation.Server.Host/Security/IdentityCache.cs @@ -9,7 +9,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.Security { - /// + /// sealed class IdentityCache : IIdentityCache, IDisposable { /// diff --git a/src/Tgstation.Server.Host/Server.cs b/src/Tgstation.Server.Host/Server.cs index f5c149ab3f..2fc60efaa6 100644 --- a/src/Tgstation.Server.Host/Server.cs +++ b/src/Tgstation.Server.Host/Server.cs @@ -15,7 +15,7 @@ using Tgstation.Server.Host.Core; namespace Tgstation.Server.Host { - /// + /// sealed class Server : IServer, IServerControl { /// diff --git a/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs b/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs index 296819fd7e..c30f107ac3 100644 --- a/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs +++ b/src/Tgstation.Server.Host/System/WindowsNetworkPromptReaper.cs @@ -15,7 +15,7 @@ using Tgstation.Server.Host.Utils; namespace Tgstation.Server.Host.System { - /// + /// sealed class WindowsNetworkPromptReaper : BackgroundService, INetworkPromptReaper { /// From 2ec2433696ad79efd49e970381b7b7deeda4454b Mon Sep 17 00:00:00 2001 From: distributivgesetz Date: Sat, 2 Sep 2023 11:43:48 +0200 Subject: [PATCH 4/5] tab character snuck in here --- src/Tgstation.Server.Host/Models/UserGroup.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tgstation.Server.Host/Models/UserGroup.cs b/src/Tgstation.Server.Host/Models/UserGroup.cs index 3114f47cd0..d914fe872b 100644 --- a/src/Tgstation.Server.Host/Models/UserGroup.cs +++ b/src/Tgstation.Server.Host/Models/UserGroup.cs @@ -8,7 +8,7 @@ using Tgstation.Server.Api.Models.Response; namespace Tgstation.Server.Host.Models { /// - /// Represents a group of s. + /// Represents a group of s. /// public sealed class UserGroup : NamedEntity, IApiTransformable { From 751071dd11fc23d2d4a12b4265ce83bae33152ec Mon Sep 17 00:00:00 2001 From: distributivgesetz Date: Sat, 2 Sep 2023 20:27:41 +0200 Subject: [PATCH 5/5] missed a spot --- src/Tgstation.Server.Host/IO/Console.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Tgstation.Server.Host/IO/Console.cs b/src/Tgstation.Server.Host/IO/Console.cs index 450c648af3..fdf06eea52 100644 --- a/src/Tgstation.Server.Host/IO/Console.cs +++ b/src/Tgstation.Server.Host/IO/Console.cs @@ -8,8 +8,7 @@ using Tgstation.Server.Host.System; namespace Tgstation.Server.Host.IO { /// - /// Implementation of , - /// uses . + /// Implementation of , uses . /// sealed class Console : IConsole, IDisposable {