From db0db22f2bb74250cb77e7ea8355ac4adce9f0f8 Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Sat, 16 Aug 2025 13:45:19 -0400
Subject: [PATCH] Remove unused OAuth/Oidc connections data loaders

---
 .../Authority/UserAuthority.cs                | 76 -------------------
 1 file changed, 76 deletions(-)

diff --git a/src/Tgstation.Server.Host/Authority/UserAuthority.cs b/src/Tgstation.Server.Host/Authority/UserAuthority.cs
index 59769f696f..4d404c7a3c 100644
--- a/src/Tgstation.Server.Host/Authority/UserAuthority.cs
+++ b/src/Tgstation.Server.Host/Authority/UserAuthority.cs
@@ -39,16 +39,6 @@ namespace Tgstation.Server.Host.Authority
 		/// </summary>
 		readonly IUsersDataLoader usersDataLoader;
 
-		/// <summary>
-		/// The <see cref="IOAuthConnectionsDataLoader"/> for the <see cref="UserAuthority"/>.
-		/// </summary>
-		readonly IOAuthConnectionsDataLoader oAuthConnectionsDataLoader;
-
-		/// <summary>
-		/// The <see cref="IOidcConnectionsDataLoader"/> for the <see cref="UserAuthority"/>.
-		/// </summary>
-		readonly IOidcConnectionsDataLoader oidcConnectionsDataLoader;
-
 		/// <summary>
 		/// The <see cref="ISystemIdentityFactory"/> for the <see cref="UserAuthority"/>.
 		/// </summary>
@@ -111,66 +101,6 @@ namespace Tgstation.Server.Host.Authority
 				.ToDictionaryAsync(user => user.Id!.Value, cancellationToken);
 		}
 
-		/// <summary>
-		/// Implements the <see cref="oAuthConnectionsDataLoader"/>.
-		/// </summary>
-		/// <param name="userIds">The <see cref="IReadOnlyCollection{T}"/> of <see cref="User"/> <see cref="EntityId.Id"/>s to load the OAuthConnections for.</param>
-		/// <param name="databaseContext">The <see cref="IDatabaseContext"/> to load from.</param>
-		/// <param name="cancellationToken">The <see cref="CancellationToken"/> for the operation.</param>
-		/// <returns>A <see cref="ValueTask{TResult}"/> resulting in a <see cref="Dictionary{TKey, TValue}"/> of the requested <see cref="User"/>s.</returns>
-		[DataLoader]
-		public static async ValueTask<ILookup<long, GraphQL.Types.OAuth.OAuthConnection>> GetOAuthConnections(
-			IReadOnlyList<long> userIds,
-			IDatabaseContext databaseContext,
-			CancellationToken cancellationToken)
-		{
-			ArgumentNullException.ThrowIfNull(userIds);
-			ArgumentNullException.ThrowIfNull(databaseContext);
-
-			var list = await databaseContext
-				.OAuthConnections
-				.Where(x => userIds.Contains(x.User!.Id!.Value))
-				.ToListAsync(cancellationToken);
-
-			return list.ToLookup(
-				oAuthConnection => oAuthConnection.UserId,
-				x => new GraphQL.Types.OAuth.OAuthConnection
-				{
-					ExternalUserId = x.ExternalUserId!,
-					Provider = x.Provider,
-				});
-		}
-
-		/// <summary>
-		/// Implements the <see cref="oidcConnectionsDataLoader"/>.
-		/// </summary>
-		/// <param name="userIds">The <see cref="IReadOnlyCollection{T}"/> of <see cref="User"/> <see cref="EntityId.Id"/>s to load the OidcConnections for.</param>
-		/// <param name="databaseContext">The <see cref="IDatabaseContext"/> to load from.</param>
-		/// <param name="cancellationToken">The <see cref="CancellationToken"/> for the operation.</param>
-		/// <returns>A <see cref="ValueTask{TResult}"/> resulting in a <see cref="Dictionary{TKey, TValue}"/> of the requested <see cref="User"/>s.</returns>
-		[DataLoader]
-		public static async ValueTask<ILookup<long, GraphQL.Types.OAuth.OidcConnection>> GetOidcConnections(
-			IReadOnlyList<long> userIds,
-			IDatabaseContext databaseContext,
-			CancellationToken cancellationToken)
-		{
-			ArgumentNullException.ThrowIfNull(userIds);
-			ArgumentNullException.ThrowIfNull(databaseContext);
-
-			var list = await databaseContext
-				.OidcConnections
-				.Where(x => userIds.Contains(x.User!.Id!.Value))
-				.ToListAsync(cancellationToken);
-
-			return list.ToLookup(
-				oidcConnection => oidcConnection.UserId,
-				x => new GraphQL.Types.OAuth.OidcConnection
-				{
-					ExternalUserId = x.ExternalUserId!,
-					SchemeKey = x.SchemeKey!,
-				});
-		}
-
 		/// <summary>
 		/// Check if a given <paramref name="model"/> has a valid <see cref="UserName.Name"/> specified.
 		/// </summary>
@@ -195,8 +125,6 @@ namespace Tgstation.Server.Host.Authority
 		/// <param name="databaseContext">The <see cref="IDatabaseContext"/> to use.</param>
 		/// <param name="logger">The <see cref="ILogger"/> to use.</param>
 		/// <param name="usersDataLoader">The value of <see cref="usersDataLoader"/>.</param>
-		/// <param name="oAuthConnectionsDataLoader">The value of <see cref="oAuthConnectionsDataLoader"/>.</param>
-		/// <param name="oidcConnectionsDataLoader">The value of <see cref="oidcConnectionsDataLoader"/>.</param>
 		/// <param name="systemIdentityFactory">The value of <see cref="systemIdentityFactory"/>.</param>
 		/// <param name="permissionsUpdateNotifyee">The value of <see cref="permissionsUpdateNotifyee"/>.</param>
 		/// <param name="cryptographySuite">The value of <see cref="cryptographySuite"/>.</param>
@@ -209,8 +137,6 @@ namespace Tgstation.Server.Host.Authority
 			IDatabaseContext databaseContext,
 			ILogger<UserAuthority> logger,
 			IUsersDataLoader usersDataLoader,
-			IOAuthConnectionsDataLoader oAuthConnectionsDataLoader,
-			IOidcConnectionsDataLoader oidcConnectionsDataLoader,
 			ISystemIdentityFactory systemIdentityFactory,
 			IPermissionsUpdateNotifyee permissionsUpdateNotifyee,
 			ICryptographySuite cryptographySuite,
@@ -224,8 +150,6 @@ namespace Tgstation.Server.Host.Authority
 				  logger)
 		{
 			this.usersDataLoader = usersDataLoader ?? throw new ArgumentNullException(nameof(usersDataLoader));
-			this.oAuthConnectionsDataLoader = oAuthConnectionsDataLoader ?? throw new ArgumentNullException(nameof(oAuthConnectionsDataLoader));
-			this.oidcConnectionsDataLoader = oidcConnectionsDataLoader ?? throw new ArgumentNullException(nameof(oidcConnectionsDataLoader));
 			this.systemIdentityFactory = systemIdentityFactory ?? throw new ArgumentNullException(nameof(systemIdentityFactory));
 			this.permissionsUpdateNotifyee = permissionsUpdateNotifyee ?? throw new ArgumentNullException(nameof(permissionsUpdateNotifyee));
 			this.cryptographySuite = cryptographySuite ?? throw new ArgumentNullException(nameof(cryptographySuite));