From e58083e6bc5e819e30b4a393c2cac38e5b06d155 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Sun, 14 Mar 2021 17:15:21 -0400 Subject: [PATCH] Fix for targetCommitSha not being nullable on request --- src/Tgstation.Server.Host/Core/SwaggerConfiguration.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Tgstation.Server.Host/Core/SwaggerConfiguration.cs b/src/Tgstation.Server.Host/Core/SwaggerConfiguration.cs index 1effb9b96a..9d5c1c8c89 100644 --- a/src/Tgstation.Server.Host/Core/SwaggerConfiguration.cs +++ b/src/Tgstation.Server.Host/Core/SwaggerConfiguration.cs @@ -515,7 +515,9 @@ namespace Tgstation.Server.Host.Core } else if (responsePresence == FieldPresence.Required && requestOptions.All(x => x.Presence == FieldPresence.Required && !x.PutOnly)) - subSchema.Nullable = false; + // special tactics + subSchema.Nullable = subSchemaId.Equals(nameof(TestMergeParameters.TargetCommitSha), StringComparison.OrdinalIgnoreCase) + && rootSchemaId == nameof(TestMergeParameters); // otherwise, we have to assume it's a shared schema // use what Swagger thinks the nullability is by default