From f2d70f7aa2af448c1cfbaa3caa595fb0e6ee821d Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Tue, 4 Jul 2023 17:56:28 -0400
Subject: [PATCH] Remove unnecessary `SessionConfiguration` from
 WindowByondInstaller`

---
 .../Components/Byond/WindowsByondInstaller.cs             | 8 --------
 tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs   | 1 -
 tests/Tgstation.Server.Tests/TestVersions.cs              | 2 --
 3 files changed, 11 deletions(-)

diff --git a/src/Tgstation.Server.Host/Components/Byond/WindowsByondInstaller.cs b/src/Tgstation.Server.Host/Components/Byond/WindowsByondInstaller.cs
index ce23a737bc..16aa0bafbf 100644
--- a/src/Tgstation.Server.Host/Components/Byond/WindowsByondInstaller.cs
+++ b/src/Tgstation.Server.Host/Components/Byond/WindowsByondInstaller.cs
@@ -70,11 +70,6 @@ namespace Tgstation.Server.Host.Components.Byond
 		/// </summary>
 		readonly GeneralConfiguration generalConfiguration;
 
-		/// <summary>
-		/// The <see cref="SessionConfiguration"/> for the <see cref="WindowsByondInstaller"/>.
-		/// </summary>
-		readonly SessionConfiguration sessionConfiguration;
-
 		/// <summary>
 		/// The <see cref="SemaphoreSlim"/> for the <see cref="WindowsByondInstaller"/>.
 		/// </summary>
@@ -90,7 +85,6 @@ namespace Tgstation.Server.Host.Components.Byond
 		/// </summary>
 		/// <param name="processExecutor">The value of <see cref="processExecutor"/>.</param>
 		/// <param name="generalConfigurationOptions">The <see cref="IOptions{TOptions}"/> containing the value of <see cref="generalConfiguration"/>.</param>
-		/// <param name="sessionConfigurationOptions">The <see cref="IOptions{TOptions}"/> containing the value of <see cref="sessionConfiguration"/>.</param>
 		/// <param name="ioManager">The <see cref="IIOManager"/> for the <see cref="ByondInstallerBase"/>.</param>
 		/// <param name="fileDownloader">The <see cref="IFileDownloader"/> for the <see cref="ByondInstallerBase"/>.</param>
 		/// <param name="logger">The <see cref="ILogger"/> for the <see cref="ByondInstallerBase"/>.</param>
@@ -99,13 +93,11 @@ namespace Tgstation.Server.Host.Components.Byond
 			IIOManager ioManager,
 			IFileDownloader fileDownloader,
 			IOptions<GeneralConfiguration> generalConfigurationOptions,
-			IOptions<SessionConfiguration> sessionConfigurationOptions,
 			ILogger<WindowsByondInstaller> logger)
 			: base(ioManager, fileDownloader, logger)
 		{
 			this.processExecutor = processExecutor ?? throw new ArgumentNullException(nameof(processExecutor));
 			generalConfiguration = generalConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(generalConfigurationOptions));
-			sessionConfiguration = sessionConfigurationOptions?.Value ?? throw new ArgumentNullException(nameof(sessionConfigurationOptions));
 
 			var documentsDirectory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
 			if (String.IsNullOrWhiteSpace(documentsDirectory))
diff --git a/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs b/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs
index 9230aaa86c..a190994e72 100644
--- a/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs
+++ b/tests/Tgstation.Server.Tests/Live/Instance/ByondTest.cs
@@ -169,7 +169,6 @@ namespace Tgstation.Server.Tests.Live.Instance
 					Mock.Of<IIOManager>(),
 					fileDownloader,
 					generalConfigOptionsMock.Object,
-					sessionConfigOptionsMock.Object,
 					Mock.Of<ILogger<WindowsByondInstaller>>())
 				: new PosixByondInstaller(
 					Mock.Of<IPostWriteHandler>(),
diff --git a/tests/Tgstation.Server.Tests/TestVersions.cs b/tests/Tgstation.Server.Tests/TestVersions.cs
index c5d29f21f7..c427b04fb2 100644
--- a/tests/Tgstation.Server.Tests/TestVersions.cs
+++ b/tests/Tgstation.Server.Tests/TestVersions.cs
@@ -115,7 +115,6 @@ namespace Tgstation.Server.Tests
 				Mock.Of<IIOManager>(),
 				new CachingFileDownloader(Mock.Of<ILogger<CachingFileDownloader>>()),
 				mockGeneralConfigurationOptions.Object,
-				mockSessionConfigurationOptions.Object,
 				Mock.Of<ILogger<WindowsByondInstaller>>());
 
 			const string ArchiveEntryPath = "byond/bin/dd.exe";
@@ -170,7 +169,6 @@ namespace Tgstation.Server.Tests
 					Mock.Of<IIOManager>(),
 					fileDownloader,
 					mockGeneralConfigurationOptions.Object,
-					mockSessionConfigurationOptions.Object,
 					loggerFactory.CreateLogger<WindowsByondInstaller>())
 				: new PosixByondInstaller(
 					Mock.Of<IPostWriteHandler>(),