diff --git a/build/Version.props b/build/Version.props
index f3102f5c76..fbd5c5c101 100644
--- a/build/Version.props
+++ b/build/Version.props
@@ -3,7 +3,7 @@
- 5.12.6
+ 5.12.7
4.6.0
9.10.2
6.0.0
diff --git a/src/Tgstation.Server.Host/Components/Deployment/Remote/GitHubRemoteDeploymentManager.cs b/src/Tgstation.Server.Host/Components/Deployment/Remote/GitHubRemoteDeploymentManager.cs
index 16630a9f08..7365a58089 100644
--- a/src/Tgstation.Server.Host/Components/Deployment/Remote/GitHubRemoteDeploymentManager.cs
+++ b/src/Tgstation.Server.Host/Components/Deployment/Remote/GitHubRemoteDeploymentManager.cs
@@ -127,9 +127,9 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
Logger.LogTrace("In-progress deployment status created");
}
- catch (ApiException ex)
+ catch (Exception ex) when (ex is not OperationCanceledException)
{
- Logger.LogWarning(ex, "Unable to create deployment!");
+ Logger.LogWarning(ex, "Unable to create GitHub deployment!");
}
}
@@ -138,7 +138,7 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
compileJob.GitHubRepoId = await repositoryIdTask;
Logger.LogTrace("Set GitHub ID as {gitHubRepoId}", compileJob.GitHubRepoId);
}
- catch (RateLimitExceededException ex) when (!repositorySettings.CreateGitHubDeployments.Value)
+ catch (Exception ex) when (ex is not OperationCanceledException)
{
Logger.LogWarning(ex, "Unable to set compile job repository ID!");
}
@@ -252,9 +252,9 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
{
await gitHubService.CommentOnIssue(remoteRepositoryOwner, remoteRepositoryName, comment, testMergeNumber, cancellationToken);
}
- catch (ApiException e)
+ catch (Exception ex) when (ex is not OperationCanceledException)
{
- Logger.LogWarning(e, "Error posting GitHub comment!");
+ Logger.LogWarning(ex, "Error posting GitHub comment!");
}
}
@@ -336,14 +336,21 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
var gitHubService = gitHubServiceFactory.CreateService(gitHubAccessToken);
- await gitHubService.CreateDeploymentStatus(
- new NewDeploymentStatus(deploymentState)
- {
- Description = description,
- },
- compileJob.GitHubRepoId.Value,
- compileJob.GitHubDeploymentId.Value,
- cancellationToken);
+ try
+ {
+ await gitHubService.CreateDeploymentStatus(
+ new NewDeploymentStatus(deploymentState)
+ {
+ Description = description,
+ },
+ compileJob.GitHubRepoId.Value,
+ compileJob.GitHubDeploymentId.Value,
+ cancellationToken);
+ }
+ catch (Exception ex) when (ex is not OperationCanceledException)
+ {
+ Logger.LogWarning(ex, "Error updating GitHub deployment!");
+ }
}
}
}
diff --git a/src/Tgstation.Server.Host/Components/Deployment/Remote/GitLabRemoteDeploymentManager.cs b/src/Tgstation.Server.Host/Components/Deployment/Remote/GitLabRemoteDeploymentManager.cs
index afce81718d..c64b35af67 100644
--- a/src/Tgstation.Server.Host/Components/Deployment/Remote/GitLabRemoteDeploymentManager.cs
+++ b/src/Tgstation.Server.Host/Components/Deployment/Remote/GitLabRemoteDeploymentManager.cs
@@ -120,7 +120,7 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
CancellationToken cancellationToken) => Task.CompletedTask;
///
- protected override Task CommentOnTestMergeSource(
+ protected override async Task CommentOnTestMergeSource(
RepositorySettings repositorySettings,
string remoteRepositoryOwner,
string remoteRepositoryName,
@@ -132,13 +132,20 @@ namespace Tgstation.Server.Host.Components.Deployment.Remote
? new GitLabClient(GitLabRemoteFeatures.GitLabUrl, repositorySettings.AccessToken)
: new GitLabClient(GitLabRemoteFeatures.GitLabUrl);
- return client
- .MergeRequests
- .CreateNoteAsync(
- $"{remoteRepositoryOwner}/{remoteRepositoryName}",
- testMergeNumber,
- new CreateMergeRequestNoteRequest(comment))
- .WithToken(cancellationToken);
+ try
+ {
+ await client
+ .MergeRequests
+ .CreateNoteAsync(
+ $"{remoteRepositoryOwner}/{remoteRepositoryName}",
+ testMergeNumber,
+ new CreateMergeRequestNoteRequest(comment))
+ .WithToken(cancellationToken);
+ }
+ catch (Exception ex) when (ex is not OperationCanceledException)
+ {
+ Logger.LogWarning(ex, "Error posting GitHub comment!");
+ }
}
///