cyberpresidentvanellope/vgstation13
1
0
Fork 0
mirror of https://github.com/vgstation-coders/vgstation13.git synced 2025-12-09 16:14:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactors player preferences for modularity + SQLite Unit Test (#37615)

Browse Source 
* Pref code refactor

* Empty database reference

* Unit testing SQLite

* Everything else

* Disable unit testing.

* Equivalent

* more robust unit tests
This commit is contained in:
Anthony "Shifty Rail
2025-06-07 14:54:09 +01:00
committed by GitHub
parent 3290a3a747
commit 189f77cbb7
89 changed files with 4694 additions and 2543 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
code/modules/mob/dead/observer/observer.dm
View File

@@ -577,7 +577,7 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
sHuman.real_name = real_name
concrete_outfit.equip(sHuman, TRUE)
client?.prefs.copy_to(sHuman)
sHuman.add_language(client?.prefs.language)
sHuman.add_language(client?.prefs.get_pref(/datum/preference_setting/string/language))
sHuman.dna.UpdateSE()
sHuman.dna.UpdateUI()
sHuman.ckey = ckey

10
code/modules/mob/dead/observer/say.dm
View File

@@ -41,17 +41,17 @@
if (get_dist(source_turf, src) <= get_view_range())
rendered_speech = "<B>[rendered_speech]</B>"
if (client?.prefs.mob_chat_on_map && (client.prefs.obj_chat_on_map || ismob(speech.speaker)))
if (client?.prefs.get_pref(/datum/preference_setting/toggle/mob_chat_on_map) && (client.prefs.get_pref(/datum/preference_setting/toggle/obj_chat_on_map) || ismob(speech.speaker)))
create_chat_message(speech.speaker, speech.language, speech.message, speech.mode, speech.wrapper_classes)
else
if(client && client.prefs)
if (!speech.frequency)
if ((client.prefs.toggles & CHAT_GHOSTEARS) != CHAT_GHOSTEARS)
say_testing(src, "/mob/dead/observer/Hear(): CHAT_GHOSTEARS is disabled, blocking. ([client.prefs.toggles] & [CHAT_GHOSTEARS]) = [client.prefs.toggles & CHAT_GHOSTEARS]")
if ((client.prefs.get_pref(/datum/preference_setting/binary_flag/toggles) & CHAT_GHOSTEARS) != CHAT_GHOSTEARS)
say_testing(src, "/mob/dead/observer/Hear(): CHAT_GHOSTEARS is disabled, blocking. ([client.prefs.get_pref(/datum/preference_setting/binary_flag/toggles)] & [CHAT_GHOSTEARS]) = [client.prefs.get_pref(/datum/preference_setting/binary_flag/toggles) & CHAT_GHOSTEARS]")
return
else
if ((client.prefs.toggles & CHAT_GHOSTRADIO) != CHAT_GHOSTRADIO)
say_testing(src, "/mob/dead/observer/Hear(): CHAT_GHOSTRADIO is disabled, blocking. ([client.prefs.toggles] & [CHAT_GHOSTRADIO]) = [client.prefs.toggles & CHAT_GHOSTRADIO]")
if ((client.prefs.get_pref(/datum/preference_setting/binary_flag/toggles) & CHAT_GHOSTRADIO) != CHAT_GHOSTRADIO)
say_testing(src, "/mob/dead/observer/Hear(): CHAT_GHOSTRADIO is disabled, blocking. ([client.prefs.get_pref(/datum/preference_setting/binary_flag/toggles)] & [CHAT_GHOSTRADIO]) = [client.prefs.get_pref(/datum/preference_setting/binary_flag/toggles) & CHAT_GHOSTRADIO]")
return
to_chat(src, "[formatFollow(source)] [rendered_speech]")