cyberpresidentvanellope/vgstation13
1
0
Fork 0
mirror of https://github.com/vgstation-coders/vgstation13.git synced 2025-12-10 02:16:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

The Culling of ROLE_ (#21661)

Browse Source 
* culling of role

* fix compile

* Typos

* alien ROLE
This commit is contained in:
Kurfursten
2019-03-05 15:51:10 -06:00
committed by MadmanMartian
parent 96f9492952
commit 4cc066f3b5
30 changed files with 102 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
code/datums/gamemode/dynamic/dynamic_rulesets_roundstart.dm
View File

@@ -45,7 +45,7 @@
/*
/datum/dynamic_ruleset/roundstart/changeling
name = "Changelings"
role_category = ROLE_CHANGELING
role_category = CHANGELING
protected_from_jobs = list("Security Officer", "Warden", "Merchant", "Head of Personnel", "Detective", "Head of Security", "Captain")
restricted_from_jobs = list("AI","Cyborg","Mobile MMI")
enemy_jobs = list("Security Officer","Detective","Head of Security", "Captain")
@@ -194,7 +194,7 @@
/datum/dynamic_ruleset/roundstart/cult_legacy
name = "Cult (Legacy)"
role_category = /datum/role/legacy_cultist
role_category_override = ROLE_CULTIST // H-ha
role_category_override = CULTIST // H-ha
protected_from_jobs = list("Merchant")
restricted_from_jobs = list("AI", "Cyborg", "Mobile MMI", "Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Chaplain", "Head of Personnel", "Internal Affairs Agent", "Chaplain")
enemy_jobs = list("AI", "Cyborg", "Security Officer","Detective","Head of Security", "Captain", "Chaplain")

2
code/datums/gamemode/factions/bloodcult/bloodcult_buildings.dm
View File

@@ -273,7 +273,7 @@
if (istype(blade) && !blade.shade)
var/icon/logo_icon = icon('icons/logos.dmi', "shade-blade")
for(var/mob/M in observers)
if(!M.client || isantagbanned(M) || jobban_isbanned(M, ROLE_CULTIST) || M.client.is_afk())
if(!M.client || isantagbanned(M) || jobban_isbanned(M, CULTIST) || M.client.is_afk())
continue
if (M.mind && M.mind.GetRole(CULTIST))
var/datum/role/cultist/cultist = M.mind.GetRole(CULTIST)

4
code/datums/gamemode/factions/bloodcult/bloodcult_runespells.dm
View File

@@ -874,8 +874,8 @@
victim.Stun(15)
if (victim.client && victim.mind.assigned_role != "Chaplain")//Chaplains can never be converted
acceptance = get_role_desire_str(victim.client.prefs.roles[ROLE_CULTIST])
if (jobban_isbanned(victim, ROLE_CULTIST) || isantagbanned(victim))
acceptance = get_role_desire_str(victim.client.prefs.roles[CULTIST])
if (jobban_isbanned(victim, CULTIST) || isantagbanned(victim))
acceptance = "Banned"
//Players with cult enabled in their preferences will always get converted.

5
code/datums/gamemode/factions/faction.dm
View File

@@ -323,7 +323,7 @@ var/list/factions_with_hud_icons = list()
ID = HIVEMIND
initial_role = CHANGELING
late_role = CHANGELING
required_pref = ROLE_CHANGELING
required_pref = CHANGELING
desc = "An almost parasitic, shapeshifting entity that assumes the identity of its victims. Commonly used as smart bioweapons by the syndicate,\
or simply wandering malignant vagrants happening upon a meal of identity that can carry them to further feeding grounds."
roletype = /datum/role/changeling
@@ -342,7 +342,7 @@ var/list/factions_with_hud_icons = list()
ID = WIZFEDERATION
initial_role = WIZARD
late_role = WIZARD
required_pref = ROLE_WIZARD
required_pref = WIZARD
desc = "A conglomeration of magically adept individuals, with no obvious heirachy, instead acting as equal individuals in the pursuit of magic-oriented endeavours.\
Their motivations for attacking seemingly peaceful enclaves or operations are as yet unknown, but they do so without respite or remorse.\
This has led to them being identified as enemies of humanity, and should be treated as such."
@@ -382,7 +382,6 @@ var/list/factions_with_hud_icons = list()
/datum/faction/strike_team
name = "Custom Strike Team"//obviously this name is a placeholder getting replaced by the admin setting up the squad
required_pref = ROLE_STRIKE
ID = CUSTOMSQUAD
logo_state = "nano-logo"

2
code/datums/gamemode/factions/legacy_cult/cult.dm
View File

@@ -42,7 +42,7 @@ var/global/list/rnwords = list("ire","ego","nahlizet","certum","veri","jatkaa","
initroletype = /datum/role/legacy_cultist
roletype = /datum/role/legacy_cultist
required_pref = ROLE_LEGACY_CULTIST
required_pref = CULTIST
/datum/faction/cult/narsie/GetObjectivesMenuHeader()
var/icon/logo = icon('icons/logos.dmi', "cult-logo")

2
code/datums/gamemode/factions/legacy_cult/soulstone.dm
View File

@@ -297,7 +297,7 @@
playsound(get_turf(src), get_sfx("soulstone"), 50,1)
//Are we capturing a cult-banned player as a cultist? Sucks for them!
if (iscultist(user) && (jobban_isbanned(body, ROLE_CULTIST) || isantagbanned(body)))
if (iscultist(user) && (jobban_isbanned(body, CULTIST) || isantagbanned(body)))
to_chat(body, "<span class='danger'>A cultist tried to capture your soul, but due to past behaviour you have been banned from the role. Your body will instead dust away.</span>")
to_chat(user, "<span class='notice'>Their soul wasn't fit for our cult, and wasn't accepted by \the [src].</span>")

2
code/datums/gamemode/factions/malf.dm
View File

@@ -2,7 +2,7 @@
name = "Malfunctioning AI"
desc = "ERROR"
ID = MALF
required_pref = ROLE_MALF
required_pref = MALF
initial_role = MALF
late_role = MALFBOT
initroletype = /datum/role/malfAI //First addition should be the AI

2
code/datums/gamemode/factions/syndicate/nukeops.dm
View File

@@ -1,7 +1,7 @@
/datum/faction/syndicate/nuke_op
name = "Syndicate Nuclear Operatives"
ID = SYNDIOPS
required_pref = ROLE_OPERATIVE
required_pref = NUKE_OP
initial_role = NUKE_OP
late_role = NUKE_OP
initroletype = /datum/role/nuclear_operative

2
code/datums/gamemode/factions/syndicate/rev.dm
View File

@@ -3,7 +3,7 @@
/datum/faction/revolution
name = "Revolutionaries"
ID = REVOLUTION
required_pref = ROLE_REV
required_pref = REV
initial_role = HEADREV
late_role = REV
desc = "Viva!"

2
code/datums/gamemode/factions/syndicate/traitor.dm
View File

@@ -1,7 +1,7 @@
/datum/faction/syndicate
name = "The Syndicate"
ID = SYNDICATE
required_pref = ROLE_TRAITOR
required_pref = TRAITOR
desc = "A coalition of companies that actively work against Nanotrasen's intentions. Seen as Freedom fighters by some, Rebels and Malcontents by others."
logo_state = "synd-logo"

2
code/datums/gamemode/factions/vampire_faction.dm
View File

@@ -2,7 +2,7 @@
name = "Vampire Lords"
desc = "Hailing from Space Transylvania."
ID = VAMPIRELORDS
required_pref = ROLE_VAMPIRE
required_pref = VAMPIRE
initial_role = VAMPIRE
late_role = VAMPIRE // Vampires do not change their role.
roletype = /datum/role/vampire

2
code/datums/gamemode/role/changeling.dm
View File

@@ -1,7 +1,7 @@
/datum/role/changeling
name = "Changeling"
id = CHANGELING
required_pref = ROLE_CHANGELING
required_pref = CHANGELING
protected_jobs = list("Security Officer", "Warden", "Detective", "Head of Security", "Captain")
protected_traitor_prob = PROB_PROTECTED_RARE
logo_state = "change-logoa"

6
code/datums/gamemode/role/cultist.dm
View File

@@ -1,7 +1,7 @@
/datum/role/cultist
id = ROLE_CULTIST
id = CULTIST
name = "Cultist"
required_pref = ROLE_CULTIST
required_pref = CULTIST
protected_jobs = list("Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Chaplain", "Head of Personnel", "Internal Affairs Agent", "Merchant")
logo_state = "cult-logo"
greets = list(GREET_DEFAULT,GREET_CUSTOM,GREET_ROUNDSTART,GREET_ADMINTOGGLE)
@@ -12,7 +12,7 @@
/datum/role/cultist/New(var/datum/mind/M, var/datum/faction/fac=null, var/new_id)
..()
wikiroute = role_wiki[ROLE_CULTIST]
wikiroute = role_wiki[CULTIST]
/datum/role/cultist/OnPostSetup()
. = ..()

4
code/datums/gamemode/role/grinch.dm
View File

@@ -1,7 +1,7 @@
/datum/role/grinch
name = GRINCH
id = ROLE_GRINCH
required_pref = ROLE_GRINCH
id = GRINCH
required_pref = GRINCH
logo_state = "synd-logo"
disallow_job = TRUE
refund_value = BASE_SOLO_REFUND

4
code/datums/gamemode/role/legacy_cultist.dm
View File

@@ -1,12 +1,12 @@
/datum/role/legacy_cultist
id = LEGACY_CULTIST
name = LEGACY_CULTIST
special_role = ROLE_LEGACY_CULTIST
special_role = LEGACY_CULTIST
disallow_job = FALSE
restricted_jobs = list("AI", "Cyborg", "Mobile MMI", "Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Chaplain", "Head of Personnel", "Internal Affairs Agent", "Merchant")
logo_state = "cult-logo"
greets = list("default","custom","admintoggle")
required_pref = ROLE_LEGACY_CULTIST
required_pref = CULTIST
/datum/role/legacy_cultist/OnPostSetup(var/equip = FALSE)
. = ..()

4
code/datums/gamemode/role/rev.dm
View File

@@ -1,7 +1,7 @@
/datum/role/revolutionary
name = REV
id = REV
required_pref = ROLE_REV
required_pref = REV
restricted_jobs = list("Security Officer", "Warden", "Detective", "AI", "Cyborg","Mobile MMI","Captain", "Head of Personnel", "Head of Security", "Chief Engineer", "Research Director", "Chief Medical Officer", "Internal Affairs Agent")
logo_state = "rev-logo"
greets = list(GREET_DEFAULT,GREET_CUSTOM,GREET_ROUNDSTART,GREET_MIDROUND,GREET_LATEJOIN,GREET_CONVERTED,GREET_PROVOC_CONVERTED,GREET_REVSQUAD_CONVERTED,GREET_ADMINTOGGLE)
@@ -48,7 +48,7 @@
/datum/role/revolutionary/New()
..()
wikiroute = role_wiki[ROLE_REV]
wikiroute = role_wiki[REV]
/datum/role/revolutionary/leader
name = HEADREV

6
code/datums/gamemode/role/role.dm
View File

@@ -572,7 +572,7 @@
/datum/role/blob_overmind
name = BLOBOVERMIND
id = BLOBOVERMIND
required_pref = ROLE_BLOB
required_pref = BLOBOVERMIND
logo_state = "blob-logo"
greets = list(GREET_DEFAULT,GREET_CUSTOM)
var/countdown = 60
@@ -660,7 +660,7 @@
name = WIZARD
id = WIZARD
special_role = WIZARD
required_pref = ROLE_WIZARD
required_pref = WIZARD
disallow_job = TRUE
logo_state = "wizard-logo"
refund_value = BASE_SOLO_REFUND * 2
@@ -788,7 +788,7 @@
/datum/role/malfAI
name = MALF
id = MALF
required_pref = ROLE_MALF
required_pref = MALF
logo_state = "malf-logo"
/datum/role/malfAI/OnPostSetup()

8
code/datums/gamemode/role/syndicate.dm
View File

@@ -1,9 +1,9 @@
/datum/role/traitor
name = TRAITOR
id = TRAITOR
required_pref = ROLE_TRAITOR
required_pref = TRAITOR
logo_state = "synd-logo"
wikiroute = ROLE_TRAITOR
wikiroute = TRAITOR
refund_value = BASE_SOLO_REFUND
var/can_be_smooth = TRUE //Survivors can't be smooth because they get nothing.
@@ -226,8 +226,8 @@
/datum/role/nuclear_operative
name = NUKE_OP
id = ROLE_OPERATIVE
required_pref = ROLE_OPERATIVE
id = NUKE_OP
required_pref = NUKE_OP
disallow_job = TRUE
logo_state = "nuke-logo"

6
code/datums/gamemode/role/vampire_role.dm
View File

@@ -5,12 +5,12 @@
/datum/role/vampire
id = VAMPIRE
name = VAMPIRE
special_role = ROLE_VAMPIRE
special_role = VAMPIRE
disallow_job = FALSE
restricted_jobs = list("AI", "Cyborg", "Mobile MMI", "Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Chaplain")
logo_state = "vampire-logo"
greets = list(GREET_DEFAULT,GREET_CUSTOM,GREET_ADMINTOGGLE, GREET_MASTER)
required_pref = ROLE_VAMPIRE
required_pref = VAMPIRE
protected_traitor_prob = PROB_PROTECTED_RARE
refund_value = BASE_SOLO_REFUND
@@ -37,7 +37,7 @@
else if (istype(fac, /datum/faction/vampire))
vamp_fac = fac
vamp_fac.addMaster(src)
wikiroute = role_wiki[ROLE_VAMPIRE]
wikiroute = role_wiki[VAMPIRE]
/datum/role/vampire/Greet(var/greeting,var/custom)
if(!greeting)

2
code/datums/gamemode/role/weeaboo.dm
View File

@@ -1,7 +1,7 @@
/datum/role/weeaboo
name = WEEABOO
id = WEEABOO
required_pref = ROLE_WEEABOO
required_pref = WEEABOO
special_role = WEEABOO
logo_state = "weeaboo-logo"
refund_value = BASE_SOLO_REFUND

2
code/datums/uplink_item.dm
View File

@@ -118,7 +118,7 @@ var/list/uplink_items = list()
if(user.mind)
user.mind.spent_TC += get_cost(U.job)
//First, try to add the uplink buys to any operative teams they're on. If none, add to a traitor role they have.
var/datum/role/R = user.mind.GetRole(ROLE_OPERATIVE)
var/datum/role/R = user.mind.GetRole(NUKE_OP)
if(R)
R.faction.faction_scoreboard_data += {"<img src="logo_[tempstate].png"> [bundlename] for [get_cost(U.job)] TC<BR>"}
else