role datums fixes and tweaks (#18277)

* * makes raging mages actually work
 * removes the 'protect master' objective, instead uses the protect objective
 * removes heavily redundant and useless vampire gamemode tweaks. master vampire is now handled through the role creating its own faction if one is not provided.
 * CreateRoles diversified, new filterAvailablePlayers proc, and now it actually works
 * Fixes mixed
 * Fixes syndicate agents becoming other sorts of syndicate agents, causing syndicate agent recursion
 * Fixes check antagonist for factions and roles not newlining after a role has been viewed

* moves rolecheck to faction, rather than having a snowflake check for traitor

* all my problems were because of a missed return 1

* more role fixes!

* removes debug
This commit is contained in:
MadmanMartian
2018-05-17 01:52:21 +01:00
committed by GitHub
parent 42433ee4d3
commit 4f84f6a029
18 changed files with 147 additions and 121 deletions

View File

@@ -1458,7 +1458,7 @@
.(href, list("c_mode"=1))
else
var/list/possible = list()
possible += mixed_allowed
possible += mixed_factions_allowed
possible += "DONE"
possible += "CANCEL"
if(possible.len < 3)
@@ -1504,7 +1504,7 @@
.(href, list("f_secret"=1))
else
var/list/possible = list()
possible += mixed_allowed
possible += mixed_factions_allowed
possible += "DONE"
possible += "CANCEL"
if(possible.len < 3)