From 73aebb51a751b949395a1603ef947e6f08f7ea81 Mon Sep 17 00:00:00 2001 From: "giacomand@gmail.com" Date: Sun, 23 Sep 2012 05:17:54 +0000 Subject: [PATCH] -Small tweak to /atom/DblClick. The dummy will be garbage collected instead, hopefully this will help performance. I'm concerned that somehow other code will reference the Dummy, stopping it from being garbage collected. I think that the small occurrences that this could will not be game breaking or affect anything. git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4737 316c924e-a436-60f5-8080-3fe189b3f50e --- code/game/atoms.dm | 21 +++++++++++++++++-- .../mob/living/carbon/metroid/metroid.dm | 5 ++++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/code/game/atoms.dm b/code/game/atoms.dm index 6402176423a..e7409a4555e 100644 --- a/code/game/atoms.dm +++ b/code/game/atoms.dm @@ -1128,7 +1128,11 @@ var/using_new_click_proc = 0 //TODO ERRORAGE (This is temporary, while the DblCl See the previous More info, for... more info... */ - del(D) + //del(D) + // Garbage Collect Dummy + D.loc = null + D = null + // ------- DUMMY OBJECT'S SERVED IT'S PURPOSE, IT'S REWARDED WITH A SWIFT DELETE ------- if (!( ok )) // ------- TESTS ABOVE DETERMINED YOU CANNOT REACH THE TILE ------- @@ -1357,4 +1361,17 @@ var/using_new_click_proc = 0 //TODO ERRORAGE (This is temporary, while the DblCl return 0 /atom/proc/checkpass(passflag) - return pass_flags&passflag \ No newline at end of file + return pass_flags&passflag + +/* +/client/verb/check_dummy() + set name = "List Dummies" + set category = "Debug" + + var/list/dummies = list() + for(var/obj/item/weapon/dummy/D in world) + usr << "[D] - [D.x], [D.y], [D.z] - [D.loc]" + dummies += D + usr << "[dummies.len] found!" +*/ + diff --git a/code/modules/mob/living/carbon/metroid/metroid.dm b/code/modules/mob/living/carbon/metroid/metroid.dm index f2e2b5185b1..acf65197f5b 100644 --- a/code/modules/mob/living/carbon/metroid/metroid.dm +++ b/code/modules/mob/living/carbon/metroid/metroid.dm @@ -762,7 +762,10 @@ mob/living/carbon/metroid/var/temperature_resistance = T0C+75 if(!border_obstacle.CanPass(D, D.loc, 1, 0)) ok = 0 - del(D) + //del(D) + //Garbage Collect Dummy + D.loc = null + D = null if (!( ok )) return 0