diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5b1e005af4b..195fe41e5d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ CONTRIBUTING TO VGSTATION * This means, primarily, that you shouldn't fix bugs **and** add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes. * **Test your changes.** PRs that do not compile will not be accepted. * Testing your changes locally is incredibly important. If you break the serb we will be very upset with you. -* **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN IRC.** +* **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN THE CODE DISCORD.** (link in README.md) * Merging your own PRs is considered bad practice, as it generally means you bypass peer review, which is a core part of how we develop. # Balance changes @@ -15,6 +15,7 @@ CONTRIBUTING TO VGSTATION * Server polls * bringing attention to your PR via in-game OOC, ideally over several time slots. * **Balance change PRs need changelogs. Always.** + * **If you are a collaborator,** allow sufficient time for feedback to be gathered, and make sure that it *has* been gathered. It is also suggested that you hop into irc.rizon.net #vgstation to discuss your changes, or if you need help.