cyberpresidentvanellope/vgstation13
1
0
Fork 0
mirror of https://github.com/vgstation-coders/vgstation13.git synced 2025-12-09 16:14:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

irc is dead also collab-specific rule

Browse Source
This commit is contained in:
Sood
2017-07-30 18:42:52 -07:00
parent 63c55c9c54
commit e398930a64
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CONTRIBUTING.md
View File

@@ -7,7 +7,7 @@ CONTRIBUTING TO VGSTATION
* This means, primarily, that you shouldn't fix bugs **and** add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes. * This means, primarily, that you shouldn't fix bugs **and** add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes.
* **Test your changes.** PRs that do not compile will not be accepted. * **Test your changes.** PRs that do not compile will not be accepted.
* Testing your changes locally is incredibly important. If you break the serb we will be very upset with you. * Testing your changes locally is incredibly important. If you break the serb we will be very upset with you.
* **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN IRC.** * **Large changes require discussion.** If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. **MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN THE CODE DISCORD.** (link in README.md)
* Merging your own PRs is considered bad practice, as it generally means you bypass peer review, which is a core part of how we develop. * Merging your own PRs is considered bad practice, as it generally means you bypass peer review, which is a core part of how we develop.
# Balance changes # Balance changes
@@ -15,6 +15,7 @@ CONTRIBUTING TO VGSTATION
* Server polls * Server polls
* bringing attention to your PR via in-game OOC, ideally over several time slots. * bringing attention to your PR via in-game OOC, ideally over several time slots.
* **Balance change PRs need changelogs. Always.** * **Balance change PRs need changelogs. Always.**
* **If you are a collaborator,** allow sufficient time for feedback to be gathered, and make sure that it *has* been gathered.
It is also suggested that you hop into irc.rizon.net #vgstation to discuss your changes, or if you need help. It is also suggested that you hop into irc.rizon.net #vgstation to discuss your changes, or if you need help.