-Fix for runtime errors when shuttles move.

Apparently the list holds unsimulated turf, which came from the shuttle, even though the list type is for simulated turf only. Because of this it was generating runtime errors. I made the foreach loop do a type check to fix this issue for now.

-Instead of an admin message, edited minds will instead just log.

Requested by Kor.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4741 316c924e-a436-60f5-8080-3fe189b3f50e
This commit is contained in:
giacomand@gmail.com
2012-09-23 16:29:51 +00:00
parent b37ad5df02
commit ff4f9a7699
2 changed files with 18 additions and 19 deletions

View File

@@ -277,8 +277,7 @@ datum
return 1 return 1
process_update_tiles() process_update_tiles()
for(var/turf in tiles_to_update) for(var/turf/simulated/T in tiles_to_update)
var/turf/simulated/T = turf
T.update_air_properties() T.update_air_properties()
/* /*
for(var/obj/movable/floor/O in tiles_to_update) for(var/obj/movable/floor/O in tiles_to_update)

View File

@@ -485,7 +485,7 @@ datum/mind
current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a head revolutionary!</B></FONT>" current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a head revolutionary!</B></FONT>"
ticker.mode.update_rev_icons_removed(src) ticker.mode.update_rev_icons_removed(src)
special_role = null special_role = null
message_admins("[key_name_admin(usr)] has de-rev'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-rev'ed [current].")
if("rev") if("rev")
if(src in ticker.mode.head_revolutionaries) if(src in ticker.mode.head_revolutionaries)
@@ -499,7 +499,7 @@ datum/mind
ticker.mode.revolutionaries += src ticker.mode.revolutionaries += src
ticker.mode.update_rev_icons_added(src) ticker.mode.update_rev_icons_added(src)
special_role = "Revolutionary" special_role = "Revolutionary"
message_admins("[key_name(usr)] has rev'ed [current].") log_admin("[key_name(usr)] has rev'ed [current].")
if("headrev") if("headrev")
if(src in ticker.mode.revolutionaries) if(src in ticker.mode.revolutionaries)
@@ -524,7 +524,7 @@ datum/mind
ticker.mode.head_revolutionaries += src ticker.mode.head_revolutionaries += src
ticker.mode.update_rev_icons_added(src) ticker.mode.update_rev_icons_added(src)
special_role = "Head Revolutionary" special_role = "Head Revolutionary"
message_admins("[key_name_admin(usr)] has head-rev'ed [current].", 1) log_admin("[key_name_admin(usr)] has head-rev'ed [current].")
if("autoobjectives") if("autoobjectives")
ticker.mode.forge_revolutionary_objectives(src) ticker.mode.forge_revolutionary_objectives(src)
@@ -573,7 +573,7 @@ datum/mind
cult.memoize_cult_objectives(src) cult.memoize_cult_objectives(src)
current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a cultist!</B></FONT>" current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a cultist!</B></FONT>"
memory = "" memory = ""
message_admins("[key_name_admin(usr)] has de-cult'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-cult'ed [current].")
if("cultist") if("cultist")
if(!(src in ticker.mode.cult)) if(!(src in ticker.mode.cult))
ticker.mode.cult += src ticker.mode.cult += src
@@ -584,7 +584,7 @@ datum/mind
var/datum/game_mode/cult/cult = ticker.mode var/datum/game_mode/cult/cult = ticker.mode
if (istype(cult)) if (istype(cult))
cult.memoize_cult_objectives(src) cult.memoize_cult_objectives(src)
message_admins("[key_name_admin(usr)] has cult'ed [current].", 1) log_admin("[key_name_admin(usr)] has cult'ed [current].")
if("tome") if("tome")
var/mob/living/carbon/human/H = current var/mob/living/carbon/human/H = current
if (istype(H)) if (istype(H))
@@ -615,14 +615,14 @@ datum/mind
special_role = null special_role = null
current.spellremove(current, config.feature_object_spell_system? "object":"verb") current.spellremove(current, config.feature_object_spell_system? "object":"verb")
current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a wizard!</B></FONT>" current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a wizard!</B></FONT>"
message_admins("[key_name_admin(usr)] has de-wizard'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-wizard'ed [current].")
if("wizard") if("wizard")
if(!(src in ticker.mode.wizards)) if(!(src in ticker.mode.wizards))
ticker.mode.wizards += src ticker.mode.wizards += src
special_role = "Wizard" special_role = "Wizard"
//ticker.mode.learn_basic_spells(current) //ticker.mode.learn_basic_spells(current)
current << "<B>\red You are the Space Wizard!</B>" current << "<B>\red You are the Space Wizard!</B>"
message_admins("[key_name_admin(usr)] has wizard'ed [current].", 1) log_admin("[key_name_admin(usr)] has wizard'ed [current].")
if("lair") if("lair")
current.loc = pick(wizardstart) current.loc = pick(wizardstart)
if("dressup") if("dressup")
@@ -642,14 +642,14 @@ datum/mind
current.remove_changeling_powers() current.remove_changeling_powers()
if(changeling) del(changeling) if(changeling) del(changeling)
current << "<FONT color='red' size = 3><B>You grow weak and lose your powers! You are no longer a changeling and are stuck in your current form!</B></FONT>" current << "<FONT color='red' size = 3><B>You grow weak and lose your powers! You are no longer a changeling and are stuck in your current form!</B></FONT>"
message_admins("[key_name_admin(usr)] has de-changeling'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-changeling'ed [current].")
if("changeling") if("changeling")
if(!(src in ticker.mode.changelings)) if(!(src in ticker.mode.changelings))
ticker.mode.changelings += src ticker.mode.changelings += src
ticker.mode.grant_changeling_powers(current) ticker.mode.grant_changeling_powers(current)
special_role = "Changeling" special_role = "Changeling"
current << "<B><font color='red'>Your powers are awoken. A flash of memory returns to us...we are a changeling!</font></B>" current << "<B><font color='red'>Your powers are awoken. A flash of memory returns to us...we are a changeling!</font></B>"
message_admins("[key_name_admin(usr)] has changeling'ed [current].", 1) log_admin("[key_name_admin(usr)] has changeling'ed [current].")
if("autoobjectives") if("autoobjectives")
ticker.mode.forge_changeling_objectives(src) ticker.mode.forge_changeling_objectives(src)
usr << "\blue The objectives for changeling [key] have been generated. You can edit them and anounce manually." usr << "\blue The objectives for changeling [key] have been generated. You can edit them and anounce manually."
@@ -673,7 +673,7 @@ datum/mind
for (var/datum/objective/nuclear/O in objectives) for (var/datum/objective/nuclear/O in objectives)
objectives-=O objectives-=O
current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a syndicate operative!</B></FONT>" current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a syndicate operative!</B></FONT>"
message_admins("[key_name_admin(usr)] has de-nuke op'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-nuke op'ed [current].")
if("nuclear") if("nuclear")
if(!(src in ticker.mode.syndicates)) if(!(src in ticker.mode.syndicates))
ticker.mode.syndicates += src ticker.mode.syndicates += src
@@ -686,7 +686,7 @@ datum/mind
current << "\blue You are a [syndicate_name()] agent!" current << "\blue You are a [syndicate_name()] agent!"
ticker.mode.forge_syndicate_objectives(src) ticker.mode.forge_syndicate_objectives(src)
ticker.mode.greet_syndicate(src) ticker.mode.greet_syndicate(src)
message_admins("[key_name_admin(usr)] has nuke op'ed [current].", 1) log_admin("[key_name_admin(usr)] has nuke op'ed [current].")
if("lair") if("lair")
current.loc = get_turf(locate("landmark*Syndicate-Spawn")) current.loc = get_turf(locate("landmark*Syndicate-Spawn"))
if("dressup") if("dressup")
@@ -722,14 +722,14 @@ datum/mind
ticker.mode.traitors -= src ticker.mode.traitors -= src
special_role = null special_role = null
current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a traitor!</B></FONT>" current << "\red <FONT size = 3><B>You have been brainwashed! You are no longer a traitor!</B></FONT>"
message_admins("[key_name_admin(usr)] has de-traitor'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-traitor'ed [current].")
if("traitor") if("traitor")
if(!(src in ticker.mode.traitors)) if(!(src in ticker.mode.traitors))
ticker.mode.traitors += src ticker.mode.traitors += src
special_role = "traitor" special_role = "traitor"
current << "<B>\red You are a traitor!</B>" current << "<B>\red You are a traitor!</B>"
message_admins("[key_name_admin(usr)] has traitor'ed [current].", 1) log_admin("[key_name_admin(usr)] has traitor'ed [current].")
if("autoobjectives") if("autoobjectives")
ticker.mode.forge_traitor_objectives(src) ticker.mode.forge_traitor_objectives(src)
@@ -809,11 +809,11 @@ datum/mind
current.icon_state = "ai" current.icon_state = "ai"
current << "\red <FONT size = 3><B>You have been patched! You are no longer malfunctioning!</B></FONT>" current << "\red <FONT size = 3><B>You have been patched! You are no longer malfunctioning!</B></FONT>"
message_admins("[key_name_admin(usr)] has de-malf'ed [current].", 1) log_admin("[key_name_admin(usr)] has de-malf'ed [current].")
if("malf") if("malf")
make_AI_Malf() make_AI_Malf()
message_admins("[key_name_admin(usr)] has malf'ed [current].", 1) log_admin("[key_name_admin(usr)] has malf'ed [current].")
if("unemag") if("unemag")
var/mob/living/silicon/robot/R = current var/mob/living/silicon/robot/R = current
@@ -830,7 +830,7 @@ datum/mind
else if(R.module_state_3 == R.module.emag) else if(R.module_state_3 == R.module.emag)
R.module_state_3 = null R.module_state_3 = null
R.contents -= R.module.emag R.contents -= R.module.emag
message_admins("[key_name_admin(usr)] has unemag'ed [R].", 1) log_admin("[key_name_admin(usr)] has unemag'ed [R].")
if("unemagcyborgs") if("unemagcyborgs")
if (istype(current, /mob/living/silicon/ai)) if (istype(current, /mob/living/silicon/ai))
@@ -849,7 +849,7 @@ datum/mind
else if(R.module_state_3 == R.module.emag) else if(R.module_state_3 == R.module.emag)
R.module_state_3 = null R.module_state_3 = null
R.contents -= R.module.emag R.contents -= R.module.emag
message_admins("[key_name_admin(usr)] has unemag'ed [ai]'s Cyborgs.", 1) log_admin("[key_name_admin(usr)] has unemag'ed [ai]'s Cyborgs.")
else if (href_list["common"]) else if (href_list["common"])
switch(href_list["common"]) switch(href_list["common"])