A lot of code standardising for the way machines handle trying to take money from a user.
All machines can now be set to connect to the accounts database in initialize().
reconnect_database(), connect_account(), and scan_card() have all been moved to the machine level.
Merch computer now reads your equipped ID, not your mind account. Fixes#2854.
All machines getting your ID using get_id_card() now check all your slots, with hands being prioritised over the ID slot.
Removed a pointless human-only proc that was causing befuddlement.
I don't really get this if statement in policetape, but it should be fixed now maybe.
Added a proc for checking if two stacks can merge, used it on coloured cables. Fixes#4156.
Made the welding damage message list the item intensifying the damage. Fixes#4187.
Added Vox exclusion to RIG helmets, removed it from Wiz and Nukeops hardsuits. Fixes#4790, fixes#4756, fixes#4496.
Orebag now only gives borgs a message if it finds ore. Fixes#4150.
Throws something at #4267, hardcode is bad and everyone should feel bad.
BUILDMODE CLICK USED TO CALL IN WORLD EVERY CLICK.
Fun fact: just because you dont use the words "in world" doesn't mean you aren't LOOPING THROUGH THE WORLD EVERY TIME YOU CLICK ON ANYTHING IN BUILD MODE JESUS CHRIST.
Removed update_values(). RIP, shine on you CPU diamond.
Removed get_moles_by_id and get_archived_moles_by_id, all moles are now accessed directly to reduce call cost.
Added set_temperature and set_volume procs which recalc pressure when temperature or pressure change.
Heat_capacity is now a var updated when gases update.
Modified adjust_gas to use set_gas, modified set_gas to alter heat_capacity, total_moles, and pressure as needed.
Moved gas_mixture gas numbers to a list which is connected to a global gas_datum list, like with reagents.
Modified some maths procs to be more sane, added adjust_gas and set_gas to help with processing.
Added a modular system for gas flags - gases can now be marked as fuel and oxidiser with a flag, logged with a flag, scanned with a flag, etc.
Changed scrubbers to use a list of scrubbing gases rather than a set of vars.
Made miners and xenoarch effects more sensible - they now produce gas by ID, not manually.
Made turfs' starting gases into a list, removed turf gas number vars.
Fixes#3517, apparently the stat() for spacepod cells checked that the battery has an object of type cell within it. But since spacepods typecast their cell for specific initialization of a high power cell, the istype(S.battery) check fails if you placed a different type of cell into it. Causing it to instead display no cell detected.
- Fix full reinforced windows using the old description
- Add a new brokenup var for the window's Destroy() call. Defaults to
0, if 1 then the window will shatter into shards and rods (the old
behavior caused any window deleting to shatter them)
- Changes to all files that called Destroy() on windows to use this new
behavior
That code was old and fucky, goddamn
- Span, formatting, newline, visible_message, yeah
- Separate sprites for window panes and full windows. Might need a bit
more refining still, but that's that
- Remove deprecated commented silicate code. If anyone ever wants to
include something akin to silicate, they would benefit from just
recoding it from scratch. An item that adds health and potentially
changes sprite color can't be that hard to make
- Reduce normal window health by 4 to 10. Why would you use plain
windows
- Remove stupid paths that caused shitty inheritance. window/basic and
window/full/basic were dumb as fucking shit and no longer exist (both
transferred to their respective tree parent, for whatever variables
needed transplating, so 2-3). All full window types under full/ all
reinforced window types under reinforced/, all in that order
- Add in more examine() information (construction state and health)
- Add in healthcheck() to replace destroy(), hit() and all that logging
and variable juggling bullshit in about every proc where the window can
be damaged
- ex_act(), blob_act(), meteorhit() now deplete health only and no
longer magically delete or Destroy() windows. Looks a bit ugly on ex_act
3 since reinforced windows can't be destroyed but grilles always are,
and plasma windows still don't block explosions even if they're now
almost bomb-proof, but that's progress
- Remove window damage on passive grab window "slam", massively increase
mob damage on neck/kill window slam (if you let yourself get grabbed
that far, you deserve to die)
- Change construction from that ugly variable juggling to a fancy and
functional switch() construction code. Include bitflags and
deconstruction safety
- All files that were modified outside of window.dm and fullwindow.dm
are compatibility fixes
Try as I might, I couldn't fix#3515. It appears to be fundamentally
fucked due to the way pushing objects (you enter the window's tile) and
pulling objects (you cannot reach the other side of the window, ever)
works. Maybe someone else will manage it
The drop_item arg is now the loc placed, not the child of the loc or whatever.
Removed a few lines of items being placed into themselves, on themselves, into other things manually, into their users, etc.
Cleans up the fix for MoMMI recharger silliness.
This took about 2 hours of non-stop manual searches.
