No, I don't know how to manually fix conflicts on a PR, and this doesn't
make me wanna figure out how it's done
Fuck you too for not even trying when you were working on Endgame @N3X15
Also thanks for fucking up my PR by stealth-merging a fix @Comic
Because Baystation has finally gotten around to it, and because the code
looked simple, I decided to get my hands on porting a system that allows
up to define base_turfs. As a bonus, it also defines them per Z-level.
So if you wanted, you could have a space station, and a Z-level on a
map-spanning asteroid, and then an away mission on land, all in the same
file
Note that you can modify it mid-round via a DEBUG flag verb, it will
however only affect destroyed turfs (it won't change space, which I
suppose is intentional)
Tested were destroying walls and floors and even dropping a bomb in the
middle of Medbay
Not tested were more finicky conditions like the Singularity or
buildmode. I simply replaced all ChangeTurf() instructions that pointed
to space, because that is how Baystation implemented it
Only problem with this is that it doesn't work on a per-map basis, so
unless some wizardry is done on that code, it'll be hard to get anything
interesting going with it
Discussions go below. Since this is pure code refactor, I doubt there'll
be much up to debate
- Old PR over at #5192
- Older PR over at #5167
Example picture (with the current code, there would be no lattices over
the sand) :
meteor_hit() is a textbook example of snowflake. What you have here is a
proc linked to a single entity (the small meteor) which shouldn't even
have it (ever since I reworked meteors, small meteors explode) that is
present in FIFTY. FUCKING. FILES.
Since an explosion more than clearly does the damage we want done on
meteor impact, it is more than logical to remove it and lighten our code
of obsolete and obscuranting procs
For the handful of times where it isn't possible to straight up remove
it (immovable rod, dust, small meteor), the code was quickly patched by
making it fire ex_act(2), given that small meteors perform
explosion(src.loc, -1, 1, 3, 4, 0)
Doing it quick and dirty because otherwise it's going to cause conflicts
everywhere
Material datum functionality changed to mimic that of reagents etc. by
using a global datum list and an assoc value list.
Material datums added at the atom level.
starting_materials var added - on New(), the materials in the list are
added to a datum. An empty list generates an empty datum, a null means no
datum.
m_amt, g_amt, and where applicable gold_amt, etc. completely removed,
replaced with starting_materials where applicable.
Fabricators
Fixed a bug with fabricators taking design cost, not shown cost.
Fixed a bug with fabricators taking costs before a design was shown
completable.
Fabricators now transfer the materials they use in the design to the atom
produced's material datum.
Designs are now world-consistent : scanning the same atom will ref the
same design, and scanning an atom with a design will fetch it.
Mechanic fabs now add plastic cost on top of the design, not to it.
Mechanic designs no longer require random extra materials.
Mechanic designs are now material-specific, not type-specific.
Mechanic blueprint uses have been removed, in favour of a consumable
system.
RnD wires moved to the datum system.
Autolathe moved under fabricators. It preserves as much functionality as
possible.
Framework added for plastic costs on mechanic fabs to be toggled, and for
removal of designs to be toggled also.
A lot of code standardising for the way machines handle trying to take money from a user.
All machines can now be set to connect to the accounts database in initialize().
reconnect_database(), connect_account(), and scan_card() have all been moved to the machine level.
Merch computer now reads your equipped ID, not your mind account. Fixes#2854.
All machines getting your ID using get_id_card() now check all your slots, with hands being prioritised over the ID slot.
Removed a pointless human-only proc that was causing befuddlement.
I don't really get this if statement in policetape, but it should be fixed now maybe.
Added a proc for checking if two stacks can merge, used it on coloured cables. Fixes#4156.
Made the welding damage message list the item intensifying the damage. Fixes#4187.
Added Vox exclusion to RIG helmets, removed it from Wiz and Nukeops hardsuits. Fixes#4790, fixes#4756, fixes#4496.
Orebag now only gives borgs a message if it finds ore. Fixes#4150.
Throws something at #4267, hardcode is bad and everyone should feel bad.
BUILDMODE CLICK USED TO CALL IN WORLD EVERY CLICK.
Fun fact: just because you dont use the words "in world" doesn't mean you aren't LOOPING THROUGH THE WORLD EVERY TIME YOU CLICK ON ANYTHING IN BUILD MODE JESUS CHRIST.
Removed update_values(). RIP, shine on you CPU diamond.
Removed get_moles_by_id and get_archived_moles_by_id, all moles are now accessed directly to reduce call cost.
Added set_temperature and set_volume procs which recalc pressure when temperature or pressure change.
Heat_capacity is now a var updated when gases update.
Modified adjust_gas to use set_gas, modified set_gas to alter heat_capacity, total_moles, and pressure as needed.
Moved gas_mixture gas numbers to a list which is connected to a global gas_datum list, like with reagents.
Modified some maths procs to be more sane, added adjust_gas and set_gas to help with processing.
Added a modular system for gas flags - gases can now be marked as fuel and oxidiser with a flag, logged with a flag, scanned with a flag, etc.
Changed scrubbers to use a list of scrubbing gases rather than a set of vars.
Made miners and xenoarch effects more sensible - they now produce gas by ID, not manually.
Made turfs' starting gases into a list, removed turf gas number vars.
Fixes#3517, apparently the stat() for spacepod cells checked that the battery has an object of type cell within it. But since spacepods typecast their cell for specific initialization of a high power cell, the istype(S.battery) check fails if you placed a different type of cell into it. Causing it to instead display no cell detected.
