Files
vgstation13/code/controllers/subsystem/garbage.dm
DamianX 46d93b754c improved a qdel warning message (#28003)
* warning -> stack_trace

* Even better
2020-10-13 00:47:54 +02:00

300 lines
8.1 KiB
Plaintext

#define GC_COLLECTION_TIMEOUT (30 SECONDS)
//#define GC_DEBUG
//#define GC_FINDREF
//#define GC_REFDEBUG
var/datum/subsystem/garbage/SSgarbage
var/soft_dels = 0
/datum/subsystem/garbage
name = "Garbage"
init_order = SS_INIT_GARBAGE
wait = 1 SECONDS
display_order = SS_DISPLAY_GARBAGE
priority = SS_PRIORITY_GARBAGE
flags = SS_BACKGROUND | SS_FIRE_IN_LOBBY
var/list/queue = new
var/del_everything = 0
// To let them know how hardworking am I :^).
var/dels_count = 0
var/hard_dels = 0
#ifdef GC_REFDEBUG
var/list/fakedels = list()
#endif
/datum/subsystem/garbage/New()
NEW_SS_GLOBAL(SSgarbage)
/datum/subsystem/garbage/Shutdown()
if(!ghdel_profiling.len)
world.log << "There were no hard deletions this round."
return
world.log << {"
Deletions this round:
\tQueue length: [queue.len]
\tDeletions count: [dels_count]
\tSoft dels: [soft_dels]
\tHard dels: [hard_dels]
List of hard deletions:"}
for(var/thing in ghdel_profiling)
world.log << "\t[thing] : [ghdel_profiling[thing]]"
world.log << json_encode(list(
"queue" = queue.len,
"dels" = dels_count,
"soft_dels" = soft_dels,
"hard_dels" = hard_dels,
"hd_list" = ghdel_profiling))
..()
/datum/subsystem/garbage/stat_entry()
var/msg = ""
msg += "Q:[queue.len]|TD:[dels_count]|SD:[soft_dels]|HD:[hard_dels]"
if (del_everything)
msg += "|QDEL OFF"
..(msg)
/datum/subsystem/garbage/fire(resumed = FALSE)
var/collectionTimeScope = world.timeofday - GC_COLLECTION_TIMEOUT
if(narsie_cometh)
return //don't even fucking bother, its over.
while(queue.len)
var/refID = queue[1]
var/destroyedAtTime = queue[refID]
if(destroyedAtTime > collectionTimeScope)
break
var/datum/D = locate(refID)
if(D) // Something's still referring to the qdel'd object. del it.
if(isnull(D.gcDestroyed))
removeTrash(refID)
continue
#ifdef GC_FINDREF
FindRef(D)
#endif
#ifdef GC_DEBUG
WARNING("gc process force delete [D.type]")
#endif
if(ismovable(D))
var/atom/movable/AM = D
AM.hard_deleted = 1
else
delete_profile("[D.type]", 1) //This is handled in Del() for movables.
//There's not really a way to make the other kinds of delete profiling work for datums without defining /datum/Del(), but this is the most important one.
#ifdef GC_REFDEBUG
fakedels += D
if(ismovable(D))
delete_profile("[D.type]", 1) //Del() doesn't get called in this case so it's not, in fact, handled for movables
to_chat(world, "<a href='?_src_=vars;Vars=[refID]'>["[D]" || "(Blank name)"]</a>")
#undef GC_REFDEBUG
#else
del D
#endif
removeTrash(refID)
hard_dels++
else
removeTrash(refID)
if(MC_TICK_CHECK) //This pauses the system in addition to checking if it should pause.
state = SS_RUNNING //Don't ACTUALLY pause because that would cause the MC to resume it next tick.
return
#undef GC_COLLECTION_TIMEOUT
#ifdef GC_DEBUG
#undef GC_DEBUG
#endif
/datum/subsystem/garbage/proc/addTrash(const/datum/D)
if(istype(D, /atom) && !istype(D, /atom/movable))
return
if(del_everything)
del(D)
hard_dels++
dels_count++
return
removeTrash("\ref[D]") //This makes sure the new entry is at the end in the event D is using a recycled ref already in the queue.
queue["\ref[D]"] = world.timeofday
/datum/subsystem/garbage/proc/removeTrash(id)
if(queue.Remove(id))
dels_count++
#ifdef GC_FINDREF
/world/loop_checks = 0
/datum/subsystem/garbage/proc/FindRef(datum/D)
to_chat(world, "picnic! searching [D]")
testing("GC: Searching references for [ref(D)] [D] | [D.type]")
if(istype(D, /atom/movable))
var/atom/movable/A = D
if(A.loc != null)
testing("GC: [A] | [A.type] is located in [A.loc] instead of null")
if(A.contents.len)
testing("GC: [A] | [A.type] has contents:")
for(var/atom/B in A.contents)
testing("[B] | [B.type]")
var/found = 0
for(var/atom/R in world)
found += LookForRefs(R, D)
for(var/datum/R)
found += LookForRefs(R, D)
for(var/client/R)
found += LookForRefs(R, D)
found += LookForRefs(world, D)
found += LookForListRefs(global.vars, D, null, "global.vars") //You can't pretend global is a datum like you can with clients and world. It'll compile, but throw completely nonsensical runtimes.
to_chat(world, "we found [found]")
/datum/subsystem/garbage/proc/LookForRefs(var/datum/D, var/datum/targ)
. = 0
var/list/Dvars = D.vars
for(var/V in Dvars)
if(V == "contents" || V == "vars")
continue
var/datum/A = Dvars[V]
if(A == targ)
testing("GC: [A] | [A.type] referenced by [ref(D)] [D] | [D.type], var [V]")
.++
else if(islist(A))
. += LookForListRefs(A, targ, D, V)
/datum/subsystem/garbage/proc/LookForListRefs(var/list/L, var/datum/targ, var/datum/D, var/V, var/list/foundcache = list())
. = 0
//foundcache makes sure each list in a given call to this is only checked once, to prevent infinite loops if two lists reference each other.
//You might think it would be better to keep the cache across all searches for the same datum, but since the in operator takes longer on larger lists, it's much slower.
//Thus we only keep it for one top-level call of LookForListRefs, as that's the minimum required to prevent infinite loops.
if(L in foundcache)
return
foundcache += L
for(var/F in L)
var/G
try
G = L[F] //Some special built-in lists runtime if you try to use them as associative lists.
catch
G = null //It's probably already null if it gets here, but may as well be safe
if(istype(F, /datum))
var/datum/A = F
if(A == targ)
testing("GC: [A] | [A.type] referenced by [D? "[ref(D)] [D] | [D.type]" : "global list"], list [V]")
. += 1
if(istype(G, /datum))
var/datum/A = G
if(A == targ)
testing("GC: [A] | [A.type] referenced by [D? "[ref(D)] [D] | [D.type]" : "global list"], list [V] at key [F]")
. += 1
if(islist(F))
. += LookForListRefs(F, targ, D, "[F] in list [V]", foundcache)
if(islist(G))
. += LookForListRefs(G, targ, D, "[G] in list [V] at key [F]", foundcache)
#undef GC_FINDREF
#endif
/datum/subsystem/garbage/proc/debugqueue(i = 1) //Too lazy to add this to any menus so instead just use proccall
var/mob/user = usr
ASSERT(istype(user))
var/refID = queue[i]
var/datum/D = locate(refID)
to_chat(user, "<a href='?_src_=vars;Vars=[refID]'>["[D]" || "(Blank name)"]</a> at [queue[refID]] ([(world.timeofday - queue[refID]) / 10] seconds ago)")
/client/proc/gc_dump_hdl()
set name = "(GC) Hard Del List"
set desc = "List types that fail to soft del and are hard del()'d by the GC."
set category = "Debug"
var/list/L = list()
L += "<b>Garbage Collector Forced Deletions in this round</b><br>"
for(var/A in ghdel_profiling)
L += "<br>[A] = [ghdel_profiling[A]]"
if(L.len == 1)
to_chat(usr, "No garbage collector deletions this round")
return
usr << browse(jointext(L,""),"window=harddellogs")
/*
* NEVER USE THIS FOR /atom OTHER THAN /atom/movable
* BASE ATOMS CANNOT BE QDEL'D BECAUSE THEIR LOC IS LOCKED.
*/
/proc/qdel(const/datum/D)
if(isnull(D))
return
if(D.being_sent_to_past())
return
if(isnull(SSgarbage))
del(D)
return
if(istype(D, /atom) && !istype(D, /atom/movable))
del(D)
SSgarbage.hard_dels++
SSgarbage.dels_count++
CRASH("qdel() passed object of type [D.type]. qdel() cannot handle unmovable atoms.")
if(isnull(D.gcDestroyed))
// Let our friend know they're about to get fucked up.
D.Destroy()
SSgarbage.addTrash(D)
/datum/proc/Destroy()
SHOULD_CALL_PARENT(TRUE)
gcDestroyed = "Bye, world!"
tag = null
/datum/var/gcDestroyed
/datum/proc/being_sent_to_past()
if(being_sent_to_past)
return 1
/atom/movable/being_sent_to_past()
if(..())
invisibility = 101
setDensity(FALSE)
anchored = 1
timestopped = 1
flags |= INVULNERABLE | TIMELESS
if(loc)
if(ismob(loc))
var/mob/M = loc
M.drop_item(src, force_drop = 1)
forceMove(null)
return 1
/proc/delete_profile(var/type, code = 0)
if(code == 0)
if (!("[type]" in del_profiling))
del_profiling["[type]"] = 0
del_profiling["[type]"] += 1
else if(code == 1)
if (!("[type]" in ghdel_profiling))
ghdel_profiling["[type]"] = 0
ghdel_profiling["[type]"] += 1
else
if (!("[type]" in gdel_profiling))
gdel_profiling["[type]"] = 0
gdel_profiling["[type]"] += 1
soft_dels += 1