From efc2c160450f0333a8f529561c851b32264085c8 Mon Sep 17 00:00:00 2001 From: deathride58 Date: Fri, 22 Feb 2019 23:44:28 -0500 Subject: [PATCH 1/4] makes the roundend notification in irc more verbose --- code/__HELPERS/roundend.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/__HELPERS/roundend.dm b/code/__HELPERS/roundend.dm index c3b7a6bfed..e186bfc2af 100644 --- a/code/__HELPERS/roundend.dm +++ b/code/__HELPERS/roundend.dm @@ -192,7 +192,7 @@ //Set news report and mode result mode.set_round_result() - send2irc("Server", "Round just ended.") + send2irc("Server", "Round of [mode.name] just ended[mode_result == "undefined" ? "." : "with a [mode_result]."] Survival rate: [PERCENT(popcount[POPCOUNT_SURVIVORS]/total_players)]%") if(length(CONFIG_GET(keyed_list/cross_server))) send_news_report() From fbab8b5459c1619468b0d3cddc9134088fdd1db3 Mon Sep 17 00:00:00 2001 From: deathride58 Date: Sat, 23 Feb 2019 02:45:40 -0500 Subject: [PATCH 2/4] nerfs feedback and nerfs the travesty --- code/__HELPERS/roundend.dm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/__HELPERS/roundend.dm b/code/__HELPERS/roundend.dm index e186bfc2af..5ca56ce9e3 100644 --- a/code/__HELPERS/roundend.dm +++ b/code/__HELPERS/roundend.dm @@ -192,7 +192,7 @@ //Set news report and mode result mode.set_round_result() - send2irc("Server", "Round of [mode.name] just ended[mode_result == "undefined" ? "." : "with a [mode_result]."] Survival rate: [PERCENT(popcount[POPCOUNT_SURVIVORS]/total_players)]%") + send2irc("Server", "A round of [mode.name] just ended[mode_result == "undefined" ? "." : "with a [mode_result]."] Survival rate: [PERCENT(popcount[POPCOUNT_SURVIVORS]/GLOB.joined_player_list.len)]%") if(length(CONFIG_GET(keyed_list/cross_server))) send_news_report() @@ -583,4 +583,4 @@ qdel(query_update_everything_ranks) return qdel(query_update_everything_ranks) - qdel(query_check_everything_ranks) \ No newline at end of file + qdel(query_check_everything_ranks) From 08b8b8f30b349821ae7df418fbd99d9d5e5f0940 Mon Sep 17 00:00:00 2001 From: deathride58 Date: Sat, 23 Feb 2019 18:12:23 -0500 Subject: [PATCH 3/4] Fixes zero division errors --- code/__HELPERS/roundend.dm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/code/__HELPERS/roundend.dm b/code/__HELPERS/roundend.dm index 5ca56ce9e3..15ed0a3ea3 100644 --- a/code/__HELPERS/roundend.dm +++ b/code/__HELPERS/roundend.dm @@ -192,7 +192,9 @@ //Set news report and mode result mode.set_round_result() - send2irc("Server", "A round of [mode.name] just ended[mode_result == "undefined" ? "." : "with a [mode_result]."] Survival rate: [PERCENT(popcount[POPCOUNT_SURVIVORS]/GLOB.joined_player_list.len)]%") + var/survival_rate = GLOB.joined_player_list.len ? "PERCENT(popcount[POPCOUNT_SURVIVORS]/GLOB.joined_player_list.len)%" : "there's literally no players" + + send2irc("Server", "A round of [mode.name] just ended[mode_result == "undefined" ? "." : " with a [mode_result]."] Survival rate: [survival_rate]") if(length(CONFIG_GET(keyed_list/cross_server))) send_news_report() From c95f6c31184f7972734934234c5305491b866079 Mon Sep 17 00:00:00 2001 From: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Sat, 23 Feb 2019 22:39:14 -0500 Subject: [PATCH 4/4] nerfs criticism again Co-Authored-By: deathride58 --- code/__HELPERS/roundend.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/__HELPERS/roundend.dm b/code/__HELPERS/roundend.dm index 15ed0a3ea3..99e789b970 100644 --- a/code/__HELPERS/roundend.dm +++ b/code/__HELPERS/roundend.dm @@ -192,7 +192,7 @@ //Set news report and mode result mode.set_round_result() - var/survival_rate = GLOB.joined_player_list.len ? "PERCENT(popcount[POPCOUNT_SURVIVORS]/GLOB.joined_player_list.len)%" : "there's literally no players" + var/survival_rate = GLOB.joined_player_list.len ? "PERCENT(popcount[POPCOUNT_SURVIVORS]/GLOB.joined_player_list.len)%" : "there's literally no player" send2irc("Server", "A round of [mode.name] just ended[mode_result == "undefined" ? "." : " with a [mode_result]."] Survival rate: [survival_rate]")