initial commit - cross reference with 5th port - obviously has compile errors

code/modules/atmospherics/machinery/components/binary_devices/binary_devices.dm

@@ -0,0 +1,34 @@
+/obj/machinery/atmospherics/components/binary
+	icon = 'icons/obj/atmospherics/components/binary_devices.dmi'
+	dir = SOUTH
+	initialize_directions = SOUTH|NORTH
+	use_power = 1
+	device_type = BINARY
+
+/obj/machinery/atmospherics/components/binary/SetInitDirections()
+	switch(dir)
+		if(NORTH)
+			initialize_directions = NORTH|SOUTH
+		if(SOUTH)
+			initialize_directions = NORTH|SOUTH
+		if(EAST)
+			initialize_directions = EAST|WEST
+		if(WEST)
+			initialize_directions = EAST|WEST
+/*
+Iconnery
+*/
+/obj/machinery/atmospherics/components/binary/hide(intact)
+	update_icon()
+
+	..(intact)
+/*
+Housekeeping and pipe network stuff
+*/
+
+/obj/machinery/atmospherics/components/binary/atmosinit()
+	var/node2_connect = dir
+	var/node1_connect = turn(dir, 180)
+
+	var/list/node_connects = list(node1_connect, node2_connect)
+	..(node_connects)

code/modules/atmospherics/machinery/components/binary_devices/circulator.dm

@@ -0,0 +1,70 @@
+//node2, air2, network2 correspond to input
+//node1, air1, network1 correspond to output
+
+
+/obj/machinery/atmospherics/components/binary/circulator
+	name = "circulator/heat exchanger"
+	desc = "A gas circulator pump and heat exchanger."
+	icon_state = "circ1-off"
+
+	var/side = CIRC_LEFT
+	var/status = 0
+
+	var/last_pressure_delta = 0
+
+	anchored = 1
+	density = 1
+
+	var/global/const/CIRC_LEFT = 1
+	var/global/const/CIRC_RIGHT = 2
+
+
+/obj/machinery/atmospherics/components/binary/circulator/proc/return_transfer_air()
+
+	var/datum/gas_mixture/air1 = AIR1
+	var/datum/gas_mixture/air2 = AIR2
+
+	var/output_starting_pressure = air1.return_pressure()
+	var/input_starting_pressure = air2.return_pressure()
+
+	if(output_starting_pressure >= input_starting_pressure-10)
+		//Need at least 10 KPa difference to overcome friction in the mechanism
+		last_pressure_delta = 0
+		return null
+
+	//Calculate necessary moles to transfer using PV = nRT
+	if(air2.temperature>0)
+		var/pressure_delta = (input_starting_pressure - output_starting_pressure)/2
+
+		var/transfer_moles = pressure_delta*air1.volume/(air2.temperature * R_IDEAL_GAS_EQUATION)
+
+		last_pressure_delta = pressure_delta
+
+		//world << "pressure_delta = [pressure_delta]; transfer_moles = [transfer_moles];"
+
+		//Actually transfer the gas
+		var/datum/gas_mixture/removed = air2.remove(transfer_moles)
+
+		update_parents()
+
+		return removed
+
+	else
+		last_pressure_delta = 0
+
+/obj/machinery/atmospherics/components/binary/circulator/process_atmos()
+	..()
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/circulator/update_icon()
+	if(stat & (BROKEN|NOPOWER))
+		icon_state = "circ[side]-p"
+	else if(last_pressure_delta > 0)
+		if(last_pressure_delta > ONE_ATMOSPHERE)
+			icon_state = "circ[side]-run"
+		else
+			icon_state = "circ[side]-slow"
+	else
+		icon_state = "circ[side]-off"
+
+	return 1

code/modules/atmospherics/machinery/components/binary_devices/dp_vent_pump.dm

@@ -0,0 +1,198 @@
+/*
+Acts like a normal vent, but has an input AND output.
+*/
+#define EXT_BOUND	1
+#define INPUT_MIN	2
+#define OUTPUT_MAX	4
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump
+	icon = 'icons/obj/atmospherics/components/unary_devices.dmi' //We reuse the normal vent icons!
+	icon_state = "dpvent_map"
+
+	//node2 is output port
+	//node1 is input port
+
+	name = "dual-port air vent"
+	desc = "Has a valve and pump attached to it. There are two ports."
+
+	level = 1
+	var/frequency = 0
+	var/id = null
+	var/datum/radio_frequency/radio_connection
+
+	var/on = 0
+	var/pump_direction = 1 //0 = siphoning, 1 = releasing
+
+	var/external_pressure_bound = ONE_ATMOSPHERE
+	var/input_pressure_min = 0
+	var/output_pressure_max = 0
+
+	var/pressure_checks = EXT_BOUND
+	//EXT_BOUND: Do not pass external_pressure_bound
+	//INPUT_MIN: Do not pass input_pressure_min
+	//OUTPUT_MAX: Do not pass output_pressure_max
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/Destroy()
+	if(SSradio)
+		SSradio.remove_object(src, frequency)
+	return ..()
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/high_volume
+	name = "large dual-port air vent"
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/high_volume/New()
+	..()
+	var/datum/gas_mixture/air1 = AIR1
+	var/datum/gas_mixture/air2 = AIR2
+	air1.volume = 1000
+	air2.volume = 1000
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/update_icon_nopipes()
+	cut_overlays()
+	if(showpipe)
+		add_overlay(getpipeimage('icons/obj/atmospherics/components/unary_devices.dmi', "dpvent_cap"))
+
+	if(!on || stat & (NOPOWER|BROKEN))
+		icon_state = "vent_off"
+		return
+
+	if(pump_direction)
+		icon_state = "vent_out"
+	else
+		icon_state = "vent_in"
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/process_atmos()
+	..()
+
+	if(!on)
+		return 0
+	var/datum/gas_mixture/air1 = AIR1
+	var/datum/gas_mixture/air2 = AIR2
+
+	var/datum/gas_mixture/environment = loc.return_air()
+	var/environment_pressure = environment.return_pressure()
+
+	if(pump_direction) //input -> external
+		var/pressure_delta = 10000
+
+		if(pressure_checks&EXT_BOUND)
+			pressure_delta = min(pressure_delta, (external_pressure_bound - environment_pressure))
+		if(pressure_checks&INPUT_MIN)
+			pressure_delta = min(pressure_delta, (air1.return_pressure() - input_pressure_min))
+
+		if(pressure_delta > 0)
+			if(air1.temperature > 0)
+				var/transfer_moles = pressure_delta*environment.volume/(air1.temperature * R_IDEAL_GAS_EQUATION)
+
+				var/datum/gas_mixture/removed = air1.remove(transfer_moles)
+
+				loc.assume_air(removed)
+				air_update_turf()
+
+				var/datum/pipeline/parent1 = PARENT1
+				parent1.update = 1
+
+	else //external -> output
+		var/pressure_delta = 10000
+
+		if(pressure_checks&EXT_BOUND)
+			pressure_delta = min(pressure_delta, (environment_pressure - external_pressure_bound))
+		if(pressure_checks&INPUT_MIN)
+			pressure_delta = min(pressure_delta, (output_pressure_max - air2.return_pressure()))
+
+		if(pressure_delta > 0)
+			if(environment.temperature > 0)
+				var/transfer_moles = pressure_delta*air2.volume/(environment.temperature * R_IDEAL_GAS_EQUATION)
+
+				var/datum/gas_mixture/removed = loc.remove_air(transfer_moles)
+
+				air2.merge(removed)
+				air_update_turf()
+
+				var/datum/pipeline/parent2 = PARENT2
+				parent2.update = 1
+
+	return 1
+
+	//Radio remote control
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/proc/set_frequency(new_frequency)
+	SSradio.remove_object(src, frequency)
+	frequency = new_frequency
+	if(frequency)
+		radio_connection = SSradio.add_object(src, frequency, filter = RADIO_ATMOSIA)
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/proc/broadcast_status()
+	if(!radio_connection)
+		return 0
+
+	var/datum/signal/signal = new
+	signal.transmission_method = 1 //radio signal
+	signal.source = src
+
+	signal.data = list(
+		"tag" = id,
+		"device" = "ADVP",
+		"power" = on,
+		"direction" = pump_direction?("release"):("siphon"),
+		"checks" = pressure_checks,
+		"input" = input_pressure_min,
+		"output" = output_pressure_max,
+		"external" = external_pressure_bound,
+		"sigtype" = "status"
+	)
+	radio_connection.post_signal(src, signal, filter = RADIO_ATMOSIA)
+
+	return 1
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/atmosinit()
+	..()
+	if(frequency)
+		set_frequency(frequency)
+	broadcast_status()
+
+/obj/machinery/atmospherics/components/binary/dp_vent_pump/receive_signal(datum/signal/signal)
+
+	if(!signal.data["tag"] || (signal.data["tag"] != id) || (signal.data["sigtype"]!="command"))
+		return 0
+	if("power" in signal.data)
+		on = text2num(signal.data["power"])
+
+	if("power_toggle" in signal.data)
+		on = !on
+
+	if("set_direction" in signal.data)
+		pump_direction = text2num(signal.data["set_direction"])
+
+	if("checks" in signal.data)
+		pressure_checks = text2num(signal.data["checks"])
+
+	if("purge" in signal.data)
+		pressure_checks &= ~1
+		pump_direction = 0
+
+	if("stabalize" in signal.data)
+		pressure_checks |= 1
+		pump_direction = 1
+
+	if("set_input_pressure" in signal.data)
+		input_pressure_min = Clamp(text2num(signal.data["set_input_pressure"]),0,ONE_ATMOSPHERE*50)
+
+	if("set_output_pressure" in signal.data)
+		output_pressure_max = Clamp(text2num(signal.data["set_output_pressure"]),0,ONE_ATMOSPHERE*50)
+
+	if("set_external_pressure" in signal.data)
+		external_pressure_bound = Clamp(text2num(signal.data["set_external_pressure"]),0,ONE_ATMOSPHERE*50)
+
+	if("status" in signal.data)
+		spawn(2)
+			broadcast_status()
+		return //do not update_icon
+	//if(signal.data["tag"])
+	spawn(2)
+		broadcast_status()
+	update_icon()
+
+#undef EXT_BOUND
+#undef INPUT_MIN
+#undef OUTPUT_MAX

code/modules/atmospherics/machinery/components/binary_devices/passive_gate.dm

@@ -0,0 +1,175 @@
+/*
+
+Passive gate is similar to the regular pump except:
+* It doesn't require power
+* Can not transfer low pressure to higher pressure (so it's more like a valve where you can control the flow)
+
+*/
+
+/obj/machinery/atmospherics/components/binary/passive_gate
+	icon_state = "passgate_map"
+
+	name = "passive gate"
+	desc = "A one-way air valve that does not require power."
+
+	can_unwrench = 1
+
+	var/on = 0
+	var/target_pressure = ONE_ATMOSPHERE
+
+	var/frequency = 0
+	var/id = null
+	var/datum/radio_frequency/radio_connection
+
+/obj/machinery/atmospherics/components/binary/passive_gate/Destroy()
+	if(SSradio)
+		SSradio.remove_object(src,frequency)
+	return ..()
+
+/obj/machinery/atmospherics/components/binary/passive_gate/update_icon_nopipes()
+	if(!on)
+		icon_state = "passgate_off"
+		cut_overlays()
+		return
+
+	add_overlay(getpipeimage('icons/obj/atmospherics/components/binary_devices.dmi', "passgate_on"))
+
+/obj/machinery/atmospherics/components/binary/passive_gate/process_atmos()
+	..()
+	if(!on)
+		return 0
+
+	var/datum/gas_mixture/air1 = AIR1
+	var/datum/gas_mixture/air2 = AIR2
+
+	var/output_starting_pressure = air2.return_pressure()
+	var/input_starting_pressure = air1.return_pressure()
+
+	if(output_starting_pressure >= min(target_pressure,input_starting_pressure-10))
+		//No need to pump gas if target is already reached or input pressure is too low
+		//Need at least 10 KPa difference to overcome friction in the mechanism
+		return 1
+
+	//Calculate necessary moles to transfer using PV = nRT
+	if((air1.total_moles() > 0) && (air1.temperature>0))
+		var/pressure_delta = min(target_pressure - output_starting_pressure, (input_starting_pressure - output_starting_pressure)/2)
+		//Can not have a pressure delta that would cause output_pressure > input_pressure
+
+		var/transfer_moles = pressure_delta*air2.volume/(air1.temperature * R_IDEAL_GAS_EQUATION)
+
+		//Actually transfer the gas
+		var/datum/gas_mixture/removed = air1.remove(transfer_moles)
+		air2.merge(removed)
+
+		update_parents()
+
+
+//Radio remote control
+
+/obj/machinery/atmospherics/components/binary/passive_gate/proc/set_frequency(new_frequency)
+	SSradio.remove_object(src, frequency)
+	frequency = new_frequency
+	if(frequency)
+		radio_connection = SSradio.add_object(src, frequency, filter = RADIO_ATMOSIA)
+
+/obj/machinery/atmospherics/components/binary/passive_gate/proc/broadcast_status()
+	if(!radio_connection)
+		return 0
+
+	var/datum/signal/signal = new
+	signal.transmission_method = 1 //radio signal
+	signal.source = src
+
+	signal.data = list(
+		"tag" = id,
+		"device" = "AGP",
+		"power" = on,
+		"target_output" = target_pressure,
+		"sigtype" = "status"
+	)
+
+	radio_connection.post_signal(src, signal, filter = RADIO_ATMOSIA)
+
+	return 1
+
+/obj/machinery/atmospherics/components/binary/passive_gate/ui_interact(mob/user, ui_key = "main", datum/tgui/ui = null, force_open = 0, \
+																		datum/tgui/master_ui = null, datum/ui_state/state = default_state)
+	ui = SStgui.try_update_ui(user, src, ui_key, ui, force_open)
+	if(!ui)
+		ui = new(user, src, ui_key, "atmos_pump", name, 335, 115, master_ui, state)
+		ui.open()
+
+/obj/machinery/atmospherics/components/binary/passive_gate/ui_data()
+	var/data = list()
+	data["on"] = on
+	data["pressure"] = round(target_pressure)
+	data["max_pressure"] = round(MAX_OUTPUT_PRESSURE)
+	return data
+
+/obj/machinery/atmospherics/components/binary/passive_gate/ui_act(action, params)
+	if(..())
+		return
+	switch(action)
+		if("power")
+			on = !on
+			investigate_log("was turned [on ? "on" : "off"] by [key_name(usr)]", "atmos")
+			. = TRUE
+		if("pressure")
+			var/pressure = params["pressure"]
+			if(pressure == "max")
+				pressure = MAX_OUTPUT_PRESSURE
+				. = TRUE
+			else if(pressure == "input")
+				pressure = input("New output pressure (0-[MAX_OUTPUT_PRESSURE] kPa):", name, target_pressure) as num|null
+				if(!isnull(pressure) || !..())
+					. = TRUE
+			else if(text2num(pressure) != null)
+				pressure = text2num(pressure)
+				. = TRUE
+			if(.)
+				target_pressure = Clamp(pressure, 0, MAX_OUTPUT_PRESSURE)
+				investigate_log("was set to [target_pressure] kPa by [key_name(usr)]", "atmos")
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/passive_gate/atmosinit()
+	..()
+	if(frequency)
+		set_frequency(frequency)
+
+/obj/machinery/atmospherics/components/binary/passive_gate/receive_signal(datum/signal/signal)
+	if(!signal.data["tag"] || (signal.data["tag"] != id) || (signal.data["sigtype"]!="command"))
+		return 0
+
+	var/old_on = on //for logging
+
+	if("power" in signal.data)
+		on = text2num(signal.data["power"])
+
+	if("power_toggle" in signal.data)
+		on = !on
+
+	if("set_output_pressure" in signal.data)
+		target_pressure = Clamp(text2num(signal.data["set_output_pressure"]),0,ONE_ATMOSPHERE*50)
+
+	if(on != old_on)
+		investigate_log("was turned [on ? "on" : "off"] by a remote signal", "atmos")
+
+	if("status" in signal.data)
+		broadcast_status()
+		return
+
+	broadcast_status()
+	update_icon()
+	return
+
+/obj/machinery/atmospherics/components/binary/passive_gate/power_change()
+	..()
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/passive_gate/can_unwrench(mob/user)
+	if(..())
+		if(on)
+			user << "<span class='warning'>You cannot unwrench this [src], turn it off first!</span>"
+		else
+			return 1
+

code/modules/atmospherics/machinery/components/binary_devices/pump.dm

@@ -0,0 +1,182 @@
+/*
+Every cycle, the pump uses the air in air_in to try and make air_out the perfect pressure.
+
+node1, air1, network1 correspond to input
+node2, air2, network2 correspond to output
+
+Thus, the two variables affect pump operation are set in New():
+	air1.volume
+		This is the volume of gas available to the pump that may be transfered to the output
+	air2.volume
+		Higher quantities of this cause more air to be perfected later
+			but overall network volume is also increased as this increases...
+*/
+
+/obj/machinery/atmospherics/components/binary/pump
+	icon_state = "pump_map"
+	name = "gas pump"
+	desc = "A pump that moves gas by pressure."
+
+	can_unwrench = 1
+
+	var/on = 0
+	var/target_pressure = ONE_ATMOSPHERE
+
+	var/frequency = 0
+	var/id = null
+	var/datum/radio_frequency/radio_connection
+
+/obj/machinery/atmospherics/components/binary/pump/on
+	on = 1
+
+/obj/machinery/atmospherics/components/binary/pump/Destroy()
+	if(SSradio)
+		SSradio.remove_object(src,frequency)
+	if(radio_connection)
+		radio_connection = null
+	return ..()
+
+/obj/machinery/atmospherics/components/binary/pump/update_icon_nopipes()
+	if(stat & NOPOWER)
+		icon_state = "pump_off"
+		return
+
+	icon_state = "pump_[on?"on":"off"]"
+
+/obj/machinery/atmospherics/components/binary/pump/process_atmos()
+//	..()
+	if(stat & (NOPOWER|BROKEN))
+		return 0
+	if(!on)
+		return 0
+
+	var/datum/gas_mixture/air1 = AIR1
+	var/datum/gas_mixture/air2 = AIR2
+
+	var/output_starting_pressure = air2.return_pressure()
+
+	if((target_pressure - output_starting_pressure) < 0.01)
+		//No need to pump gas if target is already reached!
+		return 1
+
+	//Calculate necessary moles to transfer using PV=nRT
+	if((air1.total_moles() > 0) && (air1.temperature>0))
+		var/pressure_delta = target_pressure - output_starting_pressure
+		var/transfer_moles = pressure_delta*air2.volume/(air1.temperature * R_IDEAL_GAS_EQUATION)
+
+		//Actually transfer the gas
+		var/datum/gas_mixture/removed = air1.remove(transfer_moles)
+		air2.merge(removed)
+
+		update_parents()
+
+	return 1
+
+//Radio remote control
+/obj/machinery/atmospherics/components/binary/pump/proc/set_frequency(new_frequency)
+	SSradio.remove_object(src, frequency)
+	frequency = new_frequency
+	if(frequency)
+		radio_connection = SSradio.add_object(src, frequency, filter = RADIO_ATMOSIA)
+
+/obj/machinery/atmospherics/components/binary/pump/proc/broadcast_status()
+	if(!radio_connection)
+		return 0
+
+	var/datum/signal/signal = new
+	signal.transmission_method = 1 //radio signal
+	signal.source = src
+
+	signal.data = list(
+		"tag" = id,
+		"device" = "AGP",
+		"power" = on,
+		"target_output" = target_pressure,
+		"sigtype" = "status"
+	)
+
+	radio_connection.post_signal(src, signal, filter = RADIO_ATMOSIA)
+
+	return 1
+
+/obj/machinery/atmospherics/components/binary/pump/ui_interact(mob/user, ui_key = "main", datum/tgui/ui = null, force_open = 0, \
+																datum/tgui/master_ui = null, datum/ui_state/state = default_state)
+	ui = SStgui.try_update_ui(user, src, ui_key, ui, force_open)
+	if(!ui)
+		ui = new(user, src, ui_key, "atmos_pump", name, 335, 115, master_ui, state)
+		ui.open()
+
+/obj/machinery/atmospherics/components/binary/pump/ui_data()
+	var/data = list()
+	data["on"] = on
+	data["pressure"] = round(target_pressure)
+	data["max_pressure"] = round(MAX_OUTPUT_PRESSURE)
+	return data
+
+/obj/machinery/atmospherics/components/binary/pump/ui_act(action, params)
+	if(..())
+		return
+	switch(action)
+		if("power")
+			on = !on
+			investigate_log("was turned [on ? "on" : "off"] by [key_name(usr)]", "atmos")
+			. = TRUE
+		if("pressure")
+			var/pressure = params["pressure"]
+			if(pressure == "max")
+				pressure = MAX_OUTPUT_PRESSURE
+				. = TRUE
+			else if(pressure == "input")
+				pressure = input("New output pressure (0-[MAX_OUTPUT_PRESSURE] kPa):", name, target_pressure) as num|null
+				if(!isnull(pressure) && !..())
+					. = TRUE
+			else if(text2num(pressure) != null)
+				pressure = text2num(pressure)
+				. = TRUE
+			if(.)
+				target_pressure = Clamp(pressure, 0, MAX_OUTPUT_PRESSURE)
+				investigate_log("was set to [target_pressure] kPa by [key_name(usr)]", "atmos")
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/pump/atmosinit()
+	..()
+	if(frequency)
+		set_frequency(frequency)
+
+/obj/machinery/atmospherics/components/binary/pump/receive_signal(datum/signal/signal)
+	if(!signal.data["tag"] || (signal.data["tag"] != id) || (signal.data["sigtype"]!="command"))
+		return 0
+
+	var/old_on = on //for logging
+
+	if("power" in signal.data)
+		on = text2num(signal.data["power"])
+
+	if("power_toggle" in signal.data)
+		on = !on
+
+	if("set_output_pressure" in signal.data)
+		target_pressure = Clamp(text2num(signal.data["set_output_pressure"]),0,ONE_ATMOSPHERE*50)
+
+	if(on != old_on)
+		investigate_log("was turned [on ? "on" : "off"] by a remote signal", "atmos")
+
+	if("status" in signal.data)
+		broadcast_status()
+		return
+
+	broadcast_status()
+	update_icon()
+	return
+
+/obj/machinery/atmospherics/components/binary/pump/power_change()
+	..()
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/pump/can_unwrench(mob/user)
+	if(..())
+		if(!(stat & NOPOWER) && on)
+			user << "<span class='warning'>You cannot unwrench this [src], turn it off first!</span>"
+		else
+			return 1
+

code/modules/atmospherics/machinery/components/binary_devices/valve.dm

@@ -0,0 +1,72 @@
+/*
+It's like a regular ol' straight pipe, but you can turn it on and off.
+*/
+
+/obj/machinery/atmospherics/components/binary/valve
+	icon_state = "mvalve_map"
+	name = "manual valve"
+	desc = "A pipe valve"
+
+	can_unwrench = 1
+
+	var/frequency = 0
+	var/id = null
+
+	var/open = 0
+	var/valve_type = "m" //lets us have a nice, clean, OOP update_icon_nopipes()
+
+/obj/machinery/atmospherics/components/binary/valve/open
+	open = 1
+
+/obj/machinery/atmospherics/components/binary/valve/update_icon_nopipes(animation = 0)
+	normalize_dir()
+	if(animation)
+		flick("[valve_type]valve_[open][!open]",src)
+	icon_state = "[valve_type]valve_[open?"on":"off"]"
+
+/obj/machinery/atmospherics/components/binary/valve/proc/open()
+	open = 1
+	update_icon_nopipes()
+	update_parents()
+	var/datum/pipeline/parent1 = PARENT1
+	parent1.reconcile_air()
+	investigate_log("was opened by [usr ? key_name(usr) : "a remote signal"]", "atmos")
+
+/obj/machinery/atmospherics/components/binary/valve/proc/close()
+	open = 0
+	update_icon_nopipes()
+	investigate_log("was closed by [usr ? key_name(usr) : "a remote signal"]", "atmos")
+
+/obj/machinery/atmospherics/components/binary/valve/proc/normalize_dir()
+	if(dir==SOUTH)
+		setDir(NORTH)
+	else if(dir==WEST)
+		setDir(EAST)
+
+/obj/machinery/atmospherics/components/binary/valve/attack_ai(mob/user)
+	return
+
+/obj/machinery/atmospherics/components/binary/valve/attack_hand(mob/user)
+	add_fingerprint(usr)
+	update_icon_nopipes(1)
+	sleep(10)
+	if(open)
+		close()
+		return
+	open()
+
+/obj/machinery/atmospherics/components/binary/valve/digital		// can be controlled by AI
+	name = "digital valve"
+	desc = "A digitally controlled valve."
+	icon_state = "dvalve_map"
+	valve_type = "d"
+
+/obj/machinery/atmospherics/components/binary/valve/digital/attack_ai(mob/user)
+	return src.attack_hand(user)
+
+/obj/machinery/atmospherics/components/binary/valve/digital/update_icon_nopipes(animation)
+	if(stat & NOPOWER)
+		normalize_dir()
+		icon_state = "dvalve_nopower"
+		return
+	..()

code/modules/atmospherics/machinery/components/binary_devices/volume_pump.dm

@@ -0,0 +1,178 @@
+/*
+Every cycle, the pump uses the air in air_in to try and make air_out the perfect pressure.
+
+node1, air1, network1 correspond to input
+node2, air2, network2 correspond to output
+
+Thus, the two variables affect pump operation are set in New():
+	air1.volume
+		This is the volume of gas available to the pump that may be transfered to the output
+	air2.volume
+		Higher quantities of this cause more air to be perfected later
+			but overall network volume is also increased as this increases...
+*/
+
+/obj/machinery/atmospherics/components/binary/volume_pump
+	icon_state = "volpump_map"
+	name = "volumetric gas pump"
+	desc = "A pump that moves gas by volume."
+
+	can_unwrench = 1
+
+	var/on = 0
+	var/transfer_rate = MAX_TRANSFER_RATE
+
+	var/frequency = 0
+	var/id = null
+	var/datum/radio_frequency/radio_connection
+
+/obj/machinery/atmospherics/components/binary/volume_pump/Destroy()
+	if(SSradio)
+		SSradio.remove_object(src,frequency)
+	return ..()
+
+/obj/machinery/atmospherics/components/binary/volume_pump/on
+	on = 1
+
+/obj/machinery/atmospherics/components/binary/volume_pump/update_icon_nopipes()
+	if(stat & NOPOWER)
+		icon_state = "volpump_off"
+		return
+
+	icon_state = "volpump_[on?"on":"off"]"
+
+/obj/machinery/atmospherics/components/binary/volume_pump/process_atmos()
+//	..()
+	if(stat & (NOPOWER|BROKEN))
+		return
+	if(!on)
+		return 0
+
+	var/datum/gas_mixture/air1 = AIR1
+	var/datum/gas_mixture/air2 = AIR2
+
+// Pump mechanism just won't do anything if the pressure is too high/too low
+
+	var/input_starting_pressure = air1.return_pressure()
+	var/output_starting_pressure = air2.return_pressure()
+
+	if((input_starting_pressure < 0.01) || (output_starting_pressure > 9000))
+		return 1
+
+	var/transfer_ratio = min(1, transfer_rate/air1.volume)
+
+	var/datum/gas_mixture/removed = air1.remove_ratio(transfer_ratio)
+
+	air2.merge(removed)
+
+	update_parents()
+
+	return 1
+
+/obj/machinery/atmospherics/components/binary/volume_pump/proc/set_frequency(new_frequency)
+	SSradio.remove_object(src, frequency)
+	frequency = new_frequency
+	if(frequency)
+		radio_connection = SSradio.add_object(src, frequency)
+
+/obj/machinery/atmospherics/components/binary/volume_pump/proc/broadcast_status()
+	if(!radio_connection)
+		return 0
+
+	var/datum/signal/signal = new
+	signal.transmission_method = 1 //radio signal
+	signal.source = src
+
+	signal.data = list(
+		"tag" = id,
+		"device" = "APV",
+		"power" = on,
+		"transfer_rate" = transfer_rate,
+		"sigtype" = "status"
+	)
+	radio_connection.post_signal(src, signal)
+
+	return 1
+
+/obj/machinery/atmospherics/components/binary/volume_pump/ui_interact(mob/user, ui_key = "main", datum/tgui/ui = null, force_open = 0, \
+																		datum/tgui/master_ui = null, datum/ui_state/state = default_state)
+	ui = SStgui.try_update_ui(user, src, ui_key, ui, force_open)
+	if(!ui)
+		ui = new(user, src, ui_key, "atmos_pump", name, 310, 115, master_ui, state)
+		ui.open()
+
+/obj/machinery/atmospherics/components/binary/volume_pump/ui_data()
+	var/data = list()
+	data["on"] = on
+	data["rate"] = round(transfer_rate)
+	data["max_rate"] = round(MAX_TRANSFER_RATE)
+	return data
+
+/obj/machinery/atmospherics/components/binary/volume_pump/atmosinit()
+	..()
+
+	set_frequency(frequency)
+
+/obj/machinery/atmospherics/components/binary/volume_pump/ui_act(action, params)
+	if(..())
+		return
+	switch(action)
+		if("power")
+			on = !on
+			investigate_log("was turned [on ? "on" : "off"] by [key_name(usr)]", "atmos")
+			. = TRUE
+		if("rate")
+			var/rate = params["rate"]
+			if(rate == "max")
+				rate = MAX_TRANSFER_RATE
+				. = TRUE
+			else if(rate == "input")
+				rate = input("New transfer rate (0-[MAX_TRANSFER_RATE] L/s):", name, transfer_rate) as num|null
+				if(!isnull(rate) && !..())
+					. = TRUE
+			else if(text2num(rate) != null)
+				rate = text2num(rate)
+				. = TRUE
+			if(.)
+				transfer_rate = Clamp(rate, 0, MAX_TRANSFER_RATE)
+				investigate_log("was set to [transfer_rate] L/s by [key_name(usr)]", "atmos")
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/volume_pump/receive_signal(datum/signal/signal)
+	if(!signal.data["tag"] || (signal.data["tag"] != id) || (signal.data["sigtype"]!="command"))
+		return 0
+
+	var/old_on = on //for logging
+
+	if("power" in signal.data)
+		on = text2num(signal.data["power"])
+
+	if("power_toggle" in signal.data)
+		on = !on
+
+	if("set_transfer_rate" in signal.data)
+		var/datum/gas_mixture/air1 = AIR1
+		transfer_rate = Clamp(text2num(signal.data["set_transfer_rate"]),0,air1.volume)
+
+	if(on != old_on)
+		investigate_log("was turned [on ? "on" : "off"] by a remote signal", "atmos")
+
+	if("status" in signal.data)
+		broadcast_status()
+		return //do not update_icon
+
+	broadcast_status()
+	update_icon()
+	return
+
+/obj/machinery/atmospherics/components/binary/volume_pump/power_change()
+	..()
+	update_icon()
+
+/obj/machinery/atmospherics/components/binary/volume_pump/can_unwrench(mob/user)
+	if(..())
+		if(!(stat & NOPOWER) && on)
+			user << "<span class='warning'>You cannot unwrench this [src], turn it off first!</span>"
+		else
+			return 1
+