From 3709992b460e36c636eb7df77ac865dde14b1fb1 Mon Sep 17 00:00:00 2001 From: kevinz000 <2003111+kevinz000@users.noreply.github.com> Date: Mon, 24 Feb 2020 14:07:58 -0700 Subject: [PATCH 1/3] Update reagent_containers.dm --- code/modules/reagents/reagent_containers.dm | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/code/modules/reagents/reagent_containers.dm b/code/modules/reagents/reagent_containers.dm index c178aad717..2fd2d3a361 100644 --- a/code/modules/reagents/reagent_containers.dm +++ b/code/modules/reagents/reagent_containers.dm @@ -123,28 +123,35 @@ if(thrown) reagents.total_volume *= rand(5,10) * 0.1 //Not all of it makes contact with the target var/mob/M = target - var/R + var/R = reagents.log_list() target.visible_message("[M] has been splashed with something!", \ "[M] has been splashed with something!") - for(var/datum/reagent/A in reagents.reagent_list) - R += "[A.type] ([A.volume])," - + var/turf/TT = get_turf(target) + var/throwerstring if(thrownby) log_combat(thrownby, M, "splashed", R) + var/turf/AT = get_turf(thrownby) + throwerstring = " THROWN BY [key_name(thrownby)] at [AT] (AREACOORD(AT)]" + log_reagent("SPLASH: [src] mob SplashReagents() onto [key_name(target)] at [TT] ([AREACOORD(TT)])[throwerstring] - [R]) + reagents.reaction(target, TOUCH) else if(bartender_check(target) && thrown) visible_message("[src] lands onto the [target.name] without spilling a single drop.") transform = initial(transform) addtimer(CALLBACK(src, .proc/ForceResetRotation), 1) - return - else if(isturf(target) && reagents.reagent_list.len && thrownby) log_combat(thrownby, target, "splashed (thrown) [english_list(reagents.reagent_list)]", "in [AREACOORD(target)]") log_game("[key_name(thrownby)] splashed (thrown) [english_list(reagents.reagent_list)] on [target] in [AREACOORD(target)].") message_admins("[ADMIN_LOOKUPFLW(thrownby)] splashed (thrown) [english_list(reagents.reagent_list)] on [target] in [ADMIN_VERBOSEJMP(target)].") + var/turf/T = get_turf(target) + var/throwerstring + if(thrownby) + var/turf/AT = get_turf(thrownby) + throwerstring = " THROWN BY [key_name(thrownby)] at [AREACOORD(AT])" + log_reagent("SPLASH - [src] object SplashReagents() onto [target] at [TT] ([AREACOORD(TT)])[throwerstring] - [reagents.log_list()]") visible_message("[src] spills its contents all over [target].") reagents.reaction(target, TOUCH) if(QDELETED(src)) From c6a041894677284acfb9cb156259ec046609afa3 Mon Sep 17 00:00:00 2001 From: kevinz000 <2003111+kevinz000@users.noreply.github.com> Date: Mon, 24 Feb 2020 14:10:53 -0700 Subject: [PATCH 2/3] Update reagent_containers.dm --- code/modules/reagents/reagent_containers.dm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/modules/reagents/reagent_containers.dm b/code/modules/reagents/reagent_containers.dm index 2fd2d3a361..614aeb7b38 100644 --- a/code/modules/reagents/reagent_containers.dm +++ b/code/modules/reagents/reagent_containers.dm @@ -128,7 +128,7 @@ "[M] has been splashed with something!") var/turf/TT = get_turf(target) var/throwerstring - if(thrownby) + if(thrownby && thrown) log_combat(thrownby, M, "splashed", R) var/turf/AT = get_turf(thrownby) throwerstring = " THROWN BY [key_name(thrownby)] at [AT] (AREACOORD(AT)]" @@ -148,7 +148,7 @@ message_admins("[ADMIN_LOOKUPFLW(thrownby)] splashed (thrown) [english_list(reagents.reagent_list)] on [target] in [ADMIN_VERBOSEJMP(target)].") var/turf/T = get_turf(target) var/throwerstring - if(thrownby) + if(thrownby && thrown) var/turf/AT = get_turf(thrownby) throwerstring = " THROWN BY [key_name(thrownby)] at [AREACOORD(AT])" log_reagent("SPLASH - [src] object SplashReagents() onto [target] at [TT] ([AREACOORD(TT)])[throwerstring] - [reagents.log_list()]") From 23aa38a381fdde4c56c23841742b73bcf8d26a94 Mon Sep 17 00:00:00 2001 From: kevinz000 <2003111+kevinz000@users.noreply.github.com> Date: Mon, 24 Feb 2020 14:17:48 -0700 Subject: [PATCH 3/3] Update reagent_containers.dm --- code/modules/reagents/reagent_containers.dm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/code/modules/reagents/reagent_containers.dm b/code/modules/reagents/reagent_containers.dm index 614aeb7b38..e5e428ffdd 100644 --- a/code/modules/reagents/reagent_containers.dm +++ b/code/modules/reagents/reagent_containers.dm @@ -67,7 +67,6 @@ else amount_per_transfer_from_this = possible_transfer_amounts[1] to_chat(user, "[src]'s transfer amount is now [amount_per_transfer_from_this] units.") - return /obj/item/reagent_containers/attack(mob/M, mob/user, def_zone) if(user.a_intent == INTENT_HARM) @@ -132,8 +131,7 @@ log_combat(thrownby, M, "splashed", R) var/turf/AT = get_turf(thrownby) throwerstring = " THROWN BY [key_name(thrownby)] at [AT] (AREACOORD(AT)]" - log_reagent("SPLASH: [src] mob SplashReagents() onto [key_name(target)] at [TT] ([AREACOORD(TT)])[throwerstring] - [R]) - + log_reagent("SPLASH: [src] mob SplashReagents() onto [key_name(target)] at [TT] ([AREACOORD(TT)])[throwerstring] - [R]") reagents.reaction(target, TOUCH) else if(bartender_check(target) && thrown)