Apply suggestions from code review

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
Trilbyspaceclone
2020-07-07 13:47:56 -04:00
committed by GitHub
parent 4e1817d2be
commit 49b0d38112
3 changed files with 5 additions and 11 deletions
@@ -45,7 +45,7 @@
projectile_type = /obj/item/projectile/magic/locker
//Spell book ammo casing
/obj/item/ammo_casing/magic/book/book
/obj/item/ammo_casing/magic/book
projectile_type = /obj/item/projectile/magic/spellcard/book
/obj/item/ammo_casing/magic/book/spark
@@ -19,19 +19,12 @@
return
..()
/obj/item/gun/magic/wand/book/afterattack(atom/target, mob/living/user)
if(charges == 0)
shoot_with_empty_chamber(user)
return
if(target == user)
to_chat(user, "The book has [charges] pages\s remaining.</span>")
else
. = ..()
update_icon()
/obj/item/gun/magic/wand/book/zap_self(mob/living/user)
to_chat(user, "The book has [charges] pages\s remaining.</span>")
/obj/item/gun/magic/wand/book/attackby(obj/item/S, mob/living/user, params)
if(!istype(S, /obj/item/paper))
return
return ..()
if(charges < max_charges)
charges++
recharge_newshot()
@@ -41,6 +41,7 @@
/obj/item/projectile/magic/spellcard/book/heal
damage = 0
nodamage = TRUE
/obj/item/projectile/magic/spellcard/book/heal/on_hit(atom/target, blocked = FALSE)
. = ..()