From c3f4dba33d521d23e0b8c8808fff4b99fdcf81ed Mon Sep 17 00:00:00 2001 From: CitadelStationBot Date: Sat, 27 May 2017 20:56:20 -0500 Subject: [PATCH 1/2] Custom emotes no longer replace the pronouns --- code/datums/emotes.dm | 9 +++++++++ code/datums/emotes.dm.rej | 10 ++++++++++ code/modules/mob/living/emote.dm | 3 +++ 3 files changed, 22 insertions(+) create mode 100644 code/datums/emotes.dm.rej diff --git a/code/datums/emotes.dm b/code/datums/emotes.dm index 9f2753dfee..47f3ccbe4f 100644 --- a/code/datums/emotes.dm +++ b/code/datums/emotes.dm @@ -61,6 +61,15 @@ user.visible_message(msg) log_emote("[key_name(user)] : [msg]") +/datum/emote/proc/replace_pronoun(mob/user, message) + if(findtext(message, "their")) + message = replacetext(message, "their", user.p_their()) + if(findtext(message, "them")) + message = replacetext(message, "them", user.p_them()) + if(findtext(message, "%s")) + message = replacetext(message, "%s", user.p_s()) + return message + /datum/emote/proc/select_message_type(mob/user) . = message if(!muzzle_ignore && user.is_muzzled() && emote_type == EMOTE_AUDIBLE) diff --git a/code/datums/emotes.dm.rej b/code/datums/emotes.dm.rej new file mode 100644 index 0000000000..b0f0f50adc --- /dev/null +++ b/code/datums/emotes.dm.rej @@ -0,0 +1,10 @@ +diff a/code/datums/emotes.dm b/code/datums/emotes.dm (rejected hunks) +@@ -35,6 +35,8 @@ + if(params && message_param) + msg = select_param(user, params) + ++ msg = replace_pronoun(user, msg) ++ + var/mob/living/L = user + for(var/obj/item/weapon/implant/I in L.implants) + I.trigger(key, L) diff --git a/code/modules/mob/living/emote.dm b/code/modules/mob/living/emote.dm index cacd433fec..a0aa88779b 100644 --- a/code/modules/mob/living/emote.dm +++ b/code/modules/mob/living/emote.dm @@ -420,6 +420,9 @@ message = null emote_type = EMOTE_VISIBLE +/datum/emote/living/custom/replace_pronoun(mob/user, message) + return message + /datum/emote/living/help key = "help" From 5f74de6bdf3084fbafaedb7bde77aa8638e6d107 Mon Sep 17 00:00:00 2001 From: LetterJay Date: Mon, 5 Jun 2017 23:12:15 -0500 Subject: [PATCH 2/2] cleanup --- code/datums/emotes.dm | 2 ++ code/datums/emotes.dm.rej | 10 ---------- 2 files changed, 2 insertions(+), 10 deletions(-) delete mode 100644 code/datums/emotes.dm.rej diff --git a/code/datums/emotes.dm b/code/datums/emotes.dm index 47f3ccbe4f..d82e691622 100644 --- a/code/datums/emotes.dm +++ b/code/datums/emotes.dm @@ -38,6 +38,8 @@ if(findtext(msg, "%s")) msg = replacetext(msg, "%s", user.p_s()) + msg = replace_pronoun(user, msg) + var/mob/living/L = user for(var/obj/item/weapon/implant/I in L.implants) I.trigger(key, L) diff --git a/code/datums/emotes.dm.rej b/code/datums/emotes.dm.rej deleted file mode 100644 index b0f0f50adc..0000000000 --- a/code/datums/emotes.dm.rej +++ /dev/null @@ -1,10 +0,0 @@ -diff a/code/datums/emotes.dm b/code/datums/emotes.dm (rejected hunks) -@@ -35,6 +35,8 @@ - if(params && message_param) - msg = select_param(user, params) - -+ msg = replace_pronoun(user, msg) -+ - var/mob/living/L = user - for(var/obj/item/weapon/implant/I in L.implants) - I.trigger(key, L)