Replaces a bunch of mob loops with hopefully better ones

code/game/machinery/camera/camera.dm

@@ -97,11 +97,12 @@
 							GLOB.cameranet.addCamera(src)
 						emped = 0 //Resets the consecutive EMP count
 						addtimer(CALLBACK(src, .proc/cancelCameraAlarm), 100)
-			for(var/mob/O in GLOB.mob_list)
-				if (O.client && O.client.eye == src)
-					O.unset_machine()
-					O.reset_perspective(null)
-					to_chat(O, "The screen bursts into static.")
+			for(var/i in GLOB.player_list)
+				var/mob/M = i
+				if (M.client.eye == src)
+					M.unset_machine()
+					M.reset_perspective(null)
+					to_chat(M, "The screen bursts into static.")
 			..()
 
 /obj/machinery/camera/tesla_act(var/power)//EMP proof upgrade also makes it tesla immune

code/game/machinery/camera/motion.dm

@@ -50,7 +50,8 @@
 
 /obj/machinery/camera/proc/cancelAlarm()
 	if (detectTime == -1)
-		for (var/mob/living/silicon/aiPlayer in GLOB.player_list)
+		for (var/i in GLOB.silicon_mobs)
+			var/mob/living/silicon/aiPlayer = i
 			if (status)
 				aiPlayer.cancelAlarm("Motion", get_area(src), src)
 	detectTime = 0
@@ -69,4 +70,4 @@
 	// Motion cameras outside of an "ai monitored" area will use this to detect stuff.
 	if (!area_motion)
 		if(isliving(AM))
-			newTarget(AM)
+			newTarget(AM)

code/game/machinery/camera/tracking.dm

@@ -1,3 +1,4 @@
+<<<<<<< HEAD
 /mob/living/silicon/ai/proc/get_camera_list()
 
 	track.cameras.Cut()
@@ -170,3 +171,173 @@
 				if (sorttext(a.c_tag, b.c_tag) < 0)
 					L.Swap(j, j + 1)
 	return L
+=======
+/mob/living/silicon/ai/proc/get_camera_list()
+
+	track.cameras.Cut()
+
+	if(src.stat == DEAD)
+		return
+
+	var/list/L = list()
+	for (var/obj/machinery/camera/C in GLOB.cameranet.cameras)
+		L.Add(C)
+
+	camera_sort(L)
+
+	var/list/T = list()
+
+	for (var/obj/machinery/camera/C in L)
+		var/list/tempnetwork = C.network&src.network
+		if (tempnetwork.len)
+			T[text("[][]", C.c_tag, (C.can_use() ? null : " (Deactivated)"))] = C
+
+	track.cameras = T
+	return T
+
+
+/mob/living/silicon/ai/proc/ai_camera_list(camera)
+	if (!camera)
+		return 0
+
+	var/obj/machinery/camera/C = track.cameras[camera]
+	src.eyeobj.setLoc(C)
+
+	return
+
+/datum/trackable
+	var/list/names = list()
+	var/list/namecounts = list()
+	var/list/humans = list()
+	var/list/others = list()
+	var/list/cameras = list()
+
+/mob/living/silicon/ai/proc/trackable_mobs()
+
+	track.names.Cut()
+	track.namecounts.Cut()
+	track.humans.Cut()
+	track.others.Cut()
+
+	if(usr.stat == DEAD)
+		return list()
+
+	for(var/i in GLOB.mob_living_list)
+		var/mob/living/L = i
+		if(!L.can_track(usr))
+			continue
+
+		var/name = L.name
+		while(name in track.names)
+			track.namecounts[name]++
+			name = text("[] ([])", name, track.namecounts[name])
+		track.names.Add(name)
+		track.namecounts[name] = 1
+
+		if(ishuman(L))
+			track.humans[name] = L
+		else
+			track.others[name] = L
+
+	var/list/targets = sortList(track.humans) + sortList(track.others)
+
+	return targets
+
+/mob/living/silicon/ai/verb/ai_camera_track(target_name in trackable_mobs())
+	set name = "track"
+	set hidden = 1 //Don't display it on the verb lists. This verb exists purely so you can type "track Oldman Robustin" and follow his ass
+
+	if(!target_name)
+		return
+
+	var/mob/target = (isnull(track.humans[target_name]) ? track.others[target_name] : track.humans[target_name])
+
+	ai_actual_track(target)
+
+/mob/living/silicon/ai/proc/ai_actual_track(mob/living/target)
+	if(!istype(target))
+		return
+	var/mob/living/silicon/ai/U = usr
+
+	U.cameraFollow = target
+	U.tracking = 1
+
+	if(!target || !target.can_track(usr))
+		to_chat(U, "<span class='warning'>Target is not near any active cameras.</span>")
+		U.cameraFollow = null
+		return
+
+	to_chat(U, "<span class='notice'>Now tracking [target.get_visible_name()] on camera.</span>")
+
+	var/cameraticks = 0
+	spawn(0)
+		while(U.cameraFollow == target)
+			if(U.cameraFollow == null)
+				return
+
+			if(!target.can_track(usr))
+				U.tracking = 1
+				if(!cameraticks)
+					to_chat(U, "<span class='warning'>Target is not near any active cameras. Attempting to reacquire...</span>")
+				cameraticks++
+				if(cameraticks > 9)
+					U.cameraFollow = null
+					to_chat(U, "<span class='warning'>Unable to reacquire, cancelling track...</span>")
+					tracking = 0
+					return
+				else
+					sleep(10)
+					continue
+
+			else
+				cameraticks = 0
+				U.tracking = 0
+
+			if(U.eyeobj)
+				U.eyeobj.setLoc(get_turf(target))
+
+			else
+				view_core()
+				U.cameraFollow = null
+				return
+
+			sleep(10)
+
+/proc/near_camera(mob/living/M)
+	if (!isturf(M.loc))
+		return 0
+	if(issilicon(M))
+		var/mob/living/silicon/S = M
+		if((!QDELETED(S.builtInCamera) || !S.builtInCamera.can_use()) && !GLOB.cameranet.checkCameraVis(M))
+			return 0
+	else if(!GLOB.cameranet.checkCameraVis(M))
+		return 0
+	return 1
+
+/obj/machinery/camera/attack_ai(mob/living/silicon/ai/user)
+	if (!istype(user))
+		return
+	if (!src.can_use())
+		return
+	user.eyeobj.setLoc(get_turf(src))
+
+
+/mob/living/silicon/ai/attack_ai(mob/user)
+	ai_camera_list()
+
+/proc/camera_sort(list/L)
+	var/obj/machinery/camera/a
+	var/obj/machinery/camera/b
+
+	for (var/i = L.len, i > 0, i--)
+		for (var/j = 1 to i - 1)
+			a = L[j]
+			b = L[j + 1]
+			if (a.c_tag_order != b.c_tag_order)
+				if (a.c_tag_order > b.c_tag_order)
+					L.Swap(j, j + 1)
+			else
+				if (sorttext(a.c_tag, b.c_tag) < 0)
+					L.Swap(j, j + 1)
+	return L
+>>>>>>> 39375d5... Replaces a bunch of mob loops with hopefully better ones (#32786)

code/game/machinery/computer/crew.dm

@@ -150,7 +150,7 @@ GLOBAL_DATUM_INIT(crewmonitor, /datum/crewmonitor, new)
 			var/pos_y
 			var/life_status
 
-			for(var/mob/living/carbon/human/H in GLOB.mob_list)
+			for(var/mob/living/carbon/human/H in GLOB.carbon_list)
 				// Check if their z-level is correct and if they are wearing a uniform.
 				// Accept H.z==0 as well in case the mob is inside an object.
 				if ((H.z == 0 || H.z == z) && istype(H.w_uniform, /obj/item/clothing/under))

code/game/machinery/computer/medical.dm

@@ -173,7 +173,7 @@
 					dat += "<a href='?src=[REF(src)];screen=1'>Back</a>"
 					dat += "<br><b>Medical Robots:</b>"
 					var/bdat = null
-					for(var/mob/living/simple_animal/bot/medbot/M in GLOB.living_mob_list)
+					for(var/mob/living/simple_animal/bot/medbot/M in GLOB.alive_mob_list)
 						if(M.z != src.z)
 							continue	//only find medibots on the same z-level as the computer
 						var/turf/bl = get_turf(M)

code/game/machinery/computer/robot.dm

@@ -37,7 +37,7 @@
 	user.set_machine(src)
 	var/dat
 	var/robots = 0
-	for(var/mob/living/silicon/robot/R in GLOB.mob_list)
+	for(var/mob/living/silicon/robot/R in GLOB.silicon_mobs)
 		if(!can_control(user, R))
 			continue
 		robots++
@@ -75,7 +75,7 @@
 		dat += "<BR>"
 
 	var/drones = 0
-	for(var/mob/living/simple_animal/drone/D in GLOB.mob_list)
+	for(var/mob/living/simple_animal/drone/D in GLOB.drones_list)
 		if(D.hacked)
 			continue
 		drones++

code/game/machinery/computer/security.dm

@@ -699,7 +699,7 @@ What a mess.*/
 								if("released")
 									active2.fields["criminal"] = "Discharged"
 							investigate_log("[active1.fields["name"]] has been set from [old_field] to [active2.fields["criminal"]] by [usr.name] ([usr.key]).", INVESTIGATE_RECORDS)
-							for(var/mob/living/carbon/human/H in GLOB.mob_list) //thanks for forcing me to do this, whoever wrote this shitty records system
+							for(var/mob/living/carbon/human/H in GLOB.carbon_list)
 								H.sec_hud_set_security_status()
 					if("Delete Record (Security) Execute")
 						investigate_log("[usr.name] ([usr.key]) has deleted the security records for [active1.fields["name"]].", INVESTIGATE_RECORDS)