From 0933ce3829d2331829a8651e0eb21619e8351d50 Mon Sep 17 00:00:00 2001
From: Poojawa <Poojawamanthing@gmail.com>
Date: Sat, 29 Sep 2018 21:53:04 -0500
Subject: [PATCH 1/3] Someone on tg told me I didn't need overlays

smh
---
 code/modules/atmospherics/machinery/airalarm.dm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/code/modules/atmospherics/machinery/airalarm.dm b/code/modules/atmospherics/machinery/airalarm.dm
index 3d0ad0ebb1..cee4f43656 100644
--- a/code/modules/atmospherics/machinery/airalarm.dm
+++ b/code/modules/atmospherics/machinery/airalarm.dm
@@ -196,19 +196,19 @@
 /obj/machinery/airalarm/Initialize(mapload, ndir, nbuild)
 	. = ..()
 	wires = new /datum/wires/airalarm(src)
-	
+
 	if(ndir)
 		setDir(ndir)
-		
+
 	if(nbuild)
 		buildstage = 0
 		panel_open = TRUE
 		pixel_x = (dir & 3)? 0 : (dir == 4 ? -24 : 24)
 		pixel_y = (dir & 3)? (dir == 1 ? -24 : 24) : 0
-		
+
 	if(name == initial(name))
 		name = "[get_area_name(src)] Air Alarm"
-		
+
 	power_change()
 	set_frequency(frequency)
 
@@ -217,10 +217,10 @@
 	qdel(wires)
 	wires = null
 	return ..()
-		
+
 /obj/machinery/airalarm/on_construction()
 	..(dir,dir)
-	
+
 /obj/machinery/airalarm/examine(mob/user)
 	. = ..()
 	switch(buildstage)
@@ -626,6 +626,7 @@
 
 /obj/machinery/airalarm/update_icon()
 	set_light(0)
+	cut_overlays()
 	SSvis_overlays.remove_vis_overlay(src, managed_vis_overlays)
 	if(stat & NOPOWER)
 		icon_state = "alarm0"
@@ -650,14 +651,17 @@
 	var/area/A = get_area(src)
 	switch(max(danger_level, A.atmosalm))
 		if(0)
+			add_overlay(AALARM_OVERLAY_GREEN)
 			overlay_state = AALARM_OVERLAY_GREEN
 			light_color = LIGHT_COLOR_GREEN
 			set_light(brightness_on)
 		if(1)
+			add_overlay(AALARM_OVERLAY_WARN)
 			overlay_state = AALARM_OVERLAY_WARN
 			light_color = LIGHT_COLOR_LAVA
 			set_light(brightness_on)
 		if(2)
+			add_overlay(AALARM_OVERLAY_DANGER)
 			overlay_state = AALARM_OVERLAY_DANGER
 			light_color = LIGHT_COLOR_RED
 			set_light(brightness_on)

From f8ebb49462bf16a2c1d1e5349d08974fcc5f7f36 Mon Sep 17 00:00:00 2001
From: Poojawa <Poojawamanthing@gmail.com>
Date: Sat, 29 Sep 2018 21:57:13 -0500
Subject: [PATCH 2/3] Also cleans up shitcode they also told me to fix

---
 .../atmospherics/machinery/airalarm.dm        | 20 +++++--------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/code/modules/atmospherics/machinery/airalarm.dm b/code/modules/atmospherics/machinery/airalarm.dm
index cee4f43656..a37f931cb0 100644
--- a/code/modules/atmospherics/machinery/airalarm.dm
+++ b/code/modules/atmospherics/machinery/airalarm.dm
@@ -218,9 +218,6 @@
 	wires = null
 	return ..()
 
-/obj/machinery/airalarm/on_construction()
-	..(dir,dir)
-
 /obj/machinery/airalarm/examine(mob/user)
 	. = ..()
 	switch(buildstage)
@@ -671,7 +668,7 @@
 
 /obj/machinery/airalarm/process()
 	if((stat & (NOPOWER|BROKEN)) || shorted)
-		return FALSE
+		return
 
 	var/turf/location = get_turf(src)
 	if(!location)
@@ -708,7 +705,7 @@
 		mode = AALARM_MODE_SCRUBBING
 		apply_mode()
 
-	return TRUE
+	return
 
 
 /obj/machinery/airalarm/proc/post_alert(alert_level)
@@ -839,7 +836,6 @@
 		if(src.allowed(usr) && !wires.is_cut(WIRE_IDSCAN))
 			locked = !locked
 			to_chat(user, "<span class='notice'>You [ locked ? "lock" : "unlock"] the air alarm interface.</span>")
-			updateUsrDialog()
 		else
 			to_chat(user, "<span class='danger'>Access denied.</span>")
 	return
@@ -848,10 +844,7 @@
 	..()
 	if(stat & NOPOWER)
 		set_light(0)
-	else
-		set_light(brightness_on)
 	update_icon()
-	return
 
 /obj/machinery/airalarm/emag_act(mob/user)
 	if(obj_flags & EMAGGED)
@@ -861,12 +854,9 @@
 	playsound(src, "sparks", 50, 1)
 
 /obj/machinery/airalarm/obj_break(damage_flag)
-	if(circuit && !(flags_1 & NODECONSTRUCT_1)) //no circuit, no breaking
-		if(!(stat & BROKEN))
-			playsound(loc, 'sound/effects/glassbr3.ogg', 100, 1)
-			stat |= BROKEN
-			update_icon()
-			set_light(0)
+	..()
+	update_icon()
+	set_light(0)
 
 /obj/machinery/airalarm/deconstruct(disassembled = TRUE)
 	if(!(flags_1 & NODECONSTRUCT_1))

From 86cef31a405bfae76ed2ddaf1f1b8ab7e021cca8 Mon Sep 17 00:00:00 2001
From: Poojawa <Poojawa@users.noreply.github.com>
Date: Sat, 29 Sep 2018 22:05:16 -0500
Subject: [PATCH 3/3] Update airalarm.dm

updateUsrDialog() is nice.
---
 code/modules/atmospherics/machinery/airalarm.dm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/code/modules/atmospherics/machinery/airalarm.dm b/code/modules/atmospherics/machinery/airalarm.dm
index a37f931cb0..ddcd8e2d6d 100644
--- a/code/modules/atmospherics/machinery/airalarm.dm
+++ b/code/modules/atmospherics/machinery/airalarm.dm
@@ -835,6 +835,7 @@
 	else
 		if(src.allowed(usr) && !wires.is_cut(WIRE_IDSCAN))
 			locked = !locked
+			updateUsrDialog()
 			to_chat(user, "<span class='notice'>You [ locked ? "lock" : "unlock"] the air alarm interface.</span>")
 		else
 			to_chat(user, "<span class='danger'>Access denied.</span>")