Ports "Removes the absolute istype fest from footsteps" (#12259)

* Ports "Removes the absolute istype fest from footsteps" * Update species.dm
2020-05-18 13:46:22 +02:00
parent 20ac2f26f4
commit 75dec8ce2c
44 changed files with 184 additions and 163 deletions
--- a/code/modules/mob/living/carbon/alien/humanoid/humanoid.dm
+++ b/code/modules/mob/living/carbon/alien/humanoid/humanoid.dm
@@ -25,6 +25,7 @@
 /mob/living/carbon/alien/humanoid/Initialize()
 	AddAbility(new/obj/effect/proc_holder/alien/regurgitate(null))
 	. = ..()
+	AddComponent(/datum/component/footstep, FOOTSTEP_MOB_CLAW, 0.5, -3)

 /mob/living/carbon/alien/humanoid/restrained(ignore_grab)
 	return handcuffed
--- a/code/modules/mob/living/carbon/carbon.dm
+++ b/code/modules/mob/living/carbon/carbon.dm
@@ -22,9 +22,6 @@
 	QDEL_NULL(dna)
 	GLOB.carbon_list -= src

-/mob/living/carbon/initialize_footstep()
-	AddComponent(/datum/component/footstep, 0.6, 2)
-
 /mob/living/carbon/relaymove(mob/user, direction)
 	if(user in src.stomach_contents)
 		if(prob(40))
--- a/code/modules/mob/living/carbon/human/human.dm
+++ b/code/modules/mob/living/carbon/human/human.dm
@@ -26,6 +26,7 @@
 	physiology = new()

 	AddComponent(/datum/component/personal_crafting)
+	AddComponent(/datum/component/footstep, FOOTSTEP_MOB_HUMAN, 1, 2)
 	. = ..()

 	if(CONFIG_GET(flag/disable_stambuffer))
--- a/code/modules/mob/living/carbon/human/physiology.dm
+++ b/code/modules/mob/living/carbon/human/physiology.dm
@@ -25,5 +25,8 @@

 	var/do_after_speed = 1 //Speed mod for do_after. Lower is better. If temporarily adjusting, please only modify using *= and /=, so you don't interrupt other calculations.

+	/// footstep type override for both shoeless and not footstep sounds.
+	var/footstep_type
+
 /datum/physiology/New()
 	armor = new
--- a/code/modules/mob/living/carbon/human/species.dm
+++ b/code/modules/mob/living/carbon/human/species.dm
@@ -332,6 +332,21 @@ GLOBAL_LIST_EMPTY(roundstart_race_names)
 		if(mutant_bodyparts["meat_type"]) //I can't believe it's come to the meat
 			H.type_of_meat = GLOB.meat_types[H.dna.features["meat_type"]]

+		if(H.physiology)
+			if(mutant_bodyparts["taur"])
+				var/datum/sprite_accessory/taur/T = GLOB.taur_list[H.dna.features["taur"]]
+				switch(T?.taur_mode)
+					if(STYLE_HOOF_TAURIC)
+						H.physiology.footstep_type = FOOTSTEP_MOB_SHOE
+					if(STYLE_PAW_TAURIC)
+						H.physiology.footstep_type = FOOTSTEP_MOB_CLAW
+					if(STYLE_SNEK_TAURIC)
+						H.physiology.footstep_type = FOOTSTEP_MOB_CRAWL
+					else
+						H.physiology.footstep_type = null
+			else
+				H.physiology.footstep_type = null
+
 		if(H.client && has_field_of_vision && CONFIG_GET(flag/use_field_of_vision))
 			H.LoadComponent(/datum/component/field_of_vision, H.field_of_vision_type)

--- a/code/modules/mob/living/carbon/monkey/monkey.dm
+++ b/code/modules/mob/living/carbon/monkey/monkey.dm
@@ -45,6 +45,7 @@
 /mob/living/carbon/monkey/ComponentInitialize()
 	. = ..()
 	AddElement(/datum/element/mob_holder, worn_state = "monkey", inv_slots = ITEM_SLOT_HEAD)
+	AddComponent(/datum/component/footstep, FOOTSTEP_MOB_BAREFOOT, 1, 2)


 /mob/living/carbon/monkey/Destroy()
--- a/code/modules/mob/living/living.dm
+++ b/code/modules/mob/living/living.dm
@@ -9,10 +9,6 @@
 		diag_hud.add_to_hud(src)
 	faction += "[REF(src)]"
 	GLOB.mob_living_list += src
-	initialize_footstep()
-
-/mob/living/proc/initialize_footstep()
-	AddComponent(/datum/component/footstep)

 /mob/living/prepare_huds()
 	..()
--- a/code/modules/mob/living/simple_animal/bot/ed209bot.dm
+++ b/code/modules/mob/living/simple_animal/bot/ed209bot.dm
@@ -44,8 +44,6 @@
 	var/cell_type = /obj/item/stock_parts/cell
 	var/vest_type = /obj/item/clothing/suit/armor/vest

-	do_footstep = TRUE
-

 /mob/living/simple_animal/bot/ed209/Initialize(mapload,created_name,created_lasercolor)
 	. = ..()
--- a/code/modules/mob/living/simple_animal/friendly/cat.dm
+++ b/code/modules/mob/living/simple_animal/friendly/cat.dm
@@ -32,7 +32,7 @@
 	gold_core_spawnable = FRIENDLY_SPAWN
 	collar_type = "cat"
 	var/held_icon = "cat2"
-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/pet/cat/Initialize()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/friendly/dog.dm
+++ b/code/modules/mob/living/simple_animal/friendly/dog.dm
@@ -15,7 +15,7 @@
 	turns_per_move = 10
 	var/held_icon = "corgi"

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/pet/dog/ComponentInitialize()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/friendly/farm_animals.dm
+++ b/code/modules/mob/living/simple_animal/friendly/farm_animals.dm
@@ -30,7 +30,7 @@
 	blood_volume = BLOOD_VOLUME_NORMAL
 	var/obj/item/udder/udder = null

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 /mob/living/simple_animal/hostile/retaliate/goat/Initialize()
 	udder = new()
@@ -132,7 +132,7 @@
 	gold_core_spawnable = FRIENDLY_SPAWN
 	blood_volume = BLOOD_VOLUME_NORMAL

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 /mob/living/simple_animal/cow/Initialize()
 	udder = new()
@@ -210,7 +210,7 @@
 	mob_size = MOB_SIZE_TINY
 	gold_core_spawnable = FRIENDLY_SPAWN

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/chick/Initialize()
 	. = ..()
@@ -268,7 +268,7 @@
 	gold_core_spawnable = FRIENDLY_SPAWN
 	var/static/chicken_count = 0

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/chicken/Initialize()
 	. = ..()
@@ -358,6 +358,8 @@
 	gold_core_spawnable = FRIENDLY_SPAWN
 	var/static/kiwi_count = 0

+	footstep_type = FOOTSTEP_MOB_CLAW
+
 /mob/living/simple_animal/kiwi/Destroy()
 	--kiwi_count
 	return ..()
@@ -430,6 +432,8 @@
 	mob_size = MOB_SIZE_TINY
 	gold_core_spawnable = FRIENDLY_SPAWN

+	footstep_type = FOOTSTEP_MOB_CLAW
+
 /mob/living/simple_animal/babyKiwi/Initialize()
 	. = ..()
 	pixel_x = rand(-6, 6)
--- a/code/modules/mob/living/simple_animal/friendly/fox.dm
+++ b/code/modules/mob/living/simple_animal/friendly/fox.dm
@@ -18,7 +18,7 @@
 	response_disarm = "gently pushes aside"
 	response_harm = "kicks"
 	gold_core_spawnable = FRIENDLY_SPAWN
-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/pet/fox/ComponentInitialize()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/friendly/panda.dm
+++ b/code/modules/mob/living/simple_animal/friendly/panda.dm
@@ -17,4 +17,4 @@
 	response_disarm = "gently pushes aside"
 	response_harm = "kicks"
 	gold_core_spawnable = FRIENDLY_SPAWN
-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW
--- a/code/modules/mob/living/simple_animal/friendly/penguin.dm
+++ b/code/modules/mob/living/simple_animal/friendly/penguin.dm
@@ -15,7 +15,7 @@
 	turns_per_move = 10
 	icon = 'icons/mob/penguins.dmi'

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_BAREFOOT

 /mob/living/simple_animal/pet/penguin/emperor
 	name = "Emperor penguin"
--- a/code/modules/mob/living/simple_animal/friendly/sloth.dm
+++ b/code/modules/mob/living/simple_animal/friendly/sloth.dm
@@ -22,7 +22,7 @@
 	maxHealth = 50
 	speed = 10
 	glide_size = 2
-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/pet/fox/ComponentInitialize()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/hostile/alien.dm
+++ b/code/modules/mob/living/simple_animal/hostile/alien.dm
@@ -37,7 +37,9 @@
 	death_sound = 'sound/voice/hiss6.ogg'
 	deathmessage = "lets out a waning guttural screech, green blood bubbling from its maw..."

-	do_footstep = TRUE
+/mob/living/simple_animal/hostile/alien/Initialize()
+	. = ..()
+	AddComponent(/datum/component/footstep, FOOTSTEP_MOB_CLAW)

 /mob/living/simple_animal/hostile/alien/drone
 	name = "alien drone"
--- a/code/modules/mob/living/simple_animal/hostile/bear.dm
+++ b/code/modules/mob/living/simple_animal/hostile/bear.dm
@@ -40,7 +40,7 @@
 	faction = list("russian")
 	gold_core_spawnable = HOSTILE_SPAWN

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 //SPACE BEARS! SQUEEEEEEEE~     OW! FUCK! IT BIT MY HAND OFF!!
 /mob/living/simple_animal/hostile/bear/Hudson
--- a/code/modules/mob/living/simple_animal/hostile/bosses/paperwizard.dm
+++ b/code/modules/mob/living/simple_animal/hostile/bosses/paperwizard.dm
@@ -23,7 +23,7 @@
 	attack_sound = 'sound/hallucinations/growl1.ogg'
 	var/list/copies = list()

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE


 //Summon Ability
--- a/code/modules/mob/living/simple_animal/hostile/dark_wizard.dm
+++ b/code/modules/mob/living/simple_animal/hostile/dark_wizard.dm
@@ -25,7 +25,7 @@
 	turns_per_move = 5
 	gold_core_spawnable = HOSTILE_SPAWN
 	faction = list(ROLE_WIZARD)
-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE
 	weather_immunities = list("lava","ash")
 	minbodytemp = 0
 	maxbodytemp = INFINITY
--- a/code/modules/mob/living/simple_animal/hostile/faithless.dm
+++ b/code/modules/mob/living/simple_animal/hostile/faithless.dm
@@ -36,7 +36,7 @@
 	faction = list("faithless")
 	gold_core_spawnable = HOSTILE_SPAWN

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 /mob/living/simple_animal/hostile/faithless/AttackingTarget()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/hostile/giant_spider.dm
+++ b/code/modules/mob/living/simple_animal/hostile/giant_spider.dm
@@ -49,13 +49,12 @@
 	gold_core_spawnable = HOSTILE_SPAWN
 	see_in_dark = 4
 	lighting_alpha = LIGHTING_PLANE_ALPHA_MOSTLY_VISIBLE
+	footstep_type = FOOTSTEP_MOB_CLAW
 	has_field_of_vision = FALSE // 360° vision.
 	var/playable_spider = FALSE
 	var/datum/action/innate/spider/lay_web/lay_web
 	var/directive = "" //Message passed down to children, to relay the creator's orders

-	do_footstep = TRUE
-
 /mob/living/simple_animal/hostile/poison/giant_spider/Initialize()
 	. = ..()
 	lay_web = new
--- a/code/modules/mob/living/simple_animal/hostile/gorilla/gorilla.dm
+++ b/code/modules/mob/living/simple_animal/hostile/gorilla/gorilla.dm
@@ -39,7 +39,7 @@
 	var/list/gorilla_overlays[GORILLA_TOTAL_LAYERS]
 	var/oogas = 0

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_BAREFOOT

 // Gorillas like to dismember limbs from unconcious mobs.
 // Returns null when the target is not an unconcious carbon mob; a list of limbs (possibly empty) otherwise.
--- a/code/modules/mob/living/simple_animal/hostile/hivebot.dm
+++ b/code/modules/mob/living/simple_animal/hostile/hivebot.dm
@@ -30,7 +30,7 @@
 	loot = list(/obj/effect/decal/cleanable/robot_debris)
 	blood_volume = 0

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/hostile/hivebot/Initialize()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/hostile/jungle/leaper.dm
+++ b/code/modules/mob/living/simple_animal/hostile/jungle/leaper.dm
@@ -27,7 +27,7 @@
 	var/hop_cooldown = 0 //Strictly for player controlled leapers
 	var/projectile_ready = FALSE //Stopping AI leapers from firing whenever they want, and only doing it after a hop has finished instead

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_HEAVY

 /obj/item/projectile/leaper
 	name = "leaper bubble"
--- a/code/modules/mob/living/simple_animal/hostile/jungle/mega_arachnid.dm
+++ b/code/modules/mob/living/simple_animal/hostile/jungle/mega_arachnid.dm
@@ -25,7 +25,7 @@
 	projectilesound = 'sound/weapons/pierce.ogg'
 	alpha = 50

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_CLAW

 /mob/living/simple_animal/hostile/jungle/mega_arachnid/Life()
 	..()
--- a/code/modules/mob/living/simple_animal/hostile/jungle/mook.dm
+++ b/code/modules/mob/living/simple_animal/hostile/jungle/mook.dm
@@ -32,7 +32,7 @@
 	var/attack_state = MOOK_ATTACK_NEUTRAL
 	var/struck_target_leap = FALSE

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_BAREFOOT

 /mob/living/simple_animal/hostile/jungle/mook/CanPass(atom/movable/O)
 	if(istype(O, /mob/living/simple_animal/hostile/jungle/mook))
--- a/code/modules/mob/living/simple_animal/hostile/megafauna/blood_drunk_miner.dm
+++ b/code/modules/mob/living/simple_animal/hostile/megafauna/blood_drunk_miner.dm
@@ -54,7 +54,7 @@ Difficulty: Medium
 	deathmessage = "falls to the ground, decaying into glowing particles."
 	death_sound = "bodyfall"

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_HEAVY

 /mob/living/simple_animal/hostile/megafauna/blood_drunk_miner/guidance
 	guidance = TRUE
--- a/code/modules/mob/living/simple_animal/hostile/megafauna/bubblegum.dm
+++ b/code/modules/mob/living/simple_animal/hostile/megafauna/bubblegum.dm
@@ -55,7 +55,7 @@ Difficulty: Hard
 	deathmessage = "sinks into a pool of blood, fleeing the battle. You've won, for now... "
 	death_sound = 'sound/magic/enter_blood.ogg'

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_HEAVY

 /obj/item/gps/internal/bubblegum
 	icon_state = null
--- a/code/modules/mob/living/simple_animal/hostile/megafauna/drake.dm
+++ b/code/modules/mob/living/simple_animal/hostile/megafauna/drake.dm
@@ -64,7 +64,7 @@ Difficulty: Medium
 	death_sound = 'sound/magic/demon_dies.ogg'
 	var/datum/action/small_sprite/smallsprite = new/datum/action/small_sprite/drake()

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_HEAVY

 /mob/living/simple_animal/hostile/megafauna/dragon/Initialize()
 	smallsprite.Grant(src)
--- a/code/modules/mob/living/simple_animal/hostile/mining_mobs/goliath.dm
+++ b/code/modules/mob/living/simple_animal/hostile/mining_mobs/goliath.dm
@@ -35,7 +35,7 @@
 	var/pre_attack_icon = "Goliath_preattack"
 	loot = list(/obj/item/stack/sheet/animalhide/goliath_hide)

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_HEAVY

 /mob/living/simple_animal/hostile/asteroid/goliath/Life()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/hostile/nanotrasen.dm
+++ b/code/modules/mob/living/simple_animal/hostile/nanotrasen.dm
@@ -31,7 +31,7 @@
 	speak = list("Stop resisting!", "I AM THE LAW!", "Face the wrath of the golden bolt!", "Stop breaking the law, asshole!")
 	search_objects = 1

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE


 /mob/living/simple_animal/hostile/nanotrasen/Aggro()
--- a/code/modules/mob/living/simple_animal/hostile/pirate.dm
+++ b/code/modules/mob/living/simple_animal/hostile/pirate.dm
@@ -43,7 +43,7 @@
 	attack_sound = 'sound/weapons/blade1.ogg'
 	var/obj/effect/light_emitter/red_energy_sword/sord

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 /mob/living/simple_animal/hostile/pirate/melee/space
 	name = "Space Pirate Swashbuckler"
--- a/code/modules/mob/living/simple_animal/hostile/retaliate/clown.dm
+++ b/code/modules/mob/living/simple_animal/hostile/retaliate/clown.dm
@@ -30,6 +30,7 @@
 	minbodytemp = 270
 	maxbodytemp = 370
 	unsuitable_atmos_damage = 10
+	footstep_type = FOOTSTEP_MOB_SHOE
 	var/banana_time = 0 // If there's no time set it won't spawn.
 	var/banana_type = /obj/item/grown/bananapeel
 	var/attack_reagent
--- a/code/modules/mob/living/simple_animal/hostile/retaliate/spaceman.dm
+++ b/code/modules/mob/living/simple_animal/hostile/retaliate/spaceman.dm
@@ -23,9 +23,8 @@
 	obj_damage = 0
 	environment_smash = ENVIRONMENT_SMASH_NONE
 	del_on_death = 0
-	has_field_of_vision = FALSE //Legacy. Also they only have one dir visually.
-
-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE
+	has_field_of_vision = FALSE //Legacy gameplay experience. Also they only have one dir visually.

 /mob/living/simple_animal/hostile/retaliate/nanotrasenpeace //this should be in a different file
 	name = "Nanotrasen Private Security Officer"
--- a/code/modules/mob/living/simple_animal/hostile/russian.dm
+++ b/code/modules/mob/living/simple_animal/hostile/russian.dm
@@ -30,7 +30,7 @@
 	status_flags = CANPUSH
 	del_on_death = 1

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE


 /mob/living/simple_animal/hostile/russian/ranged
--- a/code/modules/mob/living/simple_animal/hostile/skeleton.dm
+++ b/code/modules/mob/living/simple_animal/hostile/skeleton.dm
@@ -36,7 +36,7 @@
 	del_on_death = 1
 	loot = list(/obj/effect/decal/remains/human)

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 /mob/living/simple_animal/hostile/skeleton/eskimo
 	name = "undead eskimo"
--- a/code/modules/mob/living/simple_animal/hostile/syndicate.dm
+++ b/code/modules/mob/living/simple_animal/hostile/syndicate.dm
@@ -50,7 +50,7 @@
 	dodging = TRUE
 	rapid_melee = 2

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 ///////////////Melee////////////

--- a/code/modules/mob/living/simple_animal/hostile/wizard.dm
+++ b/code/modules/mob/living/simple_animal/hostile/wizard.dm
@@ -38,7 +38,7 @@

 	var/next_cast = 0

-	do_footstep = TRUE
+	footstep_type = FOOTSTEP_MOB_SHOE

 /mob/living/simple_animal/hostile/wizard/Initialize()
 	. = ..()
--- a/code/modules/mob/living/simple_animal/simple_animal.dm
+++ b/code/modules/mob/living/simple_animal/simple_animal.dm
@@ -92,7 +92,8 @@

 	var/my_z // I don't want to confuse this with client registered_z

-	var/do_footstep = FALSE
+	///What kind of footstep this mob should have. Null if it shouldn't have any.
+	var/footstep_type

 /mob/living/simple_animal/Initialize()
 	. = ..()
@@ -106,6 +107,8 @@
 	update_simplemob_varspeed()
 	if(dextrous)
 		AddComponent(/datum/component/personal_crafting)
+	if(footstep_type)
+		AddComponent(/datum/component/footstep, footstep_type)

 /mob/living/simple_animal/Destroy()
 	GLOB.simple_animals[AIStatus] -= src
@@ -122,10 +125,6 @@

 	return ..()

-/mob/living/simple_animal/initialize_footstep()
-	if(do_footstep)
-		..()
-
 /mob/living/simple_animal/updatehealth()
 	..()
 	health = clamp(health, 0, maxHealth)
--- a/code/modules/mob/living/simple_animal/slime/slime.dm
+++ b/code/modules/mob/living/simple_animal/slime/slime.dm
@@ -64,8 +64,6 @@
 	var/mutator_used = FALSE //So you can't shove a dozen mutators into a single slime
 	var/force_stasis = FALSE

-	do_footstep = TRUE
-
 	var/static/regex/slime_name_regex = new("\\w+ (baby|adult) slime \\(\\d+\\)")
 	///////////TIME FOR SUBSPECIES

@@ -103,6 +101,7 @@
 	create_reagents(100, NONE, NO_REAGENTS_VALUE)
 	set_colour(new_colour)
 	. = ..()
+	AddComponent(/datum/component/footstep, FOOTSTEP_MOB_SLIME, 7.5)

 /mob/living/simple_animal/slime/Destroy()
 	for (var/A in actions)