From cbc02a8f0b3afec5bc5ca8a032e676dac1c0c1d0 Mon Sep 17 00:00:00 2001 From: Putnam Date: Fri, 17 Apr 2020 18:28:15 -0700 Subject: [PATCH 1/3] fixes a divide-by-zero whoops --- code/datums/radiation_wave.dm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/code/datums/radiation_wave.dm b/code/datums/radiation_wave.dm index 5dce5791c2..298dc4d89f 100644 --- a/code/datums/radiation_wave.dm +++ b/code/datums/radiation_wave.dm @@ -117,10 +117,9 @@ continue contam_atoms += thing var/did_contam = 0 - if(can_contam) + if(can_contam && contam_atoms.len) var/rad_strength = ((strength-RAD_MINIMUM_CONTAMINATION) * RAD_CONTAMINATION_STR_COEFFICIENT)/contam_atoms.len - for(var/k in 1 to contam_atoms.len) - var/atom/thing = contam_atoms[k] + for(var/thing in contam_atoms) thing.AddComponent(/datum/component/radioactive, rad_strength, source) did_contam = 1 return did_contam From 9c4d10a19c6e82e273830227ffa1db3618bae097 Mon Sep 17 00:00:00 2001 From: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Sat, 18 Apr 2020 03:48:03 +0200 Subject: [PATCH 2/3] Update code/datums/radiation_wave.dm --- code/datums/radiation_wave.dm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/code/datums/radiation_wave.dm b/code/datums/radiation_wave.dm index 298dc4d89f..9b225e4f1f 100644 --- a/code/datums/radiation_wave.dm +++ b/code/datums/radiation_wave.dm @@ -119,7 +119,8 @@ var/did_contam = 0 if(can_contam && contam_atoms.len) var/rad_strength = ((strength-RAD_MINIMUM_CONTAMINATION) * RAD_CONTAMINATION_STR_COEFFICIENT)/contam_atoms.len - for(var/thing in contam_atoms) + for(var/A in contam_atoms) + var/atom/thing = A thing.AddComponent(/datum/component/radioactive, rad_strength, source) did_contam = 1 return did_contam From 26594592338c47e1a441bbfe9e87a88f7b472ad3 Mon Sep 17 00:00:00 2001 From: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Sat, 18 Apr 2020 03:48:57 +0200 Subject: [PATCH 3/3] web-editor played me a good prank. --- code/datums/radiation_wave.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/datums/radiation_wave.dm b/code/datums/radiation_wave.dm index 9b225e4f1f..fe018a8761 100644 --- a/code/datums/radiation_wave.dm +++ b/code/datums/radiation_wave.dm @@ -120,7 +120,7 @@ if(can_contam && contam_atoms.len) var/rad_strength = ((strength-RAD_MINIMUM_CONTAMINATION) * RAD_CONTAMINATION_STR_COEFFICIENT)/contam_atoms.len for(var/A in contam_atoms) - var/atom/thing = A + var/atom/thing = A thing.AddComponent(/datum/component/radioactive, rad_strength, source) did_contam = 1 return did_contam