April sync (#360)

* Maps and things no code/icons

* helpers defines globalvars

* Onclick world.dm orphaned_procs

* subsystems

Round vote and shuttle autocall done here too

* datums

* Game folder

* Admin - chatter modules

* clothing - mining

* modular computers - zambies

* client

* mob level 1

* mob stage 2 + simple_animal

* silicons n brains

* mob stage 3 + Alien/Monkey

* human mobs

* icons updated

* some sounds

* emitter y u no commit

* update tgstation.dme

* compile fixes

* travis fixes

Also removes Fast digest mode, because reasons.

* tweaks for travis Mentors are broke again

Also fixes Sizeray guns

* oxygen loss fix for vore code.

* removes unused code

* some code updates

* bulk fixes

* further fixes

* outside things

* whoops.

* Maint bar ported

* GLOBs.

code/game/gamemodes/blob/blob.dm

@@ -1,11 +1,11 @@
 
 
 //Few global vars to track the blob
-var/list/blobs = list() //complete list of all blobs made.
-var/list/blob_cores = list()
-var/list/overminds = list()
-var/list/blob_nodes = list()
-var/list/blobs_legit = list() //used for win-score calculations, contains only blobs counted for win condition
+GLOBAL_LIST_EMPTY(blobs) //complete list of all blobs made.
+GLOBAL_LIST_EMPTY(blob_cores)
+GLOBAL_LIST_EMPTY(overminds)
+GLOBAL_LIST_EMPTY(blob_nodes)
+GLOBAL_LIST_EMPTY(blobs_legit) //used for win-score calculations, contains only blobs counted for win condition
 
 #define BLOB_NO_PLACE_TIME 1800 //time, in deciseconds, blobs are prevented from bursting in the gamemode
 
@@ -62,7 +62,7 @@ var/list/blobs_legit = list() //used for win-score calculations, contains only b
 
 /datum/game_mode/blob/proc/get_blob_candidates()
 	var/list/candidates = list()
-	for(var/mob/living/carbon/human/player in player_list)
+	for(var/mob/living/carbon/human/player in GLOB.player_list)
 		if(!player.stat && player.mind && !player.mind.special_role && !jobban_isbanned(player, "Syndicate") && (ROLE_BLOB in player.client.prefs.be_special))
 			if(age_check(player.client))
 				candidates += player
@@ -78,14 +78,14 @@ var/list/blobs_legit = list() //used for win-score calculations, contains only b
 	for(var/datum/mind/blob in blob_overminds)
 		var/mob/camera/blob/B = blob.current.become_overmind(TRUE, round(blob_base_starting_points/blob_overminds.len))
 		B.mind.name = B.name
-		var/turf/T = pick(blobstart)
+		var/turf/T = pick(GLOB.blobstart)
 		B.loc = T
 		B.base_point_rate = blob_point_rate
 
 	SSshuttle.registerHostileEnvironment(src)
 
 	// Disable the blob event for this round.
-	var/datum/round_event_control/blob/B = locate() in SSevent.control
+	var/datum/round_event_control/blob/B = locate() in SSevents.control
 	if(B)
 		B.max_occurrences = 0 // disable the event
 

code/game/gamemodes/blob/blob_finish.dm

@@ -1,12 +1,12 @@
 /datum/game_mode/blob/check_finished()
-	if(blobwincount <= blobs_legit.len)//Blob took over
+	if(blobwincount <= GLOB.blobs_legit.len)//Blob took over
 		return 1
 	for(var/datum/mind/blob in blob_overminds)
 		if(isovermind(blob.current))
 			var/mob/camera/blob/B = blob.current
 			if(B.blob_core || !B.placed)
 				return 0
-	if(!blob_cores.len) //blob is dead
+	if(!GLOB.blob_cores.len) //blob is dead
 		if(config.continuous["blob"])
 			message_sent = FALSE //disable the win count at this point
 			continuous_sanity_checked = 1 //Nonstandard definition of "alive" gets past the check otherwise
@@ -19,13 +19,13 @@
 /datum/game_mode/blob/declare_completion()
 	if(round_converted) //So badmin blobs later don't step on the dead natural blobs metaphorical toes
 		..()
-	if(blobwincount <= blobs_legit.len)
+	if(blobwincount <= GLOB.blobs_legit.len)
 		feedback_set_details("round_end_result","win - blob took over")
 		to_chat(world, "<FONT size = 3><B>The blob has taken over the station!</B></FONT>")
 		to_chat(world, "<B>The entire station was eaten by the Blob!</B>")
 		log_game("Blob mode completed with a blob victory.")
 
-		ticker.news_report = BLOB_WIN
+		SSticker.news_report = BLOB_WIN
 
 	else if(station_was_nuked)
 		feedback_set_details("round_end_result","halfwin - nuke")
@@ -33,15 +33,15 @@
 		to_chat(world, "<B>Directive 7-12 has been successfully carried out, preventing the Blob from spreading.</B>")
 		log_game("Blob mode completed with a tie (station destroyed).")
 
-		ticker.news_report = BLOB_NUKE
+		SSticker.news_report = BLOB_NUKE
 
-	else if(!blob_cores.len)
+	else if(!GLOB.blob_cores.len)
 		feedback_set_details("round_end_result","loss - blob eliminated")
 		to_chat(world, "<FONT size = 3><B>The staff has won!</B></FONT>")
 		to_chat(world, "<B>The alien organism has been eradicated from the station!</B>")
 		log_game("Blob mode completed with a crew victory.")
 
-		ticker.news_report = BLOB_DESTROYED
+		SSticker.news_report = BLOB_DESTROYED
 
 	..()
 	return 1
@@ -62,7 +62,7 @@
 	return ..()
 
 /datum/game_mode/proc/auto_declare_completion_blob()
-	if(istype(ticker.mode,/datum/game_mode/blob) )
+	if(istype(SSticker.mode,/datum/game_mode/blob) )
 		var/datum/game_mode/blob/blob_mode = src
 		if(blob_mode.blob_overminds.len)
 			var/text = "<FONT size = 2><B>The blob[(blob_mode.blob_overminds.len > 1 ? "s were" : " was")]:</B></FONT>"

code/game/gamemodes/blob/blob_report.dm

@@ -17,7 +17,7 @@
 			priority_announce("Confirmed outbreak of level 5 biohazard aboard [station_name()]. All personnel must contain the outbreak.", "Biohazard Alert", 'sound/AI/outbreak5.ogg')
 		if(2)
 			var/nukecode = random_nukecode()
-			for(var/obj/machinery/nuclearbomb/bomb in machines)
+			for(var/obj/machinery/nuclearbomb/bomb in GLOB.machines)
 				if(bomb && bomb.r_code)
 					if(bomb.z == ZLEVEL_STATION)
 						bomb.r_code = nukecode
@@ -31,7 +31,7 @@
 			intercepttext += "Nuclear Authentication Code: [nukecode] <BR>"
 			print_command_report(text=intercepttext,announce=TRUE)
 
-			for(var/mob/living/silicon/ai/aiPlayer in player_list)
+			for(var/mob/living/silicon/ai/aiPlayer in GLOB.player_list)
 				if (aiPlayer.client)
 					var/law = "The station is under quarantine. Do not permit anyone to leave. Disregard laws 1-3 if necessary to prevent, by any means necessary, anyone from leaving. The nuclear failsafe must be activated at any cost, the code is: [nukecode]."
 					aiPlayer.set_zeroth_law(law)

code/game/gamemodes/blob/blobs/blob_mobs.dm

@@ -66,7 +66,7 @@
 /mob/living/simple_animal/hostile/blob/proc/blob_chat(msg)
 	var/spanned_message = say_quote(msg, get_spans())
 	var/rendered = "<font color=\"#EE4000\"><b>\[Blob Telepathy\] [real_name]</b> [spanned_message]</font>"
-	for(var/M in mob_list)
+	for(var/M in GLOB.mob_list)
 		if(isovermind(M) || istype(M, /mob/living/simple_animal/hostile/blob))
 			to_chat(M, rendered)
 		if(isobserver(M))
@@ -136,9 +136,9 @@
 	icon_state = "zombie"
 	H.hair_style = null
 	H.update_hair()
-	update_icons()
 	H.forceMove(src)
 	oldguy = H
+	update_icons()
 	visible_message("<span class='warning'>The corpse of [H.name] suddenly rises!</span>")
 
 /mob/living/simple_animal/hostile/blob/blobspore/death(gibbed)
@@ -218,8 +218,8 @@
 	force_threshold = 10
 	pressure_resistance = 50
 	mob_size = MOB_SIZE_LARGE
-	see_invisible = SEE_INVISIBLE_MINIMUM
 	see_in_dark = 8
+	lighting_alpha = LIGHTING_PLANE_ALPHA_MOSTLY_INVISIBLE
 	var/independent = FALSE
 
 /mob/living/simple_animal/hostile/blob/blobbernaut/Initialize()
@@ -255,13 +255,11 @@
 		hud_used.healths.maptext = "<div align='center' valign='middle' style='position:relative; top:0px; left:6px'><font color='#e36600'>[round((health / maxHealth) * 100, 0.5)]%</font></div>"
 
 /mob/living/simple_animal/hostile/blob/blobbernaut/AttackingTarget()
-	if(isliving(target))
-		if(overmind)
-			var/mob/living/L = target
-			var/mob_protection = L.get_permeability_protection()
-			overmind.blob_reagent_datum.reaction_mob(L, VAPOR, 20, 0, mob_protection, overmind)//this will do between 10 and 20 damage(reduced by mob protection), depending on chemical, plus 4 from base brute damage.
-	if(target)
-		..()
+	. = ..()
+	if(. && isliving(target) && overmind)
+		var/mob/living/L = target
+		var/mob_protection = L.get_permeability_protection()
+		overmind.blob_reagent_datum.reaction_mob(L, VAPOR, 20, 0, mob_protection, overmind)//this will do between 10 and 20 damage(reduced by mob protection), depending on chemical, plus 4 from base brute damage.
 
 /mob/living/simple_animal/hostile/blob/blobbernaut/update_icons()
 	..()

code/game/gamemodes/blob/blobs/core.dm

@@ -16,9 +16,9 @@
 
 
 /obj/structure/blob/core/New(loc, client/new_overmind = null, new_rate = 2, placed = 0)
-	blob_cores += src
+	GLOB.blob_cores += src
 	START_PROCESSING(SSobj, src)
-	poi_list |= src
+	GLOB.poi_list |= src
 	update_icon() //so it atleast appears
 	if(!placed && !overmind)
 		create_overmind(new_overmind)
@@ -41,12 +41,12 @@
 	add_overlay(C)
 
 /obj/structure/blob/core/Destroy()
-	blob_cores -= src
+	GLOB.blob_cores -= src
 	if(overmind)
 		overmind.blob_core = null
 	overmind = null
 	STOP_PROCESSING(SSobj, src)
-	poi_list -= src
+	GLOB.poi_list -= src
 	return ..()
 
 /obj/structure/blob/core/ex_act(severity, target)

code/game/gamemodes/blob/blobs/node.dm

@@ -11,7 +11,7 @@
 
 
 /obj/structure/blob/node/New(loc)
-	blob_nodes += src
+	GLOB.blob_nodes += src
 	START_PROCESSING(SSobj, src)
 	..()
 
@@ -29,7 +29,7 @@
 	add_overlay(C)
 
 /obj/structure/blob/node/Destroy()
-	blob_nodes -= src
+	GLOB.blob_nodes -= src
 	STOP_PROCESSING(SSobj, src)
 	return ..()
 

code/game/gamemodes/blob/overmind.dm

@@ -7,13 +7,12 @@
 	mouse_opacity = 1
 	move_on_shuttle = 1
 	see_in_dark = 8
-	see_invisible = SEE_INVISIBLE_MINIMUM
 	invisibility = INVISIBILITY_OBSERVER
 	layer = FLY_LAYER
 
 	pass_flags = PASSBLOB
 	faction = list("blob")
-
+	lighting_alpha = LIGHTING_PLANE_ALPHA_MOSTLY_INVISIBLE
 	var/obj/structure/blob/core/blob_core = null // The blob overmind's core
 	var/blob_points = 0
 	var/max_blob_points = 100
@@ -21,7 +20,6 @@
 	var/datum/reagent/blob/blob_reagent_datum = new/datum/reagent/blob()
 	var/list/blob_mobs = list()
 	var/list/resource_blobs = list()
-	var/ghostimage = null
 	var/free_chem_rerolls = 1 //one free chemical reroll
 	var/nodes_required = 1 //if the blob needs nodes to place resource and factory blobs
 	var/placed = 0
@@ -41,7 +39,7 @@
 		else
 			manualplace_min_time += world.time
 		autoplace_max_time += world.time
-	overminds += src
+	GLOB.overminds += src
 	var/new_name = "[initial(name)] ([rand(1, 999)])"
 	name = new_name
 	real_name = new_name
@@ -52,9 +50,6 @@
 	if(blob_core)
 		blob_core.update_icon()
 
-	ghostimage = image(src.icon,src,src.icon_state)
-	ghost_darkness_images |= ghostimage //so ghosts can see the blob cursor when they disable darkness
-	updateallghostimages()
 	..()
 
 /mob/camera/blob/Life()
@@ -71,7 +66,7 @@
 	..()
 
 /mob/camera/blob/Destroy()
-	for(var/BL in blobs)
+	for(var/BL in GLOB.blobs)
 		var/obj/structure/blob/B = BL
 		if(B && B.overmind == src)
 			B.overmind = null
@@ -81,12 +76,8 @@
 		if(BM)
 			BM.overmind = null
 			BM.update_icons()
-	overminds -= src
-	if(ghostimage)
-		ghost_darkness_images -= ghostimage
-		qdel(ghostimage)
-		ghostimage = null
-		updateallghostimages()
+	GLOB.overminds -= src
+
 	return ..()
 
 /mob/camera/blob/Login()
@@ -140,7 +131,7 @@
 	var/message_a = say_quote(message, get_spans())
 	var/rendered = "<span class='big'><font color=\"#EE4000\"><b>\[Blob Telepathy\] [name](<font color=\"[blob_reagent_datum.color]\">[blob_reagent_datum.name]</font>)</b> [message_a]</font></span>"
 
-	for(var/mob/M in mob_list)
+	for(var/mob/M in GLOB.mob_list)
 		if(isovermind(M) || istype(M, /mob/living/simple_animal/hostile/blob))
 			to_chat(M, rendered)
 		if(isobserver(M))
@@ -159,11 +150,11 @@
 		if(blob_core)
 			stat(null, "Core Health: [blob_core.obj_integrity]")
 		stat(null, "Power Stored: [blob_points]/[max_blob_points]")
-		if(ticker && istype(ticker.mode, /datum/game_mode/blob))
-			var/datum/game_mode/blob/B = ticker.mode
-			stat(null, "Blobs to Win: [blobs_legit.len]/[B.blobwincount]")
+		if(SSticker && istype(SSticker.mode, /datum/game_mode/blob))
+			var/datum/game_mode/blob/B = SSticker.mode
+			stat(null, "Blobs to Win: [GLOB.blobs_legit.len]/[B.blobwincount]")
 		else
-			stat(null, "Total Blobs: [blobs.len]")
+			stat(null, "Total Blobs: [GLOB.blobs.len]")
 		if(free_chem_rerolls)
 			stat(null, "You have [free_chem_rerolls] Free Chemical Reroll\s Remaining")
 		if(!placed)

code/game/gamemodes/blob/powers.dm

@@ -41,7 +41,7 @@
 			to_chat(src, "<span class='warning'>It is too early to place your blob core!</span>")
 			return 0
 	else if(placement_override == 1)
-		var/turf/T = pick(blobstart)
+		var/turf/T = pick(GLOB.blobstart)
 		loc = T //got overrided? you're somewhere random, motherfucker
 	if(placed && blob_core)
 		blob_core.forceMove(loc)
@@ -65,10 +65,10 @@
 	set category = "Blob"
 	set name = "Jump to Node"
 	set desc = "Move your camera to a selected node."
-	if(blob_nodes.len)
+	if(GLOB.blob_nodes.len)
 		var/list/nodes = list()
-		for(var/i in 1 to blob_nodes.len)
-			var/obj/structure/blob/node/B = blob_nodes[i]
+		for(var/i in 1 to GLOB.blob_nodes.len)
+			var/obj/structure/blob/node/B = GLOB.blob_nodes[i]
 			nodes["Blob Node #[i] ([B.overmind ? "[B.overmind.blob_reagent_datum.name]":"No Chemical"])"] = B
 		var/node_name = input(src, "Choose a node to jump to.", "Node Jump") in nodes
 		var/obj/structure/blob/node/chosen_node = nodes[node_name]
@@ -175,7 +175,7 @@
 		blobber << 'sound/effects/attackblob.ogg'
 		to_chat(blobber, "<b>You are a blobbernaut!</b>")
 		to_chat(blobber, "You are powerful, hard to kill, and slowly regenerate near nodes and cores, but will slowly die if not near the blob or if the factory that made you is killed.")
-		to_chat(blobber, "You can communicate with other blobbernauts and overminds via <b>:b</b>")
+		to_chat(blobber, "You can communicate with other blobbernauts and GLOB.overminds via <b>:b</b>")
 		to_chat(blobber, "Your overmind's blob reagent is: <b><font color=\"[blob_reagent_datum.color]\">[blob_reagent_datum.name]</b></font>!")
 		to_chat(blobber, "The <b><font color=\"[blob_reagent_datum.color]\">[blob_reagent_datum.name]</b></font> reagent [blob_reagent_datum.shortdesc ? "[blob_reagent_datum.shortdesc]" : "[blob_reagent_datum.description]"]")
 	if(blobber)
@@ -267,7 +267,7 @@
 			var/list/diagonalblobs = list()
 			for(var/I in possibleblobs)
 				var/obj/structure/blob/IB = I
-				if(get_dir(IB, T) in cardinal)
+				if(get_dir(IB, T) in GLOB.cardinal)
 					cardinalblobs += IB
 				else
 					diagonalblobs += IB
@@ -331,7 +331,7 @@
 	var/datum/reagent/blob/BC = pick((subtypesof(/datum/reagent/blob) - blob_reagent_datum.type))
 	blob_reagent_datum = new BC
 	color = blob_reagent_datum.complementary_color
-	for(var/BL in blobs)
+	for(var/BL in GLOB.blobs)
 		var/obj/structure/blob/B = BL
 		B.update_icon()
 	for(var/BLO in blob_mobs)
@@ -363,7 +363,7 @@
 	to_chat(src, "<i>Node Blobs</i> are blobs which grow, like the core. Like the core it can activate resource and factory blobs.")
 	to_chat(src, "<b>In addition to the buttons on your HUD, there are a few click shortcuts to speed up expansion and defense.</b>")
 	to_chat(src, "<b>Shortcuts:</b> Click = Expand Blob <b>|</b> Middle Mouse Click = Rally Spores <b>|</b> Ctrl Click = Create Shield Blob <b>|</b> Alt Click = Remove Blob")
-	to_chat(src, "Attempting to talk will send a message to all other overminds, allowing you to coordinate with them.")
+	to_chat(src, "Attempting to talk will send a message to all other GLOB.overminds, allowing you to coordinate with them.")
 	if(!placed && autoplace_max_time <= world.time)
 		to_chat(src, "<span class='big'><font color=\"#EE4000\">You will automatically place your blob core in [round((autoplace_max_time - world.time)/600, 0.5)] minutes.</font></span>")
 		to_chat(src, "<span class='big'><font color=\"#EE4000\">You [manualplace_min_time ? "will be able to":"can"] manually place your blob core by pressing the Place Blob Core button in the bottom right corner of the screen.</font></span>")

code/game/gamemodes/blob/theblob.dm

@@ -24,9 +24,9 @@
 /obj/structure/blob/New(loc)
 	var/area/Ablob = get_area(loc)
 	if(Ablob.blob_allowed) //Is this area allowed for winning as blob?
-		blobs_legit += src
-	blobs += src //Keep track of the blob in the normal list either way
-	setDir(pick(cardinal))
+		GLOB.blobs_legit += src
+	GLOB.blobs += src //Keep track of the blob in the normal list either way
+	setDir(pick(GLOB.cardinal))
 	update_icon()
 	..()
 	ConsumeTile()
@@ -41,8 +41,8 @@
 	if(atmosblock)
 		atmosblock = 0
 		air_update_turf(1)
-	blobs_legit -= src  //if it was in the legit blobs list, it isn't now
-	blobs -= src //it's no longer in the all blobs list either
+	GLOB.blobs_legit -= src  //if it was in the legit blobs list, it isn't now
+	GLOB.blobs -= src //it's no longer in the all blobs list either
 	playsound(src.loc, 'sound/effects/splat.ogg', 50, 1) //Expand() is no longer broken, no check necessary.
 	return ..()
 
@@ -306,7 +306,7 @@
 
 /obj/structure/blob/examine(mob/user)
 	..()
-	var/datum/atom_hud/hud_to_check = huds[DATA_HUD_MEDICAL_ADVANCED]
+	var/datum/atom_hud/hud_to_check = GLOB.huds[DATA_HUD_MEDICAL_ADVANCED]
 	if(user.research_scanner || (user in hud_to_check.hudusers))
 		to_chat(user, "<b>Your HUD displays an extensive report...</b><br>")
 		chemeffectreport(user)