April sync (#360)

* Maps and things no code/icons

* helpers defines globalvars

* Onclick world.dm orphaned_procs

* subsystems

Round vote and shuttle autocall done here too

* datums

* Game folder

* Admin - chatter modules

* clothing - mining

* modular computers - zambies

* client

* mob level 1

* mob stage 2 + simple_animal

* silicons n brains

* mob stage 3 + Alien/Monkey

* human mobs

* icons updated

* some sounds

* emitter y u no commit

* update tgstation.dme

* compile fixes

* travis fixes

Also removes Fast digest mode, because reasons.

* tweaks for travis Mentors are broke again

Also fixes Sizeray guns

* oxygen loss fix for vore code.

* removes unused code

* some code updates

* bulk fixes

* further fixes

* outside things

* whoops.

* Maint bar ported

* GLOBs.

code/modules/client/verbs/looc.dm

@@ -3,7 +3,7 @@
 	set desc = "Local OOC, seen only by those in view."
 	set category = "OOC"
 
-	if(say_disabled)	//This is here to try to identify lag problems
+	if(GLOB.say_disabled)	//This is here to try to identify lag problems
 		usr << "\red Speech is currently admin-disabled."
 		return
 
@@ -20,10 +20,10 @@
 		return
 
 	if(!holder)
-		if(!ooc_allowed)
+		if(!GLOB.ooc_allowed)
 			src << "\red OOC is globally muted"
 			return
-		if(!dooc_allowed && (mob.stat == DEAD))
+		if(!GLOB.dooc_allowed && (mob.stat == DEAD))
 			usr << "\red OOC for dead mobs has been turned off."
 			return
 		if(prefs.muted & MUTE_OOC)
@@ -43,10 +43,10 @@
 		if(!M.client)
 			continue
 		var/client/C = M.client
-		if (C in admins)
+		if (C in GLOB.admins)
 			continue //they are handled after that
 
-		if (istype(M,/mob/dead/observer))
+		if (isobserver(M))
 			continue //Also handled later.
 
 		if(C.prefs.toggles & CHAT_OOC)
@@ -59,7 +59,7 @@
 //					display_name = holder.fakekey
 			C << "<font color='#6699CC'><span class='ooc'><span class='prefix'>LOOC:</span> <EM>[src.mob.name]:</EM> <span class='message'>[msg]</span></span></font>"
 
-	for(var/client/C in admins)
+	for(var/client/C in GLOB.admins)
 		if(C.prefs.toggles & CHAT_OOC)
 			var/prefix = "(R)LOOC"
 			if (C.mob in heard)
@@ -70,7 +70,7 @@
 		if(!G.client)
 			continue
 		var/client/C = G.client
-		if (C in admins)
+		if (C in GLOB.admins)
 			continue //handled earlier.
 		if(C.prefs.toggles & CHAT_OOC)
 			var/prefix = "(G)LOOC"

code/modules/client/verbs/ooc.dm

@@ -2,7 +2,7 @@
 	set name = "OOC" //Gave this shit a shorter name so you only have to time out "ooc" rather than "ooc message" to use it --NeoFite
 	set category = "OOC"
 
-	if(say_disabled)	//This is here to try to identify lag problems
+	if(GLOB.say_disabled)	//This is here to try to identify lag problems
 		to_chat(usr, "<span class='danger'>Speech is currently admin-disabled.</span>")
 		return
 
@@ -30,10 +30,10 @@
 		return
 
 	if(!holder)
-		if(!ooc_allowed)
+		if(!GLOB.ooc_allowed)
 			to_chat(src, "<span class='danger'>OOC is globally muted.</span>")
 			return
-		if(!dooc_allowed && (mob.stat == DEAD))
+		if(!GLOB.dooc_allowed && (mob.stat == DEAD))
 			to_chat(usr, "<span class='danger'>OOC for dead mobs has been turned off.</span>")
 			return
 		if(prefs.muted & MUTE_OOC)
@@ -57,9 +57,9 @@
 	var/keyname = key
 	if(prefs.unlock_content)
 		if(prefs.toggles & MEMBER_PUBLIC)
-			keyname = "<font color='[prefs.ooccolor ? prefs.ooccolor : normal_ooc_colour]'><img style='width:9px;height:9px;' class=icon src=\ref['icons/member_content.dmi'] iconstate=blag>[keyname]</font>"
+			keyname = "<font color='[prefs.ooccolor ? prefs.ooccolor : GLOB.normal_ooc_colour]'><img style='width:9px;height:9px;' class=icon src=\ref['icons/member_content.dmi'] iconstate=blag>[keyname]</font>"
 
-	for(var/client/C in clients)
+	for(var/client/C in GLOB.clients)
 		if(C.prefs.chat_toggles & CHAT_OOC)
 			if(holder)
 				if(!holder.fakekey || C.holder)
@@ -68,33 +68,33 @@
 					else
 						to_chat(C, "<span class='adminobserverooc'><span class='prefix'>OOC:</span> <EM>[keyname][holder.fakekey ? "/([holder.fakekey])" : ""]:</EM> <span class='message'>[msg]</span></span>")
 				else
-					to_chat(C, "<font color='[normal_ooc_colour]'><span class='ooc'><span class='prefix'>OOC:</span> <EM>[holder.fakekey ? holder.fakekey : key]:</EM> <span class='message'>[msg]</span></span></font>")
+					to_chat(C, "<font color='[GLOB.normal_ooc_colour]'><span class='ooc'><span class='prefix'>OOC:</span> <EM>[holder.fakekey ? holder.fakekey : key]:</EM> <span class='message'>[msg]</span></span></font>")
 			else if(!(key in C.prefs.ignoring))
-				to_chat(C, "<font color='[normal_ooc_colour]'><span class='ooc'><span class='prefix'>OOC:</span> <EM>[keyname]:</EM> <span class='message'>[msg]</span></span></font>")
+				to_chat(C, "<font color='[GLOB.normal_ooc_colour]'><span class='ooc'><span class='prefix'>OOC:</span> <EM>[keyname]:</EM> <span class='message'>[msg]</span></span></font>")
 
 /proc/toggle_ooc(toggle = null)
 	if(toggle != null) //if we're specifically en/disabling ooc
-		if(toggle != ooc_allowed)
-			ooc_allowed = toggle
+		if(toggle != GLOB.ooc_allowed)
+			GLOB.ooc_allowed = toggle
 		else
 			return
 	else //otherwise just toggle it
-		ooc_allowed = !ooc_allowed
-	to_chat(world, "<B>The OOC channel has been globally [ooc_allowed ? "enabled" : "disabled"].</B>")
+		GLOB.ooc_allowed = !GLOB.ooc_allowed
+	to_chat(world, "<B>The OOC channel has been globally [GLOB.ooc_allowed ? "enabled" : "disabled"].</B>")
 
-var/global/normal_ooc_colour = OOC_COLOR
+GLOBAL_VAR_INIT(normal_ooc_colour, OOC_COLOR)
 
 /client/proc/set_ooc(newColor as color)
 	set name = "Set Player OOC Color"
 	set desc = "Modifies player OOC Color"
 	set category = "Fun"
-	normal_ooc_colour = sanitize_ooccolor(newColor)
+	GLOB.normal_ooc_colour = sanitize_ooccolor(newColor)
 
 /client/proc/reset_ooc()
 	set name = "Reset Player OOC Color"
 	set desc = "Returns player OOC Color to default"
 	set category = "Fun"
-	normal_ooc_colour = OOC_COLOR
+	GLOB.normal_ooc_colour = OOC_COLOR
 
 /client/verb/colorooc()
 	set name = "Set Your OOC Color"
@@ -108,7 +108,7 @@ var/global/normal_ooc_colour = OOC_COLOR
 	if(new_ooccolor)
 		prefs.ooccolor = sanitize_ooccolor(new_ooccolor)
 		prefs.save_preferences()
-	feedback_add_details("admin_verb","OC") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
+	feedback_add_details("admin_verb","Set OOC Color") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
 	return
 
 /client/verb/resetcolorooc()
@@ -129,8 +129,8 @@ var/global/normal_ooc_colour = OOC_COLOR
 	set category = "Admin"
 	set desc ="Check the admin notice if it has been set"
 
-	if(admin_notice)
-		to_chat(src, "<span class='boldnotice'>Admin Notice:</span>\n \t [admin_notice]")
+	if(GLOB.admin_notice)
+		to_chat(src, "<span class='boldnotice'>Admin Notice:</span>\n \t [GLOB.admin_notice]")
 	else
 		to_chat(src, "<span class='notice'>There are no admin notices at the moment.</span>")
 
@@ -139,8 +139,8 @@ var/global/normal_ooc_colour = OOC_COLOR
 	set category = "OOC"
 	set desc ="Check the Message of the Day"
 
-	if(join_motd)
-		to_chat(src, "<div class=\"motd\">[join_motd]</div>")
+	if(GLOB.join_motd)
+		to_chat(src, "<div class=\"motd\">[GLOB.join_motd]</div>")
 	else
 		to_chat(src, "<span class='notice'>The Message of the Day has not been set.</span>")
 
@@ -169,7 +169,7 @@ var/global/normal_ooc_colour = OOC_COLOR
 	set category = "OOC"
 	set desc ="Ignore a player's messages on the OOC channel"
 
-	var/selection = input("Please, select a player!", "Ignore", null, null) as null|anything in sortKey(clients)
+	var/selection = input("Please, select a player!", "Ignore", null, null) as null|anything in sortKey(GLOB.clients)
 	if(!selection)
 		return
 	if(selection == src)

code/modules/client/verbs/who.dm

@@ -2,25 +2,25 @@
 	set name = "Who"
 	set category = "OOC"
 
-	var/msg = ""
+	var/msg = "<b>Current Population:</b>\n"
 
 	var/list/Lines = list()
 
-	if(length(admins) > 0)
+	if(length(GLOB.admins) > 0)
 		Lines += "<b>Admins:</b>"
-		for(var/client/C in sortList(admins))
+		for(var/client/C in sortList(GLOB.admins))
 			if(!C.holder.fakekey)
 				Lines += "\t <font color='#FF0000'>[C.key]</font>[show_info(C)]"
 
-	if(length(mentors) > 0)
+	if(length(GLOB.mentors) > 0)
 		Lines += "<b>Mentors:</b>"
-		for(var/client/C in sortList(clients))
-			var/mentor = mentor_datums[C.ckey]
+		for(var/client/C in sortList(GLOB.clients))
+			var/mentor = GLOB.mentor_datums[C.ckey]
 			if(mentor)
 				Lines += "\t <font color='#0033CC'>[C.key]</font>[show_info(C)]"
 
 	Lines += "<b>Players:</b>"
-	for(var/client/C in sortList(clients))
+	for(var/client/C in sortList(GLOB.clients))
 		if(!check_mentor_other(C) || (C.holder && C.holder.fakekey))
 			Lines += "\t [C.key][show_info(C)]"
 
@@ -68,7 +68,7 @@
 
 	var/msg = "<b>Current Admins:</b>\n"
 	if(holder)
-		for(var/client/C in admins)
+		for(var/client/C in GLOB.admins)
 			msg += "\t[C] is a [C.holder.rank]"
 
 			if(C.holder.fakekey)
@@ -85,7 +85,7 @@
 				msg += " (AFK)"
 			msg += "\n"
 	else
-		for(var/client/C in admins)
+		for(var/client/C in GLOB.admins)
 			if(C.is_afk())
 				continue //Don't show afk admins to adminwho
 			if(!C.holder.fakekey)
@@ -97,7 +97,7 @@
 	set category = "Mentor"
 	set name = "Mentorwho"
 	var/msg = "<b>Current Mentors:</b>\n"
-	for(var/client/C in mentors)
+	for(var/client/C in GLOB.mentors)
 		var/suffix = ""
 		if(holder)
 			if(isobserver(C.mob))