April sync (#360)

* Maps and things no code/icons

* helpers defines globalvars

* Onclick world.dm orphaned_procs

* subsystems

Round vote and shuttle autocall done here too

* datums

* Game folder

* Admin - chatter modules

* clothing - mining

* modular computers - zambies

* client

* mob level 1

* mob stage 2 + simple_animal

* silicons n brains

* mob stage 3 + Alien/Monkey

* human mobs

* icons updated

* some sounds

* emitter y u no commit

* update tgstation.dme

* compile fixes

* travis fixes

Also removes Fast digest mode, because reasons.

* tweaks for travis Mentors are broke again

Also fixes Sizeray guns

* oxygen loss fix for vore code.

* removes unused code

* some code updates

* bulk fixes

* further fixes

* outside things

* whoops.

* Maint bar ported

* GLOBs.

code/modules/error_handler/error_handler.dm

@@ -1,18 +1,20 @@
-var/global/list/error_last_seen = list()
-var/global/list/error_cooldown = list() /* Error_cooldown items will either be positive(cooldown time) or negative(silenced error)
-											 If negative, starts at -1, and goes down by 1 each time that error gets skipped*/
-var/global/total_runtimes = 0
-var/global/total_runtimes_skipped = 0
+GLOBAL_VAR_INIT(total_runtimes, 0)
+GLOBAL_VAR_INIT(total_runtimes_skipped, 0)
 
 #ifdef DEBUG
 /world/Error(exception/E, datum/e_src)
 	if(!istype(E)) //Something threw an unusual exception
 		log_world("\[[time_stamp()]] Uncaught exception: [E]")
 		return ..()
+	
+	var/static/list/error_last_seen = list()
+	var/static/list/error_cooldown = list() /* Error_cooldown items will either be positive(cooldown time) or negative(silenced error)
+												If negative, starts at -1, and goes down by 1 each time that error gets skipped*/
+
 	if(!error_last_seen) // A runtime is occurring too early in start-up initialization
 		return ..()
 
-	total_runtimes++
+	GLOB.total_runtimes++
 
 	var/erroruid = "[E.file][E.line]"
 	var/last_seen = error_last_seen[erroruid]
@@ -24,7 +26,7 @@ var/global/total_runtimes_skipped = 0
 
 	if(cooldown < 0)
 		error_cooldown[erroruid]-- //Used to keep track of skip count for this error
-		total_runtimes_skipped++
+		GLOB.total_runtimes_skipped++
 		return //Error is currently silenced, skip handling it
 	//Handle cooldowns and silencing spammy errors
 	var/silencing = FALSE
@@ -54,7 +56,7 @@ var/global/total_runtimes_skipped = 0
 			error_cooldown[erroruid] = 0
 			if(skipcount > 0)
 				world.log << "\[[time_stamp()]] Skipped [skipcount] runtimes in [E.file],[E.line]."
-				error_cache.log_error(E, skip_count = skipcount)
+				GLOB.error_cache.log_error(E, skip_count = skipcount)
 
 	error_last_seen[erroruid] = world.time
 	error_cooldown[erroruid] = cooldown
@@ -87,8 +89,8 @@ var/global/total_runtimes_skipped = 0
 		desclines.Add(usrinfo)
 	if(silencing)
 		desclines += "  (This error will now be silenced for [configured_error_silence_time / 600] minutes)"
-	if(error_cache)
-		error_cache.log_error(E, desclines)
+	if(GLOB.error_cache)
+		GLOB.error_cache.log_error(E, desclines)
 
 	world.log << "\[[time_stamp()]] Runtime in [E.file],[E.line]: [E]"
 	for(var/line in desclines)
@@ -106,7 +108,7 @@ var/global/total_runtimes_skipped = 0
 			split[i] = "\[[time2text(world.timeofday,"hh:mm:ss")]\][split[i]]"
 	E.desc = jointext(split, "\n")
 	if(config && config.log_runtimes)
-		world.log = runtime_diary
+		world.log = GLOB.runtime_diary
 		..(E)
 
 	world.log = null

code/modules/error_handler/error_viewer.dm

@@ -8,10 +8,10 @@
 //   right here:
 
 #ifdef DEBUG
-/var/datum/error_viewer/error_cache/error_cache = new()
+GLOBAL_DATUM_INIT(error_cache, /datum/error_viewer/error_cache, new)
 #else
 // If debugging is disabled, there's nothing useful to log, so don't bother.
-/var/datum/error_viewer/error_cache/error_cache = null
+GLOBAL_DATUM(error_cache, /datum/error_viewer/error_cache)
 #endif
 
 // - error_source datums exist for each line (of code) that generates an error,
@@ -80,7 +80,7 @@
 
 /datum/error_viewer/error_cache/show_to(user, datum/error_viewer/back_to, linear)
 	var/html = build_header()
-	html += "<b>[global.total_runtimes]</b> runtimes, <b>[global.total_runtimes_skipped]</b> skipped<br><br>"
+	html += "<b>[GLOB.total_runtimes]</b> runtimes, <b>[GLOB.total_runtimes_skipped]</b> skipped<br><br>"
 	if (!linear)
 		html += "organized | [make_link("linear", null, 1)]<hr>"
 		var/datum/error_viewer/error_source/error_source
@@ -137,7 +137,7 @@
 
 /datum/error_viewer/error_source/show_to(user, datum/error_viewer/back_to, linear)
 	if (!istype(back_to))
-		back_to = error_cache
+		back_to = GLOB.error_cache
 
 	var/html = build_header(back_to)
 	for (var/datum/error_viewer/error_entry/error_entry in errors)