Find references fix. (#32022)

* Find references fix.

Made it go from taking years to hours

Removed Datum based recursion, this was unneeded.

Fixed it calling a proc for what ended up being a costly noop millions of times (this was a moderate speed up as it would call DoSearchVar on every fucking number or string or null in a things vars list.)

Fixed it calling itself on the vars list. luckily it only checked keys, so this didn't stack overflow.

I'm intentionally leaving the debugging stuff in right now so that its on the record somewhere. I'll remove that when I pr line by line profiling as its own separate thing

* Remove debugging stuff

* i forgot

This commit is contained in:

Kyle Spier-Swenson

2017-10-27 04:57:15 -05:00

committed by

CitadelStationBot

parent 5c94555ccd

commit 8469b4223e

3 changed files with 50 additions and 25 deletions

code/__HELPERS/cmp.dm

View File

@@ -58,3 +58,4 @@ GLOBAL_VAR_INIT(cmp_field, "name")
 		. = B.failures - A.failures
 	if (!.)
 		. = B.qdels - A.qdels