diff --git a/code/__DEFINES/role_preferences.dm b/code/__DEFINES/role_preferences.dm index 5a9b8181af..79c96805c0 100644 --- a/code/__DEFINES/role_preferences.dm +++ b/code/__DEFINES/role_preferences.dm @@ -55,6 +55,6 @@ GLOBAL_LIST_INIT(special_roles, list( )) //Job defines for what happens when you fail to qualify for any job during job selection -#define BEASSISTANT 1 +#define BEOVERFLOW 1 #define BERANDOMJOB 2 #define RETURNTOLOBBY 3 diff --git a/code/controllers/subsystem/job.dm b/code/controllers/subsystem/job.dm index fce7ac941e..8e29207fe1 100644 --- a/code/controllers/subsystem/job.dm +++ b/code/controllers/subsystem/job.dm @@ -13,6 +13,8 @@ SUBSYSTEM_DEF(job) var/list/prioritized_jobs = list() var/list/latejoin_trackers = list() //Don't read this list, use GetLateJoinTurfs() instead + var/overflow_role = "Assistant" + /datum/controller/subsystem/job/Initialize(timeofday) if(!occupations.len) SetupOccupations() @@ -119,7 +121,7 @@ SUBSYSTEM_DEF(job) if(!job) continue - if(istype(job, GetJob("Assistant"))) // We don't want to give him assistant, that's boring! + if(istype(job, GetJob(SSjob.overflow_role))) // We don't want to give him assistant, that's boring! continue if(job.title in GLOB.command_positions) //If you want a command position, select it! @@ -250,15 +252,15 @@ SUBSYSTEM_DEF(job) HandleFeedbackGathering() - //People who wants to be assistants, sure, go on. - Debug("DO, Running Assistant Check 1") - var/datum/job/assist = new /datum/job/assistant() - var/list/assistant_candidates = FindOccupationCandidates(assist, 3) - Debug("AC1, Candidates: [assistant_candidates.len]") - for(var/mob/dead/new_player/player in assistant_candidates) + //People who wants to be the overflow role, sure, go on. + Debug("DO, Running Overflow Check 1") + var/datum/job/overflow = GetJob(SSjob.overflow_role) + var/list/overflow_candidates = FindOccupationCandidates(overflow, 3) + Debug("AC1, Candidates: [overflow_candidates.len]") + for(var/mob/dead/new_player/player in overflow_candidates) Debug("AC1 pass, Player: [player]") - AssignRole(player, "Assistant") - assistant_candidates -= player + AssignRole(player, SSjob.overflow_role) + overflow_candidates -= player Debug("DO, AC1 end") //Select one head @@ -327,8 +329,8 @@ SUBSYSTEM_DEF(job) for(var/mob/dead/new_player/player in unassigned) if(PopcapReached()) RejectPlayer(player) - else if(jobban_isbanned(player, "Assistant")) - GiveRandomJob(player) //you get to roll for random before everyone else just to be sure you don't get assistant. you're so speshul + else if(jobban_isbanned(player, SSjob.overflow_role)) + GiveRandomJob(player) //you get to roll for random before everyone else just to be sure you don't get overflow. you're so speshul for(var/mob/dead/new_player/player in unassigned) if(PopcapReached()) @@ -344,15 +346,15 @@ SUBSYSTEM_DEF(job) for(var/mob/dead/new_player/player in unassigned) if(PopcapReached()) RejectPlayer(player) - if(player.client.prefs.joblessrole == BEASSISTANT) + if(player.client.prefs.joblessrole == BEOVERFLOW) Debug("AC2 Assistant located, Player: [player]") - AssignRole(player, "Assistant") + AssignRole(player, SSjob.overflow_role) else // For those who don't want to play if their preference were filled, back you go. RejectPlayer(player) for(var/mob/dead/new_player/player in unassigned) //Players that wanted to back out but couldn't because they're antags (can you feel the edge case?) if(!GiveRandomJob(player)) - AssignRole(player, "Assistant") //If everything is already filled, make them an assistant + AssignRole(player, SSjob.overflow_role) //If everything is already filled, make them an assistant return 1 diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm index dbc84d19a3..65bad5219f 100644 --- a/code/modules/client/preferences.dm +++ b/code/modules/client/preferences.dm @@ -655,6 +655,8 @@ GLOBAL_LIST_EMPTY(preferences_datums) //The job before the current job. I only use this to get the previous jobs color when I'm filling in blank rows. var/datum/job/lastJob + var/datum/job/overflow = SSjob.GetJob(SSjob.overflow_role) + for(var/datum/job/job in SSjob.occupations) index += 1 @@ -682,7 +684,7 @@ GLOBAL_LIST_EMPTY(preferences_datums) var/available_in_days = job.available_in_days(user.client) HTML += "[rank]