Fixes clockwork sigil candidate runtime, cleans up some jobban checks with defines (#5304)

code/modules/awaymissions/mission_code/Academy.dm

@@ -92,7 +92,7 @@
 	var/mob/living/current_wizard = null
 	var/next_check = 0
 	var/cooldown = 600
-	var/faction = "wizard"
+	var/faction = ROLE_WIZARD
 	var/braindead_check = 0
 
 /obj/structure/academy_wizard_spawner/New()
@@ -128,13 +128,12 @@
 	if(!current_wizard)
 		return
 	var/list/mob/dead/observer/candidates = pollCandidatesForMob("Do you want to play as Wizard Academy Defender?", ROLE_WIZARD, null, ROLE_WIZARD, 50, current_wizard)
-	var/mob/dead/observer/chosen = null
 
-	if(candidates.len)
-		chosen = pick(candidates)
-		message_admins("[key_name_admin(chosen)] was spawned as Wizard Academy Defender")
+	if(LAZYLEN(candidates))
+		var/client/C = pick(candidates)
+		message_admins("[key_name_admin(C)] was spawned as Wizard Academy Defender")
 		current_wizard.ghostize() // on the off chance braindead defender gets back in
-		current_wizard.key = chosen.key
+		current_wizard.key = C.key
 
 /obj/structure/academy_wizard_spawner/proc/summon_wizard()
 	var/turf/T = src.loc
@@ -272,11 +271,10 @@
 			servant_mind.transfer_to(H)
 
 			var/list/mob/dead/observer/candidates = pollCandidatesForMob("Do you want to play as [user.real_name] Servant?", ROLE_WIZARD, null, ROLE_WIZARD, 50, H)
-			var/mob/dead/observer/chosen = null
-			if(candidates.len)
-				chosen = pick(candidates)
-				message_admins("[key_name_admin(chosen)] was spawned as Dice Servant")
-				H.key = chosen.key
+			if(LAZYLEN(candidates))
+				var/client/C = pick(candidates)
+				message_admins("[key_name_admin(C)] was spawned as Dice Servant")
+				H.key = C.key
 
 			var/obj/effect/proc_holder/spell/targeted/summonmob/S = new
 			S.target_mob = H

code/modules/awaymissions/mission_code/snowdin.dm

@@ -233,7 +233,7 @@
 	icon_state = "sleeper"
 	roundstart = FALSE
 	death = FALSE
-	faction = "syndicate"
+	faction = ROLE_SYNDICATE
 	outfit = /datum/outfit/snowsyndie
 	flavour_text = {"You are a syndicate operative recently awoken from cyrostatis in an underground outpost. Monitor Nanotrasen communications and record information. All intruders should be
 	disposed of swirfly to assure no gathered information is stolen or lost. Try not to wander too far from the outpost as the caves can be a deadly place even for a trained operative such as yourself."}

code/modules/awaymissions/mission_code/wildwest.dm

@@ -113,7 +113,7 @@
 			if("To Kill")
 				to_chat(user, "<B>Your wish is granted, but at a terrible cost...</B>")
 				to_chat(user, "The Wish Granter punishes you for your wickedness, claiming your soul and warping your body to match the darkness in your heart.")
-				user.mind.special_role = "traitor"
+				user.mind.special_role = ROLE_TRAITOR
 				
 				var/datum/objective/hijack/hijack = new
 				hijack.owner = user.mind