Merge branch 'master' of https://github.com/Citadel-Station-13/Citadel-Station-13 into proc-define-shit

code/modules/mob/dead/new_player/new_player.dm

@@ -169,10 +169,10 @@
 
 /mob/dead/new_player/Topic(href, href_list[])
 	if(src != usr)
-		return 0
+		return FALSE
 
 	if(!client)
-		return 0
+		return FALSE
 
 	//don't let people get to this unless they are specifically not verified
 	if(href_list["Month"] && (CONFIG_GET(flag/age_verification) && !check_rights_for(client, R_ADMIN) && !(client.ckey in GLOB.bunker_passthrough)))
@@ -727,7 +727,7 @@
 	src << browse(dat, "window=manifest;size=387x420;can_close=1")
 
 /mob/dead/new_player/Move()
-	return 0
+	return FALSE
 
 
 /mob/dead/new_player/proc/close_spawn_windows()

code/modules/mob/dead/new_player/poll.dm

@@ -461,7 +461,7 @@
 		return
 	pollid = text2num(pollid)
 	if (!pollid || pollid < 0)
-		return 0
+		return FALSE
 	//validate the poll is actually the right type of poll and its still active
 	var/datum/db_query/query_validate_poll = SSdbcore.NewQuery({"
 		SELECT id
@@ -473,12 +473,12 @@
 		))
 	if(!query_validate_poll.warn_execute())
 		qdel(query_validate_poll)
-		return 0
+		return FALSE
 	if (!query_validate_poll.NextRow())
 		qdel(query_validate_poll)
-		return 0
+		return FALSE
 	qdel(query_validate_poll)
-	return 1
+	return TRUE
 
 /**
  * Processes vote form data and saves results to the database for an IRV type poll.
@@ -501,7 +501,7 @@
 	if(!QDELETED(client) && client.holder)
 		admin_rank = client.holder.rank.name
 	if (!vote_valid_check(pollid, client?.holder, POLLTYPE_IRV))
-		return 0
+		return FALSE
 
 	var/list/special_columns = list(
 		"datetime" = "NOW()",
@@ -544,7 +544,7 @@
 		return
 	//validate the poll
 	if (!vote_valid_check(pollid, client.holder, POLLTYPE_OPTION))
-		return 0
+		return FALSE
 	var/voted = poll_check_voted(pollid)
 	if(isnull(voted) || voted) //Failed or already voted.
 		return
@@ -567,7 +567,7 @@
 	qdel(query_option_vote)
 	if(!QDELETED(usr))
 		usr << browse(null,"window=playerpoll")
-	return 1
+	return TRUE
 
 /mob/dead/new_player/proc/log_text_poll_reply(pollid, replytext)
 	if(!SSdbcore.Connect())
@@ -581,7 +581,7 @@
 		return
 	//validate the poll
 	if (!vote_valid_check(pollid, client.holder, POLLTYPE_TEXT))
-		return 0
+		return FALSE
 	if(!replytext)
 		to_chat(usr, "The text you entered was blank. Please correct the text and submit again.")
 		return
@@ -611,7 +611,7 @@
 	qdel(query_text_vote)
 	if(!QDELETED(usr))
 		usr << browse(null,"window=playerpoll")
-	return 1
+	return TRUE
 
 /mob/dead/new_player/proc/vote_on_numval_poll(pollid, optionid, rating)
 	if(!SSdbcore.Connect())
@@ -625,7 +625,7 @@
 		return
 	//validate the poll
 	if (!vote_valid_check(pollid, client.holder, POLLTYPE_RATING))
-		return 0
+		return FALSE
 	var/datum/db_query/query_numval_hasvoted = SSdbcore.NewQuery({"
 		SELECT id
 		FROM [format_table_name("poll_vote")]
@@ -655,7 +655,7 @@
 	qdel(query_numval_vote)
 	if(!QDELETED(usr))
 		usr << browse(null,"window=playerpoll")
-	return 1
+	return TRUE
 
 /**
  * Processes vote form data and saves results to the database for a multiple choice type poll.

code/modules/mob/dead/observer/observer.dm

@@ -233,7 +233,7 @@ GLOBAL_VAR_INIT(observer_default_invisibility, INVISIBILITY_OBSERVER)
 	var/g_val
 	var/color_format = length(input_color)
 	if(color_format != length_char(input_color))
-		return 0
+		return FALSE
 	if(color_format == 3)
 		r_val = hex2num(copytext(input_color, 1, 2)) * 16
 		g_val = hex2num(copytext(input_color, 2, 3)) * 16
@@ -243,7 +243,7 @@ GLOBAL_VAR_INIT(observer_default_invisibility, INVISIBILITY_OBSERVER)
 		g_val = hex2num(copytext(input_color, 3, 5))
 		b_val = hex2num(copytext(input_color, 5, 7))
 	else
-		return 0 //If the color format is not 3 or 6, you're using an unexpected way to represent a color.
+		return FALSE //If the color format is not 3 or 6, you're using an unexpected way to represent a color.
 
 	r_val += (255 - r_val) * 0.4
 	if(r_val > 255)
@@ -693,32 +693,32 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
 	var/mob/living/target = input("Your new life begins today!", "Possess Mob", null, null) as null|anything in possessible
 
 	if(!target)
-		return 0
+		return FALSE
 
 	if(ismegafauna(target))
 		to_chat(src, "<span class='warning'>This creature is too powerful for you to possess!</span>")
-		return 0
+		return FALSE
 
 	if(can_reenter_corpse && mind && mind.current)
 		if(alert(src, "Your soul is still tied to your former life as [mind.current.name], if you go forward there is no going back to that life. Are you sure you wish to continue?", "Move On", "Yes", "No") == "No")
-			return 0
+			return FALSE
 	if(target.key)
 		to_chat(src, "<span class='warning'>Someone has taken this body while you were choosing!</span>")
-		return 0
+		return FALSE
 
 	transfer_ckey(target, FALSE)
 	target.AddElement(/datum/element/ghost_role_eligibility, penalize_on_ghost = FALSE, free_ghosting = TRUE)
 	target.faction = list("neutral")
-	return 1
+	return TRUE
 
 //this is a mob verb instead of atom for performance reasons
 //see /mob/verb/examinate() in mob.dm for more info
 //overridden here and in /mob/living for different point span classes and sanity checks
 /mob/dead/observer/pointed(atom/A as mob|obj|turf in fov_view())
 	if(!..())
-		return 0
+		return FALSE
 	usr.visible_message("<span class='deadsay'><b>[src]</b> points to [A].</span>")
-	return 1
+	return TRUE
 
 /mob/dead/observer/verb/view_manifest()
 	set name = "View Crew Manifest"
@@ -839,7 +839,7 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
 	return IsAdminGhost(usr)
 
 /mob/dead/observer/is_literate()
-	return 1
+	return TRUE
 
 /mob/dead/observer/vv_edit_var(var_name, var_value)
 	. = ..()
@@ -947,7 +947,7 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
 
 // Ghosts have no momentum, being massless ectoplasm
 /mob/dead/observer/Process_Spacemove(movement_dir)
-	return 1
+	return TRUE
 
 /mob/dead/observer/vv_edit_var(var_name, var_value)
 	. = ..()