From ad6a3e810f1e517c4c8b3673bc9d9b2854874905 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Sat, 10 Mar 2018 15:51:32 -0500 Subject: [PATCH] Fix config loading exploit (#36286) --- code/controllers/configuration/configuration.dm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/code/controllers/configuration/configuration.dm b/code/controllers/configuration/configuration.dm index a19f3147e7..b662fd4f84 100644 --- a/code/controllers/configuration/configuration.dm +++ b/code/controllers/configuration/configuration.dm @@ -67,6 +67,9 @@ entries_by_type -= CE.type /datum/controller/configuration/proc/LoadEntries(filename, list/stack = list()) + if(IsAdminAdvancedProcCall()) + return + var/filename_to_test = world.system_type == MS_WINDOWS ? lowertext(filename) : filename if(filename_to_test in stack) log_config("Warning: Config recursion detected ([english_list(stack)]), breaking!")