From bb9982e772a7254a6d70ffb585c8a5e19f62cd7d Mon Sep 17 00:00:00 2001 From: oranges Date: Thu, 5 Oct 2017 21:04:20 +1300 Subject: [PATCH] Merge pull request #31296 from ShizCalev/landmark-cleanup Cleans up and fixes old landmarks --- code/datums/mind.dm | 2 +- code/modules/admin/verbs/randomverbs.dm | 10 +++------- code/modules/mob/dead/new_player/new_player.dm | 2 +- code/modules/shuttle/manipulator.dm | 2 +- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/code/datums/mind.dm b/code/datums/mind.dm index 093e828452..0e1b754fc9 100644 --- a/code/datums/mind.dm +++ b/code/datums/mind.dm @@ -1119,7 +1119,7 @@ message_admins("[key_name_admin(usr)] has nuke op'ed [current].") log_admin("[key_name(usr)] has nuke op'ed [current].") if("lair") - current.forceMove(get_turf(locate("landmark*Syndicate-Spawn"))) + current.forceMove(pick(GLOB.nukeop_start)) if("dressup") var/mob/living/carbon/human/H = current qdel(H.belt) diff --git a/code/modules/admin/verbs/randomverbs.dm b/code/modules/admin/verbs/randomverbs.dm index e354d26ab0..e81ab011e4 100644 --- a/code/modules/admin/verbs/randomverbs.dm +++ b/code/modules/admin/verbs/randomverbs.dm @@ -381,13 +381,10 @@ Traitors and the like can also be revived with the previous role mostly intact. switch(new_character.mind.special_role) if("Wizard") - new_character.loc = pick(GLOB.wizardstart) - //SSticker.mode.learn_basic_spells(new_character) + new_character.forceMove(pick(GLOB.wizardstart)) SSticker.mode.equip_wizard(new_character) if("Syndicate") - var/obj/effect/landmark/synd_spawn = locate("landmark*Syndicate-Spawn") - if(synd_spawn) - new_character.loc = get_turf(synd_spawn) + new_character.forceMove(pick(GLOB.nukeop_start)) call(/datum/game_mode/proc/equip_syndicate)(new_character) if("Space Ninja") var/list/ninja_spawn = list() @@ -396,8 +393,7 @@ Traitors and the like can also be revived with the previous role mostly intact. var/datum/antagonist/ninja/ninjadatum = new_character.mind.has_antag_datum(ANTAG_DATUM_NINJA) ninjadatum.equip_space_ninja() if(ninja_spawn.len) - var/obj/effect/landmark/ninja_spawn_here = pick(ninja_spawn) - new_character.loc = ninja_spawn_here.loc + new_character.forceMove(pick(ninja_spawn)) else//They may also be a cyborg or AI. switch(new_character.mind.assigned_role) diff --git a/code/modules/mob/dead/new_player/new_player.dm b/code/modules/mob/dead/new_player/new_player.dm index aca1d9b63f..666fd767ba 100644 --- a/code/modules/mob/dead/new_player/new_player.dm +++ b/code/modules/mob/dead/new_player/new_player.dm @@ -273,7 +273,7 @@ observer.started_as_observer = TRUE close_spawn_windows() - var/obj/O = locate("landmark*Observer-Start") + var/obj/effect/landmark/observer_start/O = locate(/obj/effect/landmark/observer_start) in GLOB.landmarks_list to_chat(src, "Now teleporting.") if (O) observer.loc = O.loc diff --git a/code/modules/shuttle/manipulator.dm b/code/modules/shuttle/manipulator.dm index 6e2741a6d7..3da4bcc03e 100644 --- a/code/modules/shuttle/manipulator.dm +++ b/code/modules/shuttle/manipulator.dm @@ -242,7 +242,7 @@ /obj/machinery/shuttle_manipulator/proc/load_template( datum/map_template/shuttle/S) // load shuttle template, centred at shuttle import landmark, - var/turf/landmark_turf = get_turf(locate("landmark*Shuttle Import")) + var/turf/landmark_turf = get_turf(locate(/obj/effect/landmark/shuttle_import) in GLOB.landmarks_list) S.load(landmark_turf, centered = TRUE) var/affected = S.get_affected_turfs(landmark_turf, centered=TRUE)