New() goes in the trash, we've gotta Initialize()

This commit is contained in:
CitadelStationBot
2017-04-26 17:15:48 -05:00
parent e7df2bc14a
commit bcab389ca2
69 changed files with 358 additions and 245 deletions
@@ -16,7 +16,7 @@
var/toggle = FALSE
/mob/living/simple_animal/hostile/guardian/healer/Initialize()
..()
. = ..()
var/datum/atom_hud/medsensor = GLOB.huds[DATA_HUD_MEDICAL_ADVANCED]
medsensor.add_hud_to(src)
@@ -149,8 +149,8 @@
duration = 18
randomdir = FALSE
/obj/effect/overlay/temp/paperwiz_dying/New()
..()
/obj/effect/overlay/temp/paperwiz_dying/Initialize()
. = ..()
visible_message("<span class='boldannounce'>The wizard cries out in pain as a gate appears behind him, sucking him in!</span>")
playsound(get_turf(src),'sound/magic/MandSwap.ogg', 50, 1, 1)
playsound(get_turf(src),'sound/hallucinations/wail.ogg', 50, 1, 1)
@@ -0,0 +1,10 @@
diff a/code/modules/mob/living/simple_animal/hostile/megafauna/colossus.dm b/code/modules/mob/living/simple_animal/hostile/megafauna/colossus.dm (rejected hunks)
@@ -106,7 +106,7 @@ Difficulty: Very Hard
var/target
/obj/effect/overlay/temp/at_shield/Initialize(mapload, new_target)
- ..()
+ . = ..()
target = new_target
INVOKE_ASYNC(src, /atom/movable/proc/orbit, target, 0, FALSE, 0, 0, FALSE, TRUE)
@@ -0,0 +1,23 @@
diff a/code/modules/mob/living/simple_animal/hostile/megafauna/dragon.dm b/code/modules/mob/living/simple_animal/hostile/megafauna/dragon.dm (rejected hunks)
@@ -96,8 +96,8 @@ Difficulty: Medium
duration = 12
pixel_z = 500
-/obj/effect/overlay/temp/fireball/Initialize(loc)
- ..()
+/obj/effect/overlay/temp/fireball/Initialize()
+ . = ..()
animate(src, pixel_z = 0, time = 12)
/obj/effect/overlay/temp/target
@@ -121,8 +121,8 @@ Difficulty: Medium
/obj/effect/overlay/temp/target/ex_act()
return
-/obj/effect/overlay/temp/target/Initialize(loc)
- ..()
+/obj/effect/overlay/temp/target/Initialize()
+ . = ..()
INVOKE_ASYNC(src, .proc/fall)
/obj/effect/overlay/temp/target/proc/fall()
@@ -426,8 +426,8 @@ Difficulty: Hard
layer = BELOW_MOB_LAYER
var/mob/living/caster //who made this, anyway
/obj/effect/overlay/temp/hierophant/New(loc, new_caster)
..()
/obj/effect/overlay/temp/hierophant/Initialize(mapload, new_caster)
. = ..()
if(new_caster)
caster = new_caster
@@ -437,13 +437,13 @@ Difficulty: Hard
light_range = 1
randomdir = FALSE
/obj/effect/overlay/temp/hierophant/squares/New(loc, new_caster)
..()
/obj/effect/overlay/temp/hierophant/squares/Initialize(mapload, new_caster)
. = ..()
if(ismineralturf(loc))
var/turf/closed/mineral/M = loc
M.gets_drilled(caster)
/obj/effect/overlay/temp/hierophant/wall //smoothing and pooling are not friends. TODO: figure this out
/obj/effect/overlay/temp/hierophant/wall //smoothing and pooling were not friends, but pooling is dead.
name = "vortex wall"
icon = 'icons/turf/walls/hierophant_wall_temp.dmi'
icon_state = "wall"
@@ -451,15 +451,14 @@ Difficulty: Hard
duration = 100
smooth = SMOOTH_TRUE
/obj/effect/overlay/temp/hierophant/wall/New(loc, new_caster)
..()
/obj/effect/overlay/temp/hierophant/wall/Initialize(mapload, new_caster)
. = ..()
queue_smooth_neighbors(src)
queue_smooth(src)
/obj/effect/overlay/temp/hierophant/wall/Destroy()
queue_smooth_neighbors(src)
..()
return QDEL_HINT_QUEUE
return ..()
/obj/effect/overlay/temp/hierophant/wall/CanPass(atom/movable/mover, turf/target, height = 0)
if(mover == caster)
@@ -480,8 +479,8 @@ Difficulty: Hard
var/currently_seeking = FALSE
var/friendly_fire_check = FALSE //if blasts produced apply friendly fire
/obj/effect/overlay/temp/hierophant/chaser/New(loc, new_caster, new_target, new_speed, is_friendly_fire)
..()
/obj/effect/overlay/temp/hierophant/chaser/Initialize(mapload, new_caster, new_target, new_speed, is_friendly_fire)
. = ..()
target = new_target
friendly_fire_check = is_friendly_fire
if(new_speed)
@@ -558,8 +557,8 @@ Difficulty: Hard
var/friendly_fire_check = FALSE
var/bursting = FALSE //if we're bursting and need to hit anyone crossing us
/obj/effect/overlay/temp/hierophant/blast/New(loc, new_caster, friendly_fire)
..()
/obj/effect/overlay/temp/hierophant/blast/Initialize(mapload, new_caster, friendly_fire)
. = ..()
friendly_fire_check = friendly_fire
if(new_caster)
hit_things += new_caster