12/21 modernizations from TG live (#103)

* sync (#3)

* shuttle auto call

* Merge /vore into /master (#39)

* progress

* Compile errors fixed

No idea if it's test worthy tho as conflicts with race overhaul and
narky removal.

* Update admins.txt

* efforts continue

Fuck grab code, seriously

* grab code is cancer

* Execute the Narkism

Do not hesitate.

Show no mercy.

* holy shit grab code is awful

* have I bitched about grab code

My bitching, let me show you it

* código de agarre es una mierda

No really it is

* yeah I don't even know anymore.

* Lolnope. Fuck grab code

* I'm not even sure what to fix anymore

* Self eating is not an acceptable fate

* Taste the void, son.

* My code doesn't pass it's own sanity check.

Maybe it's a sign of things to come.

* uncommented and notes

* It Works and I Don't Know Why (#38)

* shuttle auto call

* it works and I don't know why

* Subsystem 12/21

Most Recent TG subsystem folder

* globalvars 12/21

Tossed out the flavor_misc and parallax files

* Onclick 12/21

as well as .dme updates

* _defines 12/21

ommited old _MC.dm

* _HELPERS 12/21

Preserved snowflake placement of furry sprites

* _defeines/genetics

reapplied narkism holdover for snowflake races.

* Oops forgot mutant colors

* modules porting 12/21 + Sounds/icons

Admin, Client and most of mob life files ommitted

* enviroment file

* Admin optimizations

ahelp log system kept

* Mob ports 12/21

Flavor text preserved

* datums ported 12/21

* Game ported 12/21

* batch of duplicate fixes/dogborg work

Dogborgs need to be modernized to refractored borg standards.

* moar fixes

* Maps and futher compile fixes

code/game/gamemodes/blob/blobs/blob_mobs.dm

@@ -14,22 +14,22 @@
 	minbodytemp = 0
 	maxbodytemp = 360
 	unique_name = 1
-	a_intent = "harm"
+	a_intent = INTENT_HARM
 	var/mob/camera/blob/overmind = null
-	var/obj/effect/blob/factory/factory = null
+	var/obj/structure/blob/factory/factory = null
 
 /mob/living/simple_animal/hostile/blob/update_icons()
 	if(overmind)
-		color = overmind.blob_reagent_datum.color
+		add_atom_colour(overmind.blob_reagent_datum.color, FIXED_COLOUR_PRIORITY)
 	else
-		color = initial(color)
+		remove_atom_colour(FIXED_COLOUR_PRIORITY)
 
 /mob/living/simple_animal/hostile/blob/Destroy()
 	if(overmind)
 		overmind.blob_mobs -= src
 	return ..()
 
-/mob/living/simple_animal/hostile/blob/blob_act(obj/effect/blob/B)
+/mob/living/simple_animal/hostile/blob/blob_act(obj/structure/blob/B)
 	if(stat != DEAD && health < maxHealth)
 		for(var/i in 1 to 2)
 			var/obj/effect/overlay/temp/heal/H = PoolOrNew(/obj/effect/overlay/temp/heal, get_turf(src)) //hello yes you are being healed
@@ -39,24 +39,27 @@
 				H.color = "#000000"
 		adjustHealth(-maxHealth*0.0125)
 
-/mob/living/simple_animal/hostile/blob/fire_act(datum/gas_mixture/air, exposed_temperature, exposed_volume)
+/mob/living/simple_animal/hostile/blob/fire_act(exposed_temperature, exposed_volume)
 	..()
-	adjustFireLoss(Clamp(0.01 * exposed_temperature, 1, 5))
+	if(exposed_temperature)
+		adjustFireLoss(Clamp(0.01 * exposed_temperature, 1, 5))
+	else
+		adjustFireLoss(5)
 
 /mob/living/simple_animal/hostile/blob/CanPass(atom/movable/mover, turf/target, height = 0)
-	if(istype(mover, /obj/effect/blob))
+	if(istype(mover, /obj/structure/blob))
 		return 1
 	return ..()
 
 /mob/living/simple_animal/hostile/blob/Process_Spacemove(movement_dir = 0)
-	for(var/obj/effect/blob/B in range(1, src))
+	for(var/obj/structure/blob/B in range(1, src))
 		return 1
 	return ..()
 
 /mob/living/simple_animal/hostile/blob/handle_inherent_channels(message, message_mode)
 	if(message_mode == MODE_BINARY)
 		blob_chat(message)
-		return ITALICS | REDUCE_RANGE
+		return 1
 	else
 		..()
 
@@ -79,17 +82,19 @@
 	desc = "A floating, fragile spore."
 	icon_state = "blobpod"
 	icon_living = "blobpod"
-	health = 40
-	maxHealth = 40
+	health = 30
+	maxHealth = 30
 	verb_say = "psychically pulses"
 	verb_ask = "psychically probes"
 	verb_exclaim = "psychically yells"
 	verb_yell = "psychically screams"
 	melee_damage_lower = 2
 	melee_damage_upper = 4
+	obj_damage = 20
+	environment_smash = 1
 	attacktext = "hits"
 	attack_sound = 'sound/weapons/genhit1.ogg'
-	flying = 1
+	movement_type = FLYING
 	del_on_death = 1
 	deathmessage = "explodes into a cloud of gas!"
 	var/death_cloud_size = 1 //size of cloud produced from a dying spore
@@ -97,7 +102,7 @@
 	var/is_zombie = 0
 	gold_core_spawnable = 1
 
-/mob/living/simple_animal/hostile/blob/blobspore/New(loc, var/obj/effect/blob/factory/linked_node)
+/mob/living/simple_animal/hostile/blob/blobspore/New(loc, var/obj/structure/blob/factory/linked_node)
 	if(istype(linked_node))
 		factory = linked_node
 		factory.spores += src
@@ -125,7 +130,7 @@
 	desc = "A shambling corpse animated by the blob."
 	melee_damage_lower += 8
 	melee_damage_upper += 11
-	flying = 0
+	movement_type = GROUND
 	death_cloud_size = 0
 	icon = H.icon
 	icon_state = "zombie_s"
@@ -168,20 +173,23 @@
 	return ..()
 
 /mob/living/simple_animal/hostile/blob/blobspore/update_icons()
-	..()
+	if(overmind)
+		add_atom_colour(overmind.blob_reagent_datum.complementary_color, FIXED_COLOUR_PRIORITY)
+	else
+		remove_atom_colour(FIXED_COLOUR_PRIORITY)
 	if(is_zombie)
 		cut_overlays()
 		overlays = human_overlays
 		var/image/I = image('icons/mob/blob.dmi', icon_state = "blob_head")
 		if(overmind)
-			I.color = overmind.blob_reagent_datum.color
+			I.color = overmind.blob_reagent_datum.complementary_color
 		color = initial(color)//looks better.
 		add_overlay(I)
 
 /mob/living/simple_animal/hostile/blob/blobspore/weak
 	name = "fragile blob spore"
-	health = 20
-	maxHealth = 20
+	health = 15
+	maxHealth = 15
 	melee_damage_lower = 1
 	melee_damage_upper = 2
 	death_cloud_size = 0
@@ -199,9 +207,9 @@
 	health = 200
 	maxHealth = 200
 	damage_coeff = list(BRUTE = 0.5, BURN = 1, TOX = 1, CLONE = 1, STAMINA = 0, OXY = 1)
-	next_move_modifier = 1.5 //slow-ass attack speed, 3 times higher than how fast the blob can attack
 	melee_damage_lower = 20
 	melee_damage_upper = 20
+	obj_damage = 60
 	attacktext = "slams"
 	attack_sound = 'sound/effects/blobattack.ogg'
 	verb_say = "gurgles"
@@ -209,7 +217,7 @@
 	verb_exclaim = "roars"
 	verb_yell = "bellows"
 	force_threshold = 10
-	pressure_resistance = 40
+	pressure_resistance = 50
 	mob_size = MOB_SIZE_LARGE
 	see_invisible = SEE_INVISIBLE_MINIMUM
 	see_in_dark = 8
@@ -225,13 +233,13 @@
 		if(independent)
 			return // strong independent blobbernaut that don't need no blob
 		var/damagesources = 0
-		if(!(locate(/obj/effect/blob) in range(2, src)))
+		if(!(locate(/obj/structure/blob) in range(2, src)))
 			damagesources++
 		if(!factory)
 			damagesources++
 		if(damagesources)
 			for(var/i in 1 to damagesources)
-				adjustHealth(maxHealth*0.025) //take 2.5% maxhealth as damage when not near the blob or if the naut has no factory, 5% if both
+				adjustHealth(maxHealth*0.025) //take 2.5% of max health as damage when not near the blob or if the naut has no factory, 5% if both
 			var/list/viewing = list()
 			for(var/mob/M in viewers(src))
 				if(M.client)
@@ -274,7 +282,7 @@
 	..(gibbed)
 	if(factory)
 		factory.naut = null //remove this naut from its factory
-		factory.maxhealth = initial(factory.maxhealth)
+		factory.max_integrity = initial(factory.max_integrity)
 	flick("blobbernaut_death", src)
 
 /mob/living/simple_animal/hostile/blob/blobbernaut/independent

code/game/gamemodes/blob/blobs/core.dm

@@ -1,13 +1,13 @@
-/obj/effect/blob/core
+/obj/structure/blob/core
 	name = "blob core"
 	icon = 'icons/mob/blob.dmi'
 	icon_state = "blank_blob"
 	desc = "A huge, pulsating yellow mass."
-	health = 400
-	maxhealth = 400
+	obj_integrity = 400
+	max_integrity = 400
+	armor = list(melee = 0, bullet = 0, laser = 0, energy = 0, bomb = 0, bio = 0, rad = 0, fire = 75, acid = 90)
 	explosion_block = 6
 	point_return = -1
-	atmosblock = 1
 	health_regen = 0 //we regen in Life() instead of when pulsed
 	var/core_regen = 2
 	var/overmind_get_delay = 0 //we don't want to constantly try to find an overmind, this var tracks when we'll try to get an overmind again
@@ -15,7 +15,7 @@
 	var/point_rate = 2
 
 
-/obj/effect/blob/core/New(loc, client/new_overmind = null, new_rate = 2, placed = 0)
+/obj/structure/blob/core/New(loc, client/new_overmind = null, new_rate = 2, placed = 0)
 	blob_cores += src
 	START_PROCESSING(SSobj, src)
 	poi_list |= src
@@ -27,10 +27,10 @@
 	point_rate = new_rate
 	..()
 
-/obj/effect/blob/core/scannerreport()
+/obj/structure/blob/core/scannerreport()
 	return "Directs the blob's expansion, gradually expands, and sustains nearby blob spores and blobbernauts."
 
-/obj/effect/blob/core/update_icon()
+/obj/structure/blob/core/update_icon()
 	cut_overlays()
 	color = null
 	var/image/I = new('icons/mob/blob.dmi', "blob")
@@ -40,7 +40,7 @@
 	var/image/C = new('icons/mob/blob.dmi', "blob_core_overlay")
 	add_overlay(C)
 
-/obj/effect/blob/core/Destroy()
+/obj/structure/blob/core/Destroy()
 	blob_cores -= src
 	if(overmind)
 		overmind.blob_core = null
@@ -49,36 +49,36 @@
 	poi_list -= src
 	return ..()
 
-/obj/effect/blob/core/fire_act(datum/gas_mixture/air, exposed_temperature, exposed_volume)
-	return
-
-/obj/effect/blob/core/ex_act(severity, target)
+/obj/structure/blob/core/ex_act(severity, target)
 	var/damage = 50 - 10 * severity //remember, the core takes half brute damage, so this is 20/15/10 damage based on severity
-	take_damage(damage, BRUTE)
+	take_damage(damage, BRUTE, "bomb", 0)
 
-/obj/effect/blob/core/check_health()
-	..()
-	if(overmind) //we should have an overmind, but...
-		overmind.update_health_hud()
+/obj/structure/blob/core/take_damage(damage_amount, damage_type = BRUTE, damage_flag = 0, sound_effect = 1, attack_dir, overmind_reagent_trigger = 1)
+	. = ..()
+	if(obj_integrity > 0)
+		if(overmind) //we should have an overmind, but...
+			overmind.update_health_hud()
 
-/obj/effect/blob/core/Life()
+/obj/structure/blob/core/Life()
+	if(qdeleted(src))
+		return
 	if(!overmind)
 		create_overmind()
 	else
 		if(resource_delay <= world.time)
 			resource_delay = world.time + 10 // 1 second
 			overmind.add_points(point_rate)
-	health = min(maxhealth, health+core_regen)
+	obj_integrity = min(max_integrity, obj_integrity+core_regen)
 	if(overmind)
 		overmind.update_health_hud()
 	Pulse_Area(overmind, 12, 4, 3)
-	for(var/obj/effect/blob/normal/B in range(1, src))
+	for(var/obj/structure/blob/normal/B in range(1, src))
 		if(prob(5))
-			B.change_to(/obj/effect/blob/shield/core, overmind)
+			B.change_to(/obj/structure/blob/shield/core, overmind)
 	..()
 
 
-/obj/effect/blob/core/proc/create_overmind(client/new_overmind, override_delay)
+/obj/structure/blob/core/proc/create_overmind(client/new_overmind, override_delay)
 	if(overmind_get_delay > world.time && !override_delay)
 		return
 
@@ -91,7 +91,7 @@
 	var/list/candidates = list()
 
 	if(!new_overmind)
-		candidates = get_candidates(ROLE_BLOB)
+		candidates = pollCandidatesForMob("Do you want to play as a blob overmind?", ROLE_BLOB, null, ROLE_BLOB, 50, src) //we're technically not a mob but behave similarly
 		if(candidates.len)
 			C = pick(candidates)
 	else

code/game/gamemodes/blob/blobs/factory.dm

@@ -1,10 +1,10 @@
-/obj/effect/blob/factory
+/obj/structure/blob/factory
 	name = "factory blob"
 	icon = 'icons/mob/blob.dmi'
 	icon_state = "blob_factory"
 	desc = "A thick spire of tendrils."
-	health = 200
-	maxhealth = 200
+	obj_integrity = 200
+	max_integrity = 200
 	health_regen = 1
 	point_return = 25
 	var/list/spores = list()
@@ -14,12 +14,12 @@
 	var/spore_cooldown = 80 //8 seconds between spores and after spore death
 
 
-/obj/effect/blob/factory/scannerreport()
+/obj/structure/blob/factory/scannerreport()
 	if(naut)
 		return "It is currently sustaining a blobbernaut, making it fragile and unable to produce blob spores."
 	return "Will produce a blob spore every few seconds."
 
-/obj/effect/blob/factory/Destroy()
+/obj/structure/blob/factory/Destroy()
 	for(var/mob/living/simple_animal/hostile/blob/blobspore/spore in spores)
 		if(spore.factory == src)
 			spore.factory = null
@@ -30,7 +30,7 @@
 	spores = null
 	return ..()
 
-/obj/effect/blob/factory/Be_Pulsed()
+/obj/structure/blob/factory/Be_Pulsed()
 	. = ..()
 	if(naut)
 		return

code/game/gamemodes/blob/blobs/node.dm

@@ -1,41 +1,38 @@
-/obj/effect/blob/node
+/obj/structure/blob/node
 	name = "blob node"
 	icon = 'icons/mob/blob.dmi'
 	icon_state = "blank_blob"
 	desc = "A large, pulsating yellow mass."
-	health = 200
-	maxhealth = 200
+	obj_integrity = 200
+	max_integrity = 200
+	armor = list(melee = 0, bullet = 0, laser = 0, energy = 0, bomb = 0, bio = 0, rad = 0, fire = 65, acid = 90)
 	health_regen = 3
 	point_return = 25
-	atmosblock = 1
 
 
-/obj/effect/blob/node/New(loc, var/h = 100)
+/obj/structure/blob/node/New(loc)
 	blob_nodes += src
 	START_PROCESSING(SSobj, src)
-	..(loc, h)
+	..()
 
-/obj/effect/blob/node/scannerreport()
+/obj/structure/blob/node/scannerreport()
 	return "Gradually expands and sustains nearby blob spores and blobbernauts."
 
-/obj/effect/blob/node/update_icon()
+/obj/structure/blob/node/update_icon()
 	cut_overlays()
 	color = null
 	var/image/I = new('icons/mob/blob.dmi', "blob")
 	if(overmind)
 		I.color = overmind.blob_reagent_datum.color
-	src.add_overlay(I)
+	add_overlay(I)
 	var/image/C = new('icons/mob/blob.dmi', "blob_node_overlay")
-	src.add_overlay(C)
+	add_overlay(C)
 
-/obj/effect/blob/node/fire_act(datum/gas_mixture/air, exposed_temperature, exposed_volume)
-	return
-
-/obj/effect/blob/node/Destroy()
+/obj/structure/blob/node/Destroy()
 	blob_nodes -= src
 	STOP_PROCESSING(SSobj, src)
 	return ..()
 
-/obj/effect/blob/node/Life()
+/obj/structure/blob/node/Life()
 	Pulse_Area(overmind, 10, 3, 2)
-	color = null
+

code/game/gamemodes/blob/blobs/resource.dm

@@ -1,26 +1,26 @@
-/obj/effect/blob/resource
+/obj/structure/blob/resource
 	name = "resource blob"
 	icon = 'icons/mob/blob.dmi'
 	icon_state = "blob_resource"
 	desc = "A thin spire of slightly swaying tendrils."
-	health = 60
-	maxhealth = 60
+	obj_integrity = 60
+	max_integrity = 60
 	point_return = 15
 	var/resource_delay = 0
 
-/obj/effect/blob/resource/scannerreport()
+/obj/structure/blob/resource/scannerreport()
 	return "Gradually supplies the blob with resources, increasing the rate of expansion."
 
-/obj/effect/blob/resource/creation_action()
+/obj/structure/blob/resource/creation_action()
 	if(overmind)
 		overmind.resource_blobs += src
 
-/obj/effect/blob/resource/Destroy()
+/obj/structure/blob/resource/Destroy()
 	if(overmind)
 		overmind.resource_blobs -= src
 	return ..()
 
-/obj/effect/blob/resource/Be_Pulsed()
+/obj/structure/blob/resource/Be_Pulsed()
 	. = ..()
 	if(resource_delay > world.time)
 		return

code/game/gamemodes/blob/blobs/shield.dm

@@ -1,21 +1,36 @@
-/obj/effect/blob/shield
+/obj/structure/blob/shield
 	name = "strong blob"
 	icon = 'icons/mob/blob.dmi'
-	icon_state = "blob_idle"
+	icon_state = "blob_shield"
 	desc = "A solid wall of slightly twitching tendrils."
-	health = 150
-	maxhealth = 150
-	brute_resist = 0.1
+	obj_integrity = 150
+	max_integrity = 150
+	brute_resist = 0.25
 	explosion_block = 3
 	point_return = 4
 	atmosblock = 1
+	armor = list(melee = 0, bullet = 0, laser = 0, energy = 0, bomb = 0, bio = 0, rad = 0, fire = 90, acid = 90)
 
 
-/obj/effect/blob/shield/scannerreport()
-	return "Will prevent the spread of atmospheric changes."
 
-/obj/effect/blob/shield/fire_act(datum/gas_mixture/air, exposed_temperature, exposed_volume)
-	return
+/obj/structure/blob/shield/scannerreport()
+	if(atmosblock)
+		return "Will prevent the spread of atmospheric changes."
+	return "N/A"
 
-/obj/effect/blob/shield/core
+/obj/structure/blob/shield/core
 	point_return = 0
+
+/obj/structure/blob/shield/update_icon()
+	..()
+	if(obj_integrity <= 75)
+		icon_state = "blob_shield_damaged"
+		name = "weakened strong blob"
+		desc = "A wall of twitching tendrils."
+		atmosblock = 0
+	else
+		icon_state = initial(icon_state)
+		name = initial(name)
+		desc = initial(desc)
+		atmosblock = 1
+	air_update_turf(1)