12/21 modernizations from TG live (#103)

* sync (#3)

* shuttle auto call

* Merge /vore into /master (#39)

* progress

* Compile errors fixed

No idea if it's test worthy tho as conflicts with race overhaul and
narky removal.

* Update admins.txt

* efforts continue

Fuck grab code, seriously

* grab code is cancer

* Execute the Narkism

Do not hesitate.

Show no mercy.

* holy shit grab code is awful

* have I bitched about grab code

My bitching, let me show you it

* código de agarre es una mierda

No really it is

* yeah I don't even know anymore.

* Lolnope. Fuck grab code

* I'm not even sure what to fix anymore

* Self eating is not an acceptable fate

* Taste the void, son.

* My code doesn't pass it's own sanity check.

Maybe it's a sign of things to come.

* uncommented and notes

* It Works and I Don't Know Why (#38)

* shuttle auto call

* it works and I don't know why

* Subsystem 12/21

Most Recent TG subsystem folder

* globalvars 12/21

Tossed out the flavor_misc and parallax files

* Onclick 12/21

as well as .dme updates

* _defines 12/21

ommited old _MC.dm

* _HELPERS 12/21

Preserved snowflake placement of furry sprites

* _defeines/genetics

reapplied narkism holdover for snowflake races.

* Oops forgot mutant colors

* modules porting 12/21 + Sounds/icons

Admin, Client and most of mob life files ommitted

* enviroment file

* Admin optimizations

ahelp log system kept

* Mob ports 12/21

Flavor text preserved

* datums ported 12/21

* Game ported 12/21

* batch of duplicate fixes/dogborg work

Dogborgs need to be modernized to refractored borg standards.

* moar fixes

* Maps and futher compile fixes

code/game/gamemodes/devil/true_devil/_true_devil.dm

@@ -11,8 +11,8 @@
 	gender = NEUTER
 	health = 350
 	maxHealth = 350
-	ventcrawler = 0
-	density = 0
+	ventcrawler = VENTCRAWLER_NONE
+	density = 1
 	pass_flags =  0
 	var/ascended = 0
 	sight = (SEE_TURFS | SEE_OBJS)
@@ -22,13 +22,20 @@
 	mob_size = MOB_SIZE_LARGE
 	var/mob/living/oldform
 	var/list/devil_overlays[DEVIL_TOTAL_LAYERS]
+	bodyparts = list(/obj/item/bodypart/chest/devil, /obj/item/bodypart/head/devil, /obj/item/bodypart/l_arm/devil,
+					 /obj/item/bodypart/r_arm/devil, /obj/item/bodypart/r_leg/devil, /obj/item/bodypart/l_leg/devil)
+
+
 
 /mob/living/carbon/true_devil/New()
-	internal_organs += new /obj/item/organ/brain/
+	create_bodyparts() //initialize bodyparts
+
+	create_internal_organs()
+	..()
+
+/mob/living/carbon/true_devil/create_internal_organs()
+	internal_organs += new /obj/item/organ/brain
 	internal_organs += new /obj/item/organ/tongue
-	for(var/X in internal_organs)
-		var/obj/item/organ/I = X
-		I.Insert(src)
 	..()
 
 
@@ -45,13 +52,13 @@
 /mob/living/carbon/true_devil/Login()
 	..()
 	mind.announceDevilLaws()
+	mind.announce_objectives()
 
 
 /mob/living/carbon/true_devil/death(gibbed)
 	stat = DEAD
 	..(gibbed)
-	drop_l_hand()
-	drop_r_hand()
+	drop_all_held_items()
 	spawn (0)
 		mind.devilinfo.beginResurrectionCheck(src)
 
@@ -60,18 +67,12 @@
 	var/msg = "<span class='info'>*---------*\nThis is \icon[src] <b>[src]</b>!\n"
 
 	//Left hand items
-	if(l_hand && !(l_hand.flags&ABSTRACT))
-		if(l_hand.blood_DNA)
-			msg += "<span class='warning'>It is holding \icon[l_hand] [l_hand.gender==PLURAL?"some":"a"] blood-stained [l_hand.name] in its left hand!</span>\n"
-		else
-			msg += "It is holding \icon[l_hand] \a [l_hand] in its left hand.\n"
-
-	//Right hand items
-	if(r_hand && !(r_hand.flags&ABSTRACT))
-		if(r_hand.blood_DNA)
-			msg += "<span class='warning'>It is holding \icon[r_hand] [r_hand.gender==PLURAL?"some":"a"] blood-stained [r_hand.name] in its right hand!</span>\n"
-		else
-			msg += "It is holding \icon[r_hand] \a [r_hand] in its right hand.\n"
+	for(var/obj/item/I in held_items)
+		if(!(I.flags & ABSTRACT))
+			if(I.blood_DNA)
+				msg += "<span class='warning'>It is holding \icon[I] [I.gender==PLURAL?"some":"a"] blood-stained [I.name] in its [get_held_index_name(get_held_index_of_item(I))]!</span>\n"
+			else
+				msg += "It is holding \icon[I] \a [I] in its [get_held_index_name(get_held_index_of_item(I))].\n"
 
 	//Braindead
 	if(!client && stat != DEAD)
@@ -81,9 +82,9 @@
 	if(stat == DEAD)
 		msg += "<span class='deadsay'>The hellfire seems to have been extinguished, for now at least.</span>\n"
 	else if(health < (maxHealth/10))
-		msg += "<span class='warning'>You can see hellfire inside of it's gaping wounds.</span>\n"
+		msg += "<span class='warning'>You can see hellfire inside of its gaping wounds.</span>\n"
 	else if(health < (maxHealth/2))
-		msg += "<span class='warning'>You can see hellfire inside of it's wounds.</span>\n"
+		msg += "<span class='warning'>You can see hellfire inside of its wounds.</span>\n"
 	msg += "*---------*</span>"
 	user << msg
 
@@ -101,11 +102,17 @@
 /mob/living/carbon/true_devil/assess_threat()
 	return 666
 
-/mob/living/carbon/true_devil/flash_eyes(intensity = 1, override_blindness_check = 0, affect_silicon = 0)
+/mob/living/carbon/true_devil/flash_act(intensity = 1, override_blindness_check = 0, affect_silicon = 0)
 	if(mind && has_bane(BANE_LIGHT))
 		mind.disrupt_spells(-500)
 		return ..() //flashes don't stop devils UNLESS it's their bane.
 
+/mob/living/carbon/true_devil/soundbang_act()
+	return 0
+
+/mob/living/carbon/true_devil/get_ear_protection()
+	return 2
+
 
 /mob/living/carbon/true_devil/attacked_by(obj/item/I, mob/living/user, def_zone)
 	var/weakness = check_weakness(I, user)
@@ -123,12 +130,9 @@
 			attack_message = "[user] has [message_verb] [src] with [I]!"
 	if(message_verb)
 		visible_message("<span class='danger'>[attack_message]</span>",
-		"<span class='userdanger'>[attack_message]</span>")
+		"<span class='userdanger'>[attack_message]</span>", null, COMBAT_MESSAGE_RANGE)
 	return TRUE
 
-/mob/living/carbon/true_devil/UnarmedAttack(atom/A, proximity)
-	A.attack_hand(src)
-
 /mob/living/carbon/true_devil/Process_Spacemove(movement_dir = 0)
 	return 1
 
@@ -206,4 +210,14 @@
 		if(has_bane(BANE_LIGHT))
 			b_loss *=2
 		adjustBruteLoss(b_loss)
-	return ..()
+	return ..()
+
+
+/mob/living/carbon/true_devil/update_body() //we don't use the bodyparts layer for devils.
+	return
+
+/mob/living/carbon/true_devil/update_body_parts()
+	return
+
+/mob/living/carbon/true_devil/update_damage_overlays() //devils don't have damage overlays.
+	return

code/game/gamemodes/devil/true_devil/inventory.dm

@@ -4,10 +4,12 @@
 		return 1
 	return 0
 
-/mob/living/carbon/true_devil/proc/update_inv_hands()
+/mob/living/carbon/true_devil/update_inv_hands()
 	//TODO LORDPIDEY:  Figure out how to make the hands line up properly.  the l/r_hand_image should use the down sprite when facing down, left, or right, and the up sprite when facing up.
 	remove_overlay(DEVIL_HANDS_LAYER)
 	var/list/hands_overlays = list()
+	var/obj/item/l_hand = get_item_for_held_index(1) //hardcoded 2-hands only, for now.
+	var/obj/item/r_hand = get_item_for_held_index(2)
 
 	if(r_hand)
 
@@ -21,7 +23,8 @@
 
 		if(client && hud_used && hud_used.hud_version != HUD_STYLE_NOHUD)
 			r_hand.layer = ABOVE_HUD_LAYER
-			r_hand.screen_loc = ui_rhand
+			r_hand.plane = ABOVE_HUD_PLANE
+			r_hand.screen_loc = ui_hand_position(get_held_index_of_item(r_hand))
 			client.screen |= r_hand
 
 	if(l_hand)
@@ -36,19 +39,13 @@
 
 		if(client && hud_used && hud_used.hud_version != HUD_STYLE_NOHUD)
 			l_hand.layer = ABOVE_HUD_LAYER
-			l_hand.screen_loc = ui_lhand
+			l_hand.plane = ABOVE_HUD_PLANE
+			l_hand.screen_loc = ui_hand_position(get_held_index_of_item(l_hand))
 			client.screen |= l_hand
 	if(hands_overlays.len)
 		devil_overlays[DEVIL_HANDS_LAYER] = hands_overlays
 	apply_overlay(DEVIL_HANDS_LAYER)
 
-/mob/living/carbon/true_devil/update_inv_l_hand()
-	update_inv_hands()
-
-
-/mob/living/carbon/true_devil/update_inv_r_hand()
-	update_inv_hands()
-
 /mob/living/carbon/true_devil/remove_overlay(cache_index)
 	if(devil_overlays[cache_index])
 		overlays -= devil_overlays[cache_index]